From: Odelu Kukatla <quic_okukatla@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
<cros-qcom-dts-watchers@chromium.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-hardening@vger.kernel.org>, <quic_rlaggysh@quicinc.com>,
<quic_mdtipton@quicinc.com>
Subject: Re: [PATCH v5 2/4] interconnect: qcom: sc7280: enable QoS configuration
Date: Fri, 21 Jun 2024 23:13:34 +0530 [thread overview]
Message-ID: <d6c4ceed-5804-473a-8599-405d4ace099f@quicinc.com> (raw)
In-Reply-To: <910af90e-affb-45f2-a2f7-875ca8362c0f@linaro.org>
On 6/18/2024 8:16 PM, Konrad Dybcio wrote:
>
>
> On 6/7/24 19:39, Odelu Kukatla wrote:
>> Enable QoS configuration for master ports with predefined values
>> for priority and urgency forawrding.
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
>> ---
>
> msm-5.4 also has a qhm_gic node with QoS offset 0x9000, is that of any
> importance, or can we forget it exists?
>
qhm_gic node QoS is not that important, it is fine.
> LGTM otherwise:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> Konrad
Thanks for the review!
Regards,
Odelu
next prev parent reply other threads:[~2024-06-21 17:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 17:39 [PATCH v5 0/4] Add support for QoS configuration Odelu Kukatla
2024-06-07 17:39 ` [PATCH v5 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support Odelu Kukatla
2024-06-18 14:47 ` Konrad Dybcio
2024-06-07 17:39 ` [PATCH v5 2/4] interconnect: qcom: sc7280: enable QoS configuration Odelu Kukatla
2024-06-18 14:46 ` Konrad Dybcio
2024-06-21 17:43 ` Odelu Kukatla [this message]
2024-07-01 16:42 ` Bjorn Andersson
2024-07-01 23:32 ` Georgi Djakov
2024-07-02 18:01 ` Odelu Kukatla
2024-06-07 17:39 ` [PATCH v5 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280 Odelu Kukatla
2024-06-13 16:28 ` Rob Herring (Arm)
2024-06-07 17:39 ` [PATCH v5 4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration Odelu Kukatla
2024-06-18 14:47 ` Konrad Dybcio
2024-06-25 13:37 ` Georgi Djakov
2024-06-07 21:20 ` [PATCH v5 0/4] Add support for QoS configuration Dmitry Baryshkov
2024-06-26 4:30 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c4ceed-5804-473a-8599-405d4ace099f@quicinc.com \
--to=quic_okukatla@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox