From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <quic_jingyw@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property
Date: Tue, 3 Sep 2024 10:56:15 +0200 [thread overview]
Message-ID: <d77a0178-7e6d-445b-bc08-3a63606bc598@kernel.org> (raw)
In-Reply-To: <7688ac1c-14da-46a2-a5dc-f01c104485f8@quicinc.com>
On 03/09/2024 10:38, Jingyi Wang wrote:
>
>
> On 9/3/2024 4:00 PM, Krzysztof Kozlowski wrote:
>> On 03/09/2024 09:30, Jingyi Wang wrote:
>>>
>>>
>>> On 9/3/2024 3:10 PM, Krzysztof Kozlowski wrote:
>>>> On Tue, Sep 03, 2024 at 02:21:29PM +0800, Jingyi Wang wrote:
>>>>> Add a property "num-banks" for errata.
>>>>
>>>> This you said in commit subject and we see in the diff. You *MUST*
>>>> explain why.
>>>>
> Usually the num of LLCC banks is read from hardware, but there is errata
> on some SoCs to get the wrong bank num from LLCC_COMMON_STATUS0. Add a
> property "num-banks" to indicate the accurate data.
You have compatible for that. Anyway, your future patch must clearly
explain the problem in details.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-03 8:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 6:21 [PATCH 0/4] soc: qcom: llcc: Add llcc support for the QCS8300 platform Jingyi Wang
2024-09-03 6:21 ` [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property Jingyi Wang
2024-09-03 7:10 ` Krzysztof Kozlowski
2024-09-03 7:30 ` Jingyi Wang
2024-09-03 8:00 ` Krzysztof Kozlowski
2024-09-03 8:38 ` Jingyi Wang
2024-09-03 8:56 ` Krzysztof Kozlowski [this message]
2024-09-03 6:21 ` [PATCH 2/4] dt-bindings: cache: qcom,llcc: Document the QCS8300 LLCC Jingyi Wang
2024-09-03 7:11 ` Krzysztof Kozlowski
2024-09-03 6:21 ` [PATCH 3/4] soc: qcom: llcc: add errata to get bank num Jingyi Wang
2024-09-03 7:13 ` Krzysztof Kozlowski
2024-09-03 7:17 ` Jingyi Wang
2024-09-03 7:19 ` Krzysztof Kozlowski
2024-09-03 7:28 ` Jingyi Wang
2024-09-05 13:29 ` Konrad Dybcio
2024-09-06 5:43 ` Jingyi Wang
2024-09-03 6:21 ` [PATCH 4/4] soc: qcom: llcc: Add llcc configuration support for the QCS8300 platform Jingyi Wang
2024-09-03 7:14 ` Krzysztof Kozlowski
2024-09-03 7:18 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77a0178-7e6d-445b-bc08-3a63606bc598@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jingyw@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox