From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: apq8084-ifc6540: fix overriding SDHCI
Date: Mon, 5 Dec 2022 08:43:13 +0100 [thread overview]
Message-ID: <d79fb2b2-6a79-8be2-e3ae-e24a7212fbaa@linaro.org> (raw)
In-Reply-To: <CAA8EJppUkXMt7nvzkWoLGqyvLSjX2Kn0D2C1AH2VJ9jBdyWKSQ@mail.gmail.com>
On 04/12/2022 12:11, Dmitry Baryshkov wrote:
> On Sun, 4 Dec 2022 at 10:46, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> While changing node names of APQ8084 SDHCI, the ones in IFC6540 board
>> were not updated leading to disabled and misconfigured SDHCI.
>>
>> Cc: <stable@vger.kernel.org>
>> Fixes: 2477d81901a2 ("ARM: dts: qcom: Fix sdhci node names - use 'mmc@'")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Minor nit below.
>
>> ---
>> arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 20 ++++++++++----------
>> arch/arm/boot/dts/qcom-apq8084.dtsi | 4 ++--
>> 2 files changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> index 44cd72f1b1be..116e59a3b76d 100644
>> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> @@ -19,16 +19,16 @@ soc {
>> serial@f995e000 {
>> status = "okay";
>> };
>> + };
>> +};
>>
>> - sdhci@f9824900 {
>> - bus-width = <8>;
>> - non-removable;
>> - status = "okay";
>> - };
>> +&sdhc_1 {
>> + bus-width = <8>;
>> + non-removable;
>> + status = "okay";
>> +};
>>
>> - sdhci@f98a4900 {
>> - cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>> - bus-width = <4>;
>> - };
>> - };
>> +&sdhc_2 {
>> + cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>> + bus-width = <4>;
>
> Technically this will still be disabled, as there is no 'status = "okay";' here.
>
Yes, but I think this is separate issue, not related to node renaming.
The initial patch which added these said:
"required for enabling the serial port and eMMC."
so I assume SD card controller was meant to stay disabled.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-05 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 8:46 [PATCH] ARM: dts: qcom: apq8084-ifc6540: fix overriding SDHCI Krzysztof Kozlowski
2022-12-04 11:11 ` Dmitry Baryshkov
2022-12-05 7:43 ` Krzysztof Kozlowski [this message]
2022-12-28 18:13 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d79fb2b2-6a79-8be2-e3ae-e24a7212fbaa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox