From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Georgi Djakov" <djakov@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] interconnect: qcom: Convert to platform remove callback returning void
Date: Tue, 17 Oct 2023 18:33:25 +0200 [thread overview]
Message-ID: <d7d37fcf-e902-499e-a43b-c4b03d3e2caa@linaro.org> (raw)
In-Reply-To: <20231015135955.1537751-2-u.kleine-koenig@pengutronix.de>
On 10/15/23 15:59, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Several drivers use qcom_icc_rpmh_remove() as remove callback which
> returns zero unconditionally. Make it return void and use .remove_new in
> the drivers. There is no change in behaviour.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
prev parent reply other threads:[~2023-10-17 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 13:59 [PATCH] interconnect: qcom: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-17 16:33 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d37fcf-e902-499e-a43b-c4b03d3e2caa@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox