From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 09/18] clk: qcom: camcc-sm8450: Move PLL & clk configuration to really probe
Date: Thu, 15 May 2025 17:40:06 +0200 [thread overview]
Message-ID: <d8574c30-d397-4218-ab02-e8afebe9a75d@oss.qualcomm.com> (raw)
In-Reply-To: <20250515-videocc-pll-multi-pd-voting-v4-9-571c63297d01@quicinc.com>
On 5/14/25 9:08 PM, Jagadeesh Kona wrote:
> Camera PLLs on SM8450/SM8475 require both MMCX and MXC rails to be
> kept ON to configure the PLLs properly. Hence move runtime power
> management, PLL configuration and enable critical clocks to
> qcom_cc_really_probe() which ensures all required power domains are in
> enabled state before configuring the PLLs or enabling the clocks.
>
> This change also removes the modelling for cam_cc_gdsc_clk and keeps it
> always ON from probe since using CLK_IS_CRITICAL will prevent the clock
> controller associated power domains from collapsing due to clock framework
> invoking clk_pm_runtime_get() during prepare.
generally we want two commits for such things, but let's say this time
it's okay
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-05-15 15:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 19:08 [PATCH v4 00/18] clk: qcom: Add support to attach multiple power domains in cc probe Jagadeesh Kona
2025-05-14 19:08 ` [PATCH v4 01/18] dt-bindings: clock: qcom,sm8450-videocc: Add MXC power domain Jagadeesh Kona
2025-05-14 19:08 ` [PATCH v4 02/18] dt-bindings: clock: qcom: Update sc8280xp camcc bindings Jagadeesh Kona
2025-05-14 21:15 ` Dmitry Baryshkov
2025-05-14 21:28 ` Dmitry Baryshkov
2025-05-19 8:18 ` Krzysztof Kozlowski
2025-05-21 10:02 ` Jagadeesh Kona
2025-05-21 12:46 ` Dmitry Baryshkov
2025-05-28 9:51 ` Jagadeesh Kona
2025-05-14 19:08 ` [PATCH v4 03/18] dt-bindings: clock: qcom: sm8450-camcc: Allow to specify two power domains Jagadeesh Kona
2025-05-14 19:08 ` [PATCH v4 04/18] clk: qcom: clk-alpha-pll: Add support for common PLL configuration function Jagadeesh Kona
2025-05-14 21:20 ` Dmitry Baryshkov
2025-05-14 19:08 ` [PATCH v4 05/18] clk: qcom: common: Handle runtime power management in qcom_cc_really_probe Jagadeesh Kona
2025-05-15 6:28 ` Bryan O'Donoghue
2025-05-14 19:08 ` [PATCH v4 06/18] clk: qcom: common: Add support to configure clk regs " Jagadeesh Kona
2025-05-14 21:24 ` Dmitry Baryshkov
2025-05-15 6:34 ` Bryan O'Donoghue
2025-05-21 9:43 ` Jagadeesh Kona
2025-05-14 19:08 ` [PATCH v4 07/18] clk: qcom: videocc-sm8450: Move PLL & clk configuration to really probe Jagadeesh Kona
2025-05-15 15:37 ` Konrad Dybcio
2025-05-14 19:08 ` [PATCH v4 08/18] clk: qcom: videocc-sm8550: " Jagadeesh Kona
2025-05-15 15:38 ` Konrad Dybcio
2025-05-21 9:43 ` Jagadeesh Kona
2025-05-14 19:08 ` [PATCH v4 09/18] clk: qcom: camcc-sm8450: " Jagadeesh Kona
2025-05-15 15:40 ` Konrad Dybcio [this message]
2025-05-14 19:08 ` [PATCH v4 10/18] clk: qcom: camcc-sm8550: " Jagadeesh Kona
2025-05-15 15:40 ` Konrad Dybcio
2025-05-14 19:08 ` [PATCH v4 11/18] clk: qcom: camcc-sm8650: " Jagadeesh Kona
2025-05-14 21:22 ` Dmitry Baryshkov
2025-05-15 15:41 ` Konrad Dybcio
2025-05-14 19:08 ` [PATCH v4 12/18] clk: qcom: camcc-x1e80100: " Jagadeesh Kona
2025-05-14 21:22 ` Dmitry Baryshkov
2025-05-15 15:42 ` Konrad Dybcio
2025-05-14 19:08 ` [PATCH v4 13/18] arm64: dts: qcom: sm8450: Additionally manage MXC power domain in videocc Jagadeesh Kona
2025-05-15 15:42 ` Konrad Dybcio
2025-05-14 19:08 ` [PATCH v4 14/18] arm64: dts: qcom: sm8550: " Jagadeesh Kona
2025-05-15 15:42 ` Konrad Dybcio
2025-05-14 19:09 ` [PATCH v4 15/18] arm64: dts: qcom: sm8650: " Jagadeesh Kona
2025-05-15 15:42 ` Konrad Dybcio
2025-05-14 19:09 ` [PATCH v4 16/18] arm64: dts: qcom: sm8450: Additionally manage MXC power domain in camcc Jagadeesh Kona
2025-05-14 21:23 ` Dmitry Baryshkov
2025-05-15 15:35 ` Konrad Dybcio
2025-05-14 19:09 ` [PATCH v4 17/18] arm64: dts: qcom: sm8550: " Jagadeesh Kona
2025-05-14 21:23 ` Dmitry Baryshkov
2025-05-15 15:35 ` Konrad Dybcio
2025-05-14 19:09 ` [PATCH v4 18/18] arm64: dts: qcom: sm8650: " Jagadeesh Kona
2025-05-14 21:23 ` Dmitry Baryshkov
2025-05-15 15:34 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8574c30-d397-4218-ab02-e8afebe9a75d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox