Re: [PATCH v3 2/2] interconnect: qcom: Add Milos interconnect provider driver

[Georgi Djakov <djakov@kernel.org>]

Hi Luca,

On 7/9/25 4:14 PM, Luca Weiss wrote:
> Add driver for the Qualcomm interconnect buses found in Milos based
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>   drivers/interconnect/qcom/Kconfig  |    9 +
>   drivers/interconnect/qcom/Makefile |    2 +
>   drivers/interconnect/qcom/milos.c  | 1837 ++++++++++++++++++++++++++++++++++++
>   3 files changed, 1848 insertions(+)
> 
[..]
> +
> +static struct qcom_icc_qosbox qhm_qup1_qos = {
> +	.num_ports = 1,
> +	.port_offsets = { 0xc000 },
> +	.prio = 2,
> +	.urg_fwd = 0,
> +	.prio_fwd_disable = 1,
> +};

Thanks for adding QoS!

> +
> +static struct qcom_icc_node qhm_qup1 = {
> +	.name = "qhm_qup1",
> +	.channels = 1,
> +	.buswidth = 4,
> +	.qosbox = &qhm_qup1_qos,
> +	.link_nodes = { &qns_a1noc_snoc, NULL },
> +};

It's very nice that you switched to the dynamic IDs, but please use the
current style of links (like in v1), as the the NULL terminated lists
are not merged yet. All the rest looks good!

Thanks,
Georgi