From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Cc: dikshita@codeaurora.org, jonathan@marek.ca, vgarodia@codeaurora.org
Subject: Re: [PATCH v2 00/25] media: venus: Enable 6xx support
Date: Tue, 23 Mar 2021 14:07:24 +0000 [thread overview]
Message-ID: <d9424934-9594-33bb-e109-d727df03741c@linaro.org> (raw)
In-Reply-To: <d7f250f7-65dd-9dc5-7b6e-d304a879f5e7@linaro.org>
On 23/03/2021 12:20, Stanimir Varbanov wrote:
> Hi Bryan,
>
> Thanks for your work!
>
> On 3/12/21 7:30 PM, Bryan O'Donoghue wrote:
>> V2:
>> - Adds Acked-by as indicated - Stan
>> - Fixes typo in patch #1 22000000 -> 220000000 - Stan
>> - Fixes setting of clk_set_rate in core_clks_enable
>> unbreaks regression for 1xx/db410c - Stan
>> - "Add 6xx AXI halt logic"
>> * Polled read removed - Stan
>> * Redundant comments removed - Stan
>> * Delay assocaited with LPI write removed entirely
>> experimentation shows a delay is not required - Stan/Bryan
>> - Unifies intbuf_types_6xx_enc and intbuf_types_6xx_dec into
>> intbuf_types_6xx
>> Looking at the code the separate arrays was a NOP anyway - Stan/Bryan
>> - Ensures venus_helper_set_format_constraints() runs for 6xx only
>> - Differentiates stop address between 6xx and >= 4xx
>> 0xdeadb000 >= 4xx
>> 0x00000000 == 6xx - Stan
>>
>> With the fixes in place for db410c I've verified this code now on
>> sm8250/rb5 sdm845/rb3 and msm8916/db410c
>
> You have my ack for all patches
>
> Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> except 21/25 and 24/25 who have comments.
>
>>
>> yaml: pending - acked waiting application
>> https://www.spinics.net/lists/devicetree/msg406892.html
>
> I'll take this through media-tree once driver patchset is ready.
>
Thanks Stan.
I'll get something re-posted this week after Connect.
---
bod
prev parent reply other threads:[~2021-03-23 14:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 17:30 [PATCH v2 00/25] media: venus: Enable 6xx support Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 01/25] media: venus: Update v6 buffer descriptors Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 02/25] media: venus: core,pm: Add handling for resets Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 03/25] media: venus: core: add sm8250 DT compatible and resource data Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 04/25] media: venus: core: Add io base variables for each block Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 05/25] media: venus: hfi,pm,firmware: Convert to block relative addressing Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 06/25] media: venus: hfi: Define block offsets for V6 hardware Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 07/25] media: venus: hfi: Define additional 6xx registers Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 08/25] media: venus: core: Add differentiator IS_V6(core) Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 09/25] media: venus: core: Add an io base for TZ wrapper regs Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 10/25] media: venus: core: Add an io base for AON regs Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 11/25] media: venus: core: Hook to V6 base registers when appropriate Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 12/25] media: venus: hfi: Add a 6xx boot logic Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 13/25] media: venus: hfi: Add 6xx interrupt support Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 14/25] media: venus: hfi: Read WRAPPER_TZ_CPU_STATUS_V6 on 6xx Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 15/25] media: venus: hfi, vdec: v6 Add IS_V6() to existing IS_V4() if locations Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 16/25] media: venus: pm: Hook 6xx pm ops into 4xx pm ops Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 17/25] media: venus: core,pm: Vote for min clk freq during venus boot Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 18/25] media: venus: hfi: Add 6xx AXI halt logic Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 19/25] media: venus: pm: Toggle 6xx wrapper power in vcodec_control Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 20/25] media: venus: firmware: Do not toggle WRAPPER_A9SS_SW_RESET on 6xx Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 21/25] media: venus: helpers: Add internal buffer list for v6 Bryan O'Donoghue
2021-03-17 9:59 ` dikshita
2021-03-12 17:30 ` [PATCH v2 22/25] media: venus: helpers, hfi, vdec: Set actual plane constraints to FW Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 23/25] media: venus: hfi: Increase plat_buf_v6 o/p buffer count Bryan O'Donoghue
2021-03-12 17:30 ` [PATCH v2 24/25] media: venus: helper: Decide work mode Bryan O'Donoghue
2021-03-22 13:12 ` Stanimir Varbanov
2021-03-12 17:30 ` [PATCH v2 25/25] media: venus: vdec: Fix decoder cmd STOP issue Bryan O'Donoghue
2021-03-23 12:20 ` [PATCH v2 00/25] media: venus: Enable 6xx support Stanimir Varbanov
2021-03-23 14:07 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9424934-9594-33bb-e109-d727df03741c@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dikshita@codeaurora.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox