From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C5013D628 for ; Tue, 9 Apr 2024 15:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712676956; cv=none; b=CEij24QUeYe4/J6IF5gtphd+UTauh74cW1De3XL7NawkqQEneYLmM9wHsqw7jC5/f1/Cqh2HEAp8le2HV0/7GFwJ+UuisLP4n0m/2YMprVt1sjGKoN/KPes8YEesHME/OkHBSGkIfgZ+35kbZzOtJc4avSTvcOVn7K80buS8ZO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712676956; c=relaxed/simple; bh=z5AF5xY1j5K4ShCi88r9SGOibb/8QoN3dzNf4V00bdo=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=sl1ip7/8+mbRSTTzaNEhemvAdhsNq5avHGjVFzP9/YFsoGBASSpYKbTcJ5bFNKTowZ5DOGmee9cXpjufL8OHEDAAAATgh93CsW4jHPIpMUT1CyEC6e44VUf900qjn5+U+48usjGrKf9skcXQzetyGDEsNv4q4zTdTKyK+6fcVf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uHsfcDCm; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uHsfcDCm" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-34339f01cd2so4331851f8f.2 for ; Tue, 09 Apr 2024 08:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712676953; x=1713281753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=RO/ZWp4a+TbCWiJJVnk1jNMrTa4t5wCjsm2zT6QGFvI=; b=uHsfcDCmErwWXuaCw+jBvo8ARW1yf0HFm4QkOMqc5tHfP+g72fazGhJfIsUnCt8xpe mp/xRZsIg0mgOZqJhTG8cT7McPXGJ1ukft0WWdaIUS+eWaDA2zXp8vzYYaWFVJ1n4c3f SCKvonjGJfPXnUNxwdImPJFX79k8bQBPCc+4An4JmfWG/NfhIaNniA8hj56CNjbaFfps zd1uD1WICyi/4n/5GXUDYbTz3/piVvk+Bvrj9mW0yKGLaG3FVKLIUKSdcta23cxqKwRN dydlEQziVshhvzTl9Kd5bJ8PPzPHlRyIBKwjcFbpdJ+No1jeRPUwmtUSN+f7b0r6q86a xMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712676953; x=1713281753; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RO/ZWp4a+TbCWiJJVnk1jNMrTa4t5wCjsm2zT6QGFvI=; b=HUJxImteynoPWtbFZXX7pu4DkWLhXTtUPcXTh+LkzW6u7MmBRYpg94/mLcYk9v+Vmp O3XYrUGtgVKVmw3aa2j0Y6fvAzLexe91MqEr4FcgCduc20x9pXdPxXHbb/qZudClkAC7 bxtzgdv2NQ9zUKxQw5K7aYjfUQ57A7T4uz0oAc5Ng5K6tG426fjOrq10oUBAjwI2glka hQ2jZ5p3Mv1goW/eIcDE1F9DjAu4Ywa8E3i7Jl0TWgIhgVfdZJNMVu3kdXfaX8UltCLK CjULB1IzIuwtAe6IxEBMaItNSK/NxqJ1CuOF//0iukRCwaXLEgOqh/kCrPJUVNC9tqPr SX9w== X-Forwarded-Encrypted: i=1; AJvYcCUByxZwNG2Q5rq6rbBr5aiDti/i9gHbnxAHXlRPx5taH8Xc1Pfda3wYM/GqJ5RMqtWh/0S1Pdj/P8pycLoy1cADZByO/lqN1PB1RrvkPQ== X-Gm-Message-State: AOJu0Yxhky0tdMQ2ysML0ykVuofTQe8Sy0bdxMI4AWwM7jabpySH/Yfe ZlZgaGkkG9MJtM8gSQ6ssTuvyw/1+GWiDChmTtsei780qqjITJBIZB30oD4KiIA= X-Google-Smtp-Source: AGHT+IH1MlVadqwVn3deyEvCrPmhxyitZBrEegAplbcQczNk+NJd5X1pH7M68uHU5nX6fsvXs4PUJg== X-Received: by 2002:a5d:4088:0:b0:343:7a53:16cf with SMTP id o8-20020a5d4088000000b003437a5316cfmr65352wrp.41.1712676952870; Tue, 09 Apr 2024 08:35:52 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id s7-20020a5d4ec7000000b0033dd2a7167fsm11760977wrv.29.2024.04.09.08.35.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 08:35:52 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 16:35:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] media: qcom: camss: Add new VFE driver for SM8550 From: Bryan O'Donoghue To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, quic_yon@quicinc.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20240320141136.26827-1-quic_depengs@quicinc.com> <20240320141136.26827-7-quic_depengs@quicinc.com> <18837b02-27af-4d0c-a772-bb7ce787a4c0@linaro.org> Content-Language: en-US In-Reply-To: <18837b02-27af-4d0c-a772-bb7ce787a4c0@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/04/2024 14:39, Bryan O'Donoghue wrote: > 1. Please use 'rdi' not 'n' as the parameter here and Ignore this comment 'n' is the right value here - you've already used 'rdi' in CSID which is the appropriate place 'n' is correct here. --- bod