From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: qcom: sc8280xp: Fix interrupt type of camss interrupts
Date: Fri, 6 Sep 2024 12:12:25 +0100 [thread overview]
Message-ID: <d94c322e-b26b-4f1b-bcb8-187142dc25fa@linaro.org> (raw)
In-Reply-To: <20240905164142.3475873-5-vladimir.zapolskiy@linaro.org>
On 05/09/2024 17:41, Vladimir Zapolskiy wrote:
> The expected type of all CAMSS interrupts is edge rising, fix it in
> the CAMSS device tree node for sc8280xp platform.
>
> Fixes: 5994dd60753e ("arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition")
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 40 +++++++++++++-------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 80a57aa22839..aa2678eb3bcd 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -3882,26 +3882,26 @@ camss: camss@ac5a000 {
> "vfe3",
> "csid3";
>
> - interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 468 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 640 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 758 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 759 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 760 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 761 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 762 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 764 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 464 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 640 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 641 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 762 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 764 IRQ_TYPE_EDGE_RISING>;
> interrupt-names = "csid1_lite",
> "vfe_lite1",
> "csiphy3",
Yep, downstream defines these as rising.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-09-06 11:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 16:41 [PATCH 0/6] media: dt-bindings: media: camss: Fix interrupt types Vladimir Zapolskiy
2024-09-05 16:41 ` [PATCH 1/6] media: dt-bindings: media: qcom,sc8280xp-camss: " Vladimir Zapolskiy
2024-09-06 10:31 ` Krzysztof Kozlowski
2024-09-06 10:31 ` Krzysztof Kozlowski
2024-09-06 11:06 ` Vladimir Zapolskiy
2024-09-06 12:43 ` Krzysztof Kozlowski
2024-09-05 16:41 ` [PATCH 2/6] media: dt-bindings: media: qcom,sdm845-camss: " Vladimir Zapolskiy
2024-09-06 10:32 ` Krzysztof Kozlowski
2024-09-05 16:41 ` [PATCH 3/6] media: dt-bindings: media: qcom,sm8250-camss: " Vladimir Zapolskiy
2024-09-06 10:32 ` Krzysztof Kozlowski
2024-09-05 16:41 ` [PATCH 4/6] arm64: dts: qcom: sc8280xp: Fix interrupt type of camss interrupts Vladimir Zapolskiy
2024-09-06 11:12 ` Bryan O'Donoghue [this message]
2024-09-06 14:31 ` Johan Hovold
2024-09-06 21:42 ` Vladimir Zapolskiy
2024-09-05 16:41 ` [PATCH 5/6] arm64: dts: qcom: sdm845: Fix interrupt types " Vladimir Zapolskiy
2024-09-06 11:12 ` Bryan O'Donoghue
2024-09-05 16:41 ` [PATCH 6/6] arm64: dts: qcom: sm8250: " Vladimir Zapolskiy
2024-09-06 11:12 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d94c322e-b26b-4f1b-bcb8-187142dc25fa@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox