From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB93A27FD76 for ; Thu, 24 Apr 2025 16:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511233; cv=none; b=QMO2EbJpv6pjSh3ERg9IdrfFZDcE2zefxOcDUZ+DnKM7azRs1xH53hi3W7NzAEmc+8zbr6h8ujl0dt/R1TL7aB48zQunhSqQj60WEamtqRexl7Bu93bsbCqXF/khTArCZ2XqTlFRmKNMvOd/UI6xPeS4Tj6EaXDlPoXuPMb6+4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511233; c=relaxed/simple; bh=Dw+SKeV8qbpQrNo+aH6L+cZKLIRLMEZ5C31rjsazirw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m1mJa5JSyjuVzy2KtnjJ8VsTj4+ahlvrIVBNcNsPqhCaVQJETs6NvQOFtUJNl75hXMIBawwbKxebs5LPwxkLCQPEac/8NypljPkpzC/3M4vpV8MhmPfbwdPpPe82caANXxTNKr62gFU+dpq5j7GrbU5A7YvfopEQZLebZ7iU0nY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q+N+zlIN; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q+N+zlIN" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39c1efc4577so743760f8f.0 for ; Thu, 24 Apr 2025 09:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745511230; x=1746116030; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xoqGBxqToQFbUCVFUs3Rhe0Fq/kgYP3j2kJdzJbbkmM=; b=q+N+zlINVknwYD7uAifplmEmpWWH0/d2c9tGpU3g3gr4T1Fm6EACpU5qED+CmUfQ3r qsuHeXXjppOXvh1VVxr0Y45m8jz+vOcaJhrZgARrb/gX2/OmishnKSTAKK6PbTQqqjku rFNzbfZQeOIDV2qhpjnp8E5ft55ViP+TgBpISl7ZBCNdzLyMIJ2JS4Toj8LLBqhSwWF6 OXRLuEldmKoXVN1RSde1VV98EmlRvxIIP/hytIIqzrwKqurVHOsKzHd7d4aiA0vNqPM8 IovEnTCyxIASWbpfGSHiiQocWYKrcVt+9CPWVQpEVln0HXnqKeQD5oOv5UVyjSNl6XDI Rr/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745511230; x=1746116030; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xoqGBxqToQFbUCVFUs3Rhe0Fq/kgYP3j2kJdzJbbkmM=; b=bqPw7jm7H8z68beXPgE9RcHja3P+c7RNKYNXujEY50MRW46FU2HVzVKAw2yYRyK3iF LUxPAfxC+QUvqrvZ24zeYfVUILHPe45Q6w/Wt57sWhzyE71kItBeXY/6vvmehnUSSc5Y SUh+OFTUiFeq9fx9THWSGwLrwAWsSTGBBM8+4qF1JyWdLRXb88quNXWYAJ68x74nZmAs J5KEshIJyBFr28CdctMdjgbSaw5kwVKJwZwOhVBTYmibY6bEBJtLRVmoubNfAwBPANaB kweybDSa66NLQXxmREBI7EZhlwJkg0KuH8lJXAEwau7TjedRfoO2UWz7XSHYTjxqhaW9 qHlQ== X-Gm-Message-State: AOJu0Yx0uzYOV57iiWSCWSuPHZZQx2yc9XElfETg+C90jGsAeNSgAgjY uExIDi/wI4RQutFhjoMdX1j0L0zWhCXJgUM8DUESFDT0JXxxX+C2uf6906F5DDM= X-Gm-Gg: ASbGncvoF9sIi19IJ9NiGQIeI/RuTOQp/DY1/qfJPQkEM70p2Z/2sycU4hR3NcHmGlr krssSGeItyBE7IjbP93oKiFKgLiS0aPaE8BPI5UghpWJv2JPUaXFtENKT6MZmCJ8SfbbHeUDNo/ 5ZVMzAtzeTCdVlig2RdFpyxqi+9uNJlIc6W1hckNtpa5BhIUyy7xLxQSqY4NowvmZVIg101r6o3 V3mQqrK/LM5weaKg6Pq5x2j8i+/AT+DHBcEz6UzRjkICex11g2F8+jRCp2VXjzwJ2Ymx6YVagNE hKP58RykfndaYWDOPe5AloikMcPrkkjkNpPhObS72z01RTKUBr515Bn93gkGVYlh7KwVGCRazY6 9RVTk4Q== X-Google-Smtp-Source: AGHT+IHjGEtl8c4nNfdv63Bu0fnAs76LEcgQP5CuedFuXi7DkoDIBaKDKjRS1tXSKCPZK7Jmlww6rg== X-Received: by 2002:a5d:6dac:0:b0:394:d0c3:da5e with SMTP id ffacd0b85a97d-3a06cfa827cmr2963860f8f.47.1745511230050; Thu, 24 Apr 2025 09:13:50 -0700 (PDT) Received: from [192.168.0.34] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54c4c5sm2512602f8f.88.2025.04.24.09.13.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 09:13:49 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 17:13:48 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/5] dt-bindings: media: Add qcom,x1e80100-camss To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Vladimir Zapolskiy References: <20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-0-edcb2cfc3122@linaro.org> <20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-2-edcb2cfc3122@linaro.org> <3ec3fd62-bf21-47e7-873c-ce151589d743@linaro.org> <54eeb470-cd90-4bc2-b415-6dea1ce2321d@linaro.org> <0ab31397-580f-4e5a-b9ad-d9bf79d29106@linaro.org> <36feffed-4558-4e59-97db-2f0e916dbfc7@linaro.org> <6a4ec36c-c003-4ce8-9433-8c12ed3188ee@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <6a4ec36c-c003-4ce8-9433-8c12ed3188ee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/04/2025 16:54, Krzysztof Kozlowski wrote: > On 24/04/2025 12:17, Bryan O'Donoghue wrote: >> On 24/04/2025 11:07, Krzysztof Kozlowski wrote: >>> On 24/04/2025 11:34, Bryan O'Donoghue wrote: >>>> On 24/04/2025 07:40, Krzysztof Kozlowski wrote: >>>>>> + vdd-csiphy-0p8-supply: >>>>> Same comment as other series on the lists - this is wrong name. There >>>>> are no pins named like this and all existing bindings use different name. >>>> >>>> The existing bindings are unfortunately not granular enough. >>>> >>>> I'll post s series to capture pin-names per the SoC pinout shortly. >>> How are the pins/supplies actually called? >>> >>> Best regards, >>> Krzysztof >> >> I don't think strictly algning to pin-names is what we want. >> >> Here are the input pins >> >> VDD_A_CSI_0_1_1P2 >> VDD_A_CSI_2_4_1P2 >> VDD_A_CSI_0_1_0P9 >> VDD_A_CSI_2_4_0P9 >> >> I think the right way to represent this >> >> yaml: >> csiphy0-1p2-supply >> csiphy1-1p2-supply > > But there is no separate supply for csiphy0 and csiphy1. Such split > feels fine if you have separate CSI phy device nodes, which now I wonder > - where are they? > > Best regards, > Krzysztof The main hardware argument for it is probably these PHYs do live inside of the TITAN_TOP_GDSC power-domain, which is the same collapsible power-domain that all of the other CAMSS components live inside of. As I recall we had a four way - albeit long discussion on this in Dublin, you, me, Vlad and Neil and my memory was we would implement multiple rails in the existing CAMSS PHY structure and then look at how to model the PHYs differently in DTS. The Test Pattern Generators - TPGs would then also fit into this new model for the PHYs. --- bod