From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vedang Nagar <quic_vnagar@quicinc.com>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: enable venus node
Date: Sun, 6 Oct 2024 10:26:24 +0200 [thread overview]
Message-ID: <d971e22d-8695-4739-8810-ea32c42bedbf@kernel.org> (raw)
In-Reply-To: <20241004-venus_sc7280-v1-1-4d7d8fd7e95b@quicinc.com>
On 04/10/2024 12:52, Vedang Nagar wrote:
> Enable the venus node on Qualcomm sc7280. It was made disabled
> earlier to avoid bootup crash, which is fixed now with [1].
>
> [1]
> https://lore.kernel.org/linux-media/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
>
> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 3d8410683402fd4c03c5c2951721938fff20fc77..59dafbeeab1dfd6e1b021335ba1b04767d6c24e5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -4288,8 +4288,6 @@ venus: video-codec@aa00000 {
> iommus = <&apps_smmu 0x2180 0x20>;
> memory-region = <&video_mem>;
>
> - status = "disabled";
That's just wrong. It's already enabled in other places which makes them
redundant, so patch is incomplete.
But what is more important: this is just not correct, IMO. The node
looks incomplete. You cannot enable incomplete nodes. Please carefully
read how DTS files are being constructed/used.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-06 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 10:52 [PATCH] arm64: dts: qcom: sc7280: enable venus node Vedang Nagar
2024-10-06 3:32 ` Bjorn Andersson
2024-10-06 8:26 ` Krzysztof Kozlowski [this message]
2024-10-06 19:50 ` Dmitry Baryshkov
2024-11-12 6:17 ` Vedang Nagar
2024-11-12 13:13 ` Dmitry Baryshkov
2024-11-12 14:39 ` Vedang Nagar
2024-11-12 15:19 ` Luca Weiss
2024-11-13 7:01 ` Vedang Nagar
2024-11-13 8:03 ` Luca Weiss
2025-01-07 4:11 ` Vedang Nagar
2025-01-07 7:32 ` Luca Weiss
2025-01-07 22:36 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d971e22d-8695-4739-8810-ea32c42bedbf@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_vnagar@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox