From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: david@ixit.cz, "Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Casey Connolly" <casey.connolly@linaro.org>,
"Casey Connolly" <casey@connolly.tech>,
"Joel Selvaraj" <foss@joelselvaraj.com>,
"Yassine Oudjana" <y.oudjana@protonmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Alexander Martinz" <amartinz@shiftphones.com>,
"Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Richard Acayan" <mailingradian@gmail.com>,
"Alexey Minnekhanov" <alexeymin@postmarketos.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH RFC 1/8] dt-bindings: power: supply: Add schema for Qualcomm pmi8998 fuel gauge
Date: Thu, 27 Nov 2025 11:32:30 +0100 [thread overview]
Message-ID: <d9822a0a-1256-46a0-9bbe-8b5c68efba4e@oss.qualcomm.com> (raw)
In-Reply-To: <20251124-pmi8998_fuel_gauge-v1-1-dd3791f61478@ixit.cz>
On 11/24/25 10:53 PM, David Heidelberg via B4 Relay wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Add a device-tree schema for Qualcomm PMIC 8998 fuel gauge.
>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
[...]
> + pmic {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fuel-gauge@4000 {
> + compatible = "qcom,pmi8998-fg";
> + reg = <0x4000>;
> +
> + interrupts = <0x2 0x40 0x4 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "soc-delta";
A (much much older but still) similar in functionality, the PM8916
BMS block has 6 interrupts.
pmi8998.dtsi on msm-4.4 defines a total of 16 under the fg-gen3
megadevice. I would assume that at least a majority of them are useful
and/or required for full functionality.
There's 8 under 'fg-batt-soc', 5 under 'fg-batt-info' and 3 under
'fg-memif'
The main node also consumes an IIO channel provided by the RRADC
I'm not asking you to implement all the feature delta in v2, but I
will ask you to assess what the dt-bindings for a complete solution
would look like and to fill in all the resources that will be necessary
down the line, to the best of your knowledge, so that you won't have
to wrestle with bindings updates with every new feature addition
Konrad
next prev parent reply other threads:[~2025-11-27 10:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 21:53 [PATCH RFC 0/8] Qualcomm 3rd gen fuel gauge support David Heidelberg via B4 Relay
2025-11-24 21:53 ` [PATCH RFC 1/8] dt-bindings: power: supply: Add schema for Qualcomm pmi8998 fuel gauge David Heidelberg via B4 Relay
2025-11-27 10:32 ` Konrad Dybcio [this message]
2025-11-24 21:53 ` [PATCH RFC 2/8] power: supply: Add driver for Qualcomm PMI8998 " David Heidelberg via B4 Relay
2025-11-25 23:13 ` Dmitry Baryshkov
2025-11-26 16:35 ` Joel Selvaraj
2025-11-29 1:36 ` Dmitry Baryshkov
2025-11-27 15:28 ` Konrad Dybcio
2025-12-12 15:22 ` David Heidelberg
2025-12-18 14:59 ` Konrad Dybcio
2025-11-24 21:53 ` [PATCH RFC 3/8] arm64: dts: qcom: pmi8998: Add " David Heidelberg via B4 Relay
2025-11-25 23:16 ` Dmitry Baryshkov
2025-11-27 17:53 ` Casey Connolly
2025-11-29 2:09 ` Richard Acayan
2025-11-24 21:53 ` [PATCH RFC 4/8] arm64: dts: qcom: pm660: " David Heidelberg via B4 Relay
2025-11-25 23:17 ` Dmitry Baryshkov
2025-11-24 21:53 ` [PATCH RFC 5/8] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable " David Heidelberg via B4 Relay
2025-11-25 23:48 ` Dmitry Baryshkov
2025-11-24 21:53 ` [PATCH RFC 6/8] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2025-11-25 23:48 ` Dmitry Baryshkov
2025-11-24 21:53 ` [PATCH RFC 7/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Enable support for battery David Heidelberg via B4 Relay
2025-11-25 23:50 ` Dmitry Baryshkov
2025-11-24 21:53 ` [PATCH RFC 8/8] arm64: dts: qcom: sdm670-google-sargo: Enable fuel gauge David Heidelberg via B4 Relay
2025-11-25 23:50 ` Dmitry Baryshkov
2025-11-25 18:09 ` [PATCH RFC 0/8] Qualcomm 3rd gen fuel gauge support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9822a0a-1256-46a0-9bbe-8b5c68efba4e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=alexeymin@postmarketos.org \
--cc=amartinz@shiftphones.com \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=casey.connolly@linaro.org \
--cc=casey@connolly.tech \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=foss@joelselvaraj.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox