From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68028C6FA82 for ; Tue, 20 Sep 2022 08:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbiITIaK (ORCPT ); Tue, 20 Sep 2022 04:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbiITIaD (ORCPT ); Tue, 20 Sep 2022 04:30:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E68D86406 for ; Tue, 20 Sep 2022 01:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663662584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=da3EKRUU/aX+F/G8AcfIVmp7slwdPcDC7pD7Lc1k6T8=; b=gOS45O5UaK8JsS30HhuQn+hCISDHqHr1u05Po4G/QE1Zu/7nKbKeRoVax9jmv47Lco3FEW LFVweOwYT7IHLThPm5mvMEoO5tthsGzWh18LfQFhB38AQWB82woa5d5r0n0/FJC6WRmAeB SIPYRhCYyVXN0i/CXsJ468m28rUP/Bc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-269-SkzkH6iOM5qB_QXv4fA8iQ-1; Tue, 20 Sep 2022 04:29:42 -0400 X-MC-Unique: SkzkH6iOM5qB_QXv4fA8iQ-1 Received: by mail-wm1-f69.google.com with SMTP id i129-20020a1c3b87000000b003b33e6160bdso5931735wma.7 for ; Tue, 20 Sep 2022 01:29:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date; bh=da3EKRUU/aX+F/G8AcfIVmp7slwdPcDC7pD7Lc1k6T8=; b=ADfHKWG7qhHxkujbQnwcosJHsxFxrg/YYiKHccgPtyxle/QNOahVMrn4ZOZr5GWYoH F7gnYI4fqocsUojEcsxSkg9tAeM9eJhVuVJpz/QhMC/A6gqpilqWiH7BoZ2Y9jzqWNuf r4LH5ihgyO28qFrrIoHZrPDlTNMJwUFke4TKJz6mlfyn48YWcVZz17m9GjrkKvTPvPkh p4+f6SSFSWZ7abzoienCvlJepF+GY7y3EcDlO4bFsaQnpWH8fOG0eTOaPnpmSGnbtWqg eYLT6G7IKgiO8zA8wBQrdEyti1z446/Ut3nGoYZy0LMiEnj62VQAaeJ+0Km4aFSTiflu w5fw== X-Gm-Message-State: ACrzQf0XyWlwUfI+LywO6iHeudLSjtBiK04bPjmANcfn2QGzjI8HBbCp ktQG0ytwcq96WRMLYQAdTp8JQI00XKUZKhX3LntWqWOfYhnnlbr5O9IMMMIZRmNz8hT1HOQACJn k/v8Nf+QqwDiWXhUdDNzsvnf+vw== X-Received: by 2002:adf:eb02:0:b0:225:2b94:d14c with SMTP id s2-20020adfeb02000000b002252b94d14cmr13848119wrn.291.1663662581323; Tue, 20 Sep 2022 01:29:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XGXRZ5NH9x0iBE08TdJin8BZiQnDIHLSZamFKo6wSEPBM382Wr2hx4MknpmLHULGj3V7/oA== X-Received: by 2002:adf:eb02:0:b0:225:2b94:d14c with SMTP id s2-20020adfeb02000000b002252b94d14cmr13848101wrn.291.1663662581078; Tue, 20 Sep 2022 01:29:41 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-114-90.dyn.eolo.it. [146.241.114.90]) by smtp.gmail.com with ESMTPSA id k11-20020a05600c0b4b00b003b49ab8ff53sm1518774wmr.8.2022.09.20.01.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 01:29:40 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next 3/6] net: ipa: move and redefine ipa_version_valid() From: Paolo Abeni To: Alex Elder , davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: mka@chromium.org, evgreen@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 20 Sep 2022 10:29:39 +0200 In-Reply-To: <20220910011131.1431934-4-elder@linaro.org> References: <20220910011131.1431934-1-elder@linaro.org> <20220910011131.1431934-4-elder@linaro.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 2022-09-09 at 20:11 -0500, Alex Elder wrote: > Move the definition of ipa_version_valid(), making it a static > inline function defined together with the enumerated type in > "ipa_version.h". Define a new count value in the type. > > Rename the function to be ipa_version_supported(), and have it > return true only if the IPA version supplied is explicitly supported > by the driver. I'm wondering if the above is going to cause regressions with some IPA versions suddenly not probed anymore by the module? Additionally there are a few places checking for the now unsupported version[s], I guess that check could/should be removed? e.g. ipa_reg_irq_suspend_en_ee_n_offset(), ipa_reg_irq_suspend_info_ee_n_offset() ... Thanks, Paolo