From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A5BA32FA0D for ; Mon, 15 Dec 2025 13:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765804925; cv=none; b=bDMchAWI66oL7SB+NiD/7Ev41PvO1HLJD5iVL+VSExhMlKyxl6/4I9PPHURd/On4+oKxe6+QM3wwxkyxbqFo6pCQIh7qUFxDlFkq4YlTbrPRhmIUht9CJRRkP9V0jJXIrK5E7crMRweWXKQcDDnJGJFgLMnee2wuyvn4s2/MtIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765804925; c=relaxed/simple; bh=Onw8Vj/aDi3C22Ax82mPzLYQUuwXBUMjVocKxST25sU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pt21yXLZpzqXTwfrtTHnYv/K/eqKgsnZARQ/uf1BWs6bDEDpgdbcvvdlS0UYqczAyob+UGr651dU0df3xKIw4oQkah2Z8zeFkWKNI9DkClL8b6LGKczXPK2/DekIHEPn5uIR91ycm+EYsokuyB2wZySkURvlN81GJgROHwaoWEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CZI+sL+1; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CZI+sL+1" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-34c868b197eso1043200a91.2 for ; Mon, 15 Dec 2025 05:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765804923; x=1766409723; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XFQclEnkXOaGEQB1i5aZAavoFZmjLHt34fVvrMxQ7/0=; b=CZI+sL+1ovOsqaLU2+bZVqGF+P0/VNFjhDxkMZXxxzi0uHIHRqmYYVOYp6MHrIGkFe uK4XHR+y+qhRGFON8pfgW6/30AR51K2jaXCuDH3R1PsdmxeEgT/yjmUjrH5BbIDm8BOX 4e9HDdyQ0H5KzgCxXpsvUCHnvnqfsxICEkGXr17bqPbjwTI/kuhJ5Y7A4x7QFldRhhJd 5aISL252WWDBR0CJxWBxk/JKo84b5DGYcYK1LfEWZaloiIxMf8q0Pn7mfokNOLDA2d+S ai6UKWKpyjf+3N0Ui5r7IPx/YzYwg6nUJ5fOFihMATHkpaJAgzXs63Ly2/Fh8zFbynJB eXxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765804923; x=1766409723; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XFQclEnkXOaGEQB1i5aZAavoFZmjLHt34fVvrMxQ7/0=; b=U/AGVRQz1QX6uQpBaQ+8Un2gSXcvnJVo99GiWP/LLQKI4BKr992MLZV+qKQE7op4Ex CvzD9gwDDzIhhD0UgDy4ZtBUAqMyQVJ7FiyFSCz+2PWiAb55jELA5ef/aulnUPR6kX7B /QozdxP7zalIEcwKZQGZPjfimH/8+6oTghMYjaO5smNtdrtW+fMxX0ckk3cfM8Gkz7x8 jXq3HXITif9z0mD+RhSj//Bah8P576mfZQw+Aa33ZF3KdNv31jZ/et7FoEr0apdu0NEA 5tioL8cuPqk2jOtXFJvC4Qmp03hJXdgiHja4j3Zg+y6rXhBNiPkt32f9mUTDi7JnNQP2 4jVg== X-Forwarded-Encrypted: i=1; AJvYcCWeP6EONA0zPL0HDR01gCXSQ8YvJEIYnU+TkfOx0ons6MbEGsJ0qM0IbDqdiB5yQdxzecyJ4MxDukHjQ7cR@vger.kernel.org X-Gm-Message-State: AOJu0YxdQLK5u3YIyafMnUBo6JiLLR3c9FlX+Ap5enrGdd7B8JD8JGAw zhslA5vcAJPSpex+FU5iCtIK6qRg9/h16UHG0k4wMTVG+xYDjuPk/KljvYy/VA== X-Gm-Gg: AY/fxX5NCDGrC3tpByBckyHp4Min9ERFeFD9W35x3hNj7eNYQ+wEHAqMEQR9uSF4vln NTIbit1VK9pggZYurOPH5O05IO59M/D+AcmL+bOvQKdzBOO3oOYTO1wnS5ptdDDNpYDkREtTVoR yyS1kwSiKNbS5m8PwEwc8ulGbmajkxy1H8ZNz/3ArIzaYKGi3FHl2wkAFDhZr05TJWGaEmrDLkX czcyJ6n4YmUbIE7L8Yr2gZUMkwrtiF3CwoNcUKd873xHYgLMv06Bmzvb8hYHDFi4yOhk+uIWoHt SIjilXC6Bb2j5CWKfmnC3Di5O8mSiIRhYhhN7WzSVt68/FFc5USnsyCNn1IWd28r78JKL0+Q6Gk EoDg4hVF5l63RBcAjlEZx0kfrfDzr2/5O/TvkMZThWyV/DDFxIxEDU6D6OY4u/Xc01Q4SONSLwM e6pmPgwso5EgiJmPOel8+UEQw6jsq/IKxOJoo= X-Google-Smtp-Source: AGHT+IHbaYhxvypHifIExhwZd3l2/ucRgBsyGvQHV3xb8nXjQoVtyds84IM8xW/n7EfLN2sBoGgpmw== X-Received: by 2002:a17:90b:28cd:b0:340:d578:f299 with SMTP id 98e67ed59e1d1-34abd6cde3emr8712572a91.3.1765804922630; Mon, 15 Dec 2025 05:22:02 -0800 (PST) Received: from [172.16.20.12] ([136.226.244.245]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe129a87sm9137934a91.0.2025.12.15.05.21.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 05:22:02 -0800 (PST) Message-ID: Date: Mon, 15 Dec 2025 18:52:30 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251107105735.1491273-1-tessolveupstream@gmail.com> <20251107105735.1491273-3-tessolveupstream@gmail.com> <9b0c7cac-3577-4190-883b-7de26790b8bc@gmail.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06-12-2025 08:13, Dmitry Baryshkov wrote: > On Fri, Dec 05, 2025 at 10:58:56AM +0530, Anusha Ajithkumar wrote: >> >> >> On 03-12-2025 02:36, Dmitry Baryshkov wrote: >>> On Tue, 18 Nov 2025 at 12:16, wrote: >>>> >>>> >>>> >>>> On 14-11-2025 01:38, Dmitry Baryshkov wrote: >>>>> On Fri, Nov 07, 2025 at 04:27:35PM +0530, Sudarshan Shetty wrote: >>> >>>>>> + >>>>>> +&uart0 { >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_1_hsphy { >>>>>> + vdd-supply = <&vreg_l5a>; >>>>>> + vdda-pll-supply = <&vreg_l12a>; >>>>>> + vdda-phy-dpdm-supply = <&vreg_l13a>; >>>>>> + >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_qmpphy { >>>>>> + vdda-phy-supply = <&vreg_l5a>; >>>>>> + vdda-pll-supply = <&vreg_l12a>; >>>>>> + >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_1 { >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_1_dwc3 { >>>>>> + dr_mode = "host"; >>>>>> +}; >>>>>> + >>>>>> +&usb_hsphy_2 { >>>>> >>>>> So, the labels are usb_1_hsphy, but usb_hsphy_2? That's not logical, >>>>> please fix one of them. Then please fix the order of nodes here. >>>> >>>> The node names come directly from the included talos.dtsi, where they >>>> are defined as usb_1_hsphy & usb_hsphy_2. >>>> To avoid breaking inherited definitions, we kept the same labels >>>> in our board DTS. >>> >>> Please fix them in the base DT. >>> >> >> The inconsistent naming originates from talos.dtsi, which is >> outside the scope of this patch series. Modifying these labels >> in our board DTS would break the inherited node references >> from talos.dtsi. >> However, I will reorder the nodes so they appear in a logical and > > Please fix the base DT. There is no such thing as "out of scope". > Okay, will take care in the next patch. >>>> consistent sequence. >>> >>> This is a prerequisite, no questions. >>> >> >