Re: [PATCH v3 4/4] arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 10/01/2024 11:03, Konrad Dybcio wrote:
> 
> 
> On 1/9/24 17:06, Bryan O'Donoghue wrote:
>> Add CAMSS block definition for sc8280xp.
>>
>> This drop contains definitions for the following components on sc8280xp:
>>
>> VFE * 4
>> VFE Lite * 4
>> CSID * 4
>> CSIPHY * 4
>>
>> This dtsi definition has been developed and validated on a Lenovo X13s
>> laptop.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 239 
>> +++++++++++++++++++++++++++++++++
>>   1 file changed, 239 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> index f48dfa5e5f36..35bc31117b41 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> @@ -3614,6 +3614,245 @@ cci3_i2c1: i2c-bus@1 {
>>               };
>>           };
>> +        camss: camss@ac5a000 {
>> +            compatible = "qcom,sc8280xp-camss";
>> +
>> +            reg = <0 0x0ac5a000 0 0x2000>,
>> +                  <0 0x0ac5c000 0 0x2000>,
>> +                  <0 0x0ac65000 0 0x2000>,
>> +                  <0 0x0ac67000 0 0x2000>,
>> +                  <0 0x0acaf000 0 0x4000>,
>> +                  <0 0x0acb3000 0 0x1000>,
>> +                  <0 0x0acb6000 0 0x4000>,
>> +                  <0 0x0acba000 0 0x1000>,
>> +                  <0 0x0acbd000 0 0x4000>,
>> +                  <0 0x0acc1000 0 0x1000>,
>> +                  <0 0x0acc4000 0 0x4000>,
>> +                  <0 0x0acc8000 0 0x1000>,
>> +                  <0 0x0accb000 0 0x4000>,
>> +                  <0 0x0accf000 0 0x1000>,
>> +                  <0 0x0acd2000 0 0x4000>,
>> +                  <0 0x0acd6000 0 0x1000>,
>> +                  <0 0x0acd9000 0 0x4000>,
>> +                  <0 0x0acdd000 0 0x1000>,
>> +                  <0 0x0ace0000 0 0x4000>,
>> +                  <0 0x0ace4000 0 0x1000>;
>> +
>> +            reg-names = "csiphy2",
> The random newlines kill consistency with everything else
> 
> Konrad

Not random.

What exactly are you asking for ?

---
bod