From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7A5374E79 for ; Wed, 18 Mar 2026 08:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773822133; cv=none; b=oykYRZQblBkmEQ6w8m/XOhafPxuTxH/C8v4VMHF9lbckOgsSnyFl9K0hm7LKXUoUN8NRhR6mWpPlFiiU8fP3SH2Ap3GcgDgh9HP2FIbwHwjoJri16Xpt1cQP8cd7J6gc+zyH/PrSGoAJX3No8YEYNuYvSCMDjR7K6kfmrdZWpVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773822133; c=relaxed/simple; bh=oJSoMi3V8/F61rssIwlhY44NtZXSZpuIJGKYgzPj99E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fmo4vIQBni7HZwmqmlEaG0v5mB59dni9ABecnCTFAF9GlGKwQdMImUc1wEUTCwS19DwWdkv+on6dRNgAxGNqBN2BMgvpc689VLtnmOEsCshpABJ7/G57cFLROzj2I+Riv/9Hun5b3m2jCFVldQGB1hmiSFfNWPe7gtME86F5al0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FqIcieVh; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FqIcieVh" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b79f8f7ea43so1094376366b.2 for ; Wed, 18 Mar 2026 01:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773822129; x=1774426929; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MllRuJ1dEVjv0be6UtMae3kHWnAqjx2IN2CP9qVrdfM=; b=FqIcieVhPG5VZQS2ogWmt3owUIHy0fRnD01aUXbzWF5dXIlnrb1j33hjvtk97WZd9K FBBJp1XFgthfRkHk0ma1Ur+Oaj42Bh26B+wTROsxZ41Luk9BQbXYXRHooiFdjESb7OXi mpcsND0clEgAGBQHZNjZQETc7JOKBunlFxL6274dZX3k2aEYxLqSs5zZycPh++5X4n1D 7NMnpqAB36tuBfJmwANPc5K7S0T29IQIJZ1ukVECc1DMBqDupowb4XpP6ddgbzvpOsse kKF7gMPuPd1yfCEdqsqeSHC0H5aokaJXZqlP59v4IW72Wq8VkZBLvkg+S7athcDfS6he hfUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773822129; x=1774426929; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MllRuJ1dEVjv0be6UtMae3kHWnAqjx2IN2CP9qVrdfM=; b=aSXzmHJCoS3GvwSG3NX9nqgwHScno3K4zXxqKcC9bVUNxEPcqBxkw7m+0LDLXSCnot SWKMF3Ytbr92OlaoTt2homMP7YvGVVbQhbtwUcitkqtmSEYfnJOFc3tyx7kYMV10P45F sKdPg7l03Rs0XkjQkOjsErbpr/KC+wpM5rkUEUtXQf7iYDF2i6HQw6XXPepJzaSN1trv /9e6Ba0x4Wa8Jal8smbFHu+SLex+EyZwj3fsOEfpmnT4NvUaerwXdXz4O6puAMyNGyrF AwcQ7pkY8caYTqPBfkaZpsVn7DeP/NSdhhs9JpisOGy11GJbyJS9zJQQ0ue1Dv1/WeEl mOEw== X-Gm-Message-State: AOJu0Yw1AViFMjDR9P/dxOOOsldryogLuBqFK4UhGti9jxkWNaTyRu43 ioErOZD1leA589FCGEevzjCJf4AP2dKdhIFE268QYuXuAEK/op2yMEKo X-Gm-Gg: ATEYQzyTclN/JOV6tre/5ygVQen5+hk1VWYsvrSxROVXmc5RXRNvpMQyvhbcYwJOiQL r9U3DD2J46WZuqFQ7SAewMQm8E+6wzllZ8z1Isie2Y4K8F4YzedpNMsyGZjn7n2zhTgjSGhkjv3 i5TFIOFM6TSt1B2J5wCQIh2Tbc+e/zoqi2L/Cp+k0Gc06TQR3gNwLYlYpKA7mQ2B+8Nj9qIqd0m mkV/sisgsNyb1rohCOS/lsU22yk0gnSZR9ZioBp4IonqFBYaSYPC2D6Wa85Qfquui9oR7qAxnDc izKKZ/cv2KBb8RJ2eWdBExNBpKqXgEUmEM5bwsMYydVeHyl3bphKDalT26Nq+xmcfHYmdcH162E CiXW2uQESqI0j2xSEO3iz4CMzY7eB5N55oLlia2NOWgfDL1/3OVOO9pnJWyWWBBFnVLdp9TTNE+ FEJYrwYVz02ZSGmh658bib5N7dBkx5AIYXdnA4 X-Received: by 2002:a17:906:fe02:b0:b97:810a:1a8e with SMTP id a640c23a62f3a-b97f49b4725mr140830966b.24.1773822128278; Wed, 18 Mar 2026 01:22:08 -0700 (PDT) Received: from [192.168.1.31] ([178.227.200.173]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f142a785sm160656266b.14.2026.03.18.01.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 01:22:07 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 09:22:06 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS To: Val Packett , devicetree@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org References: <20260305093941.305122-1-zstaseg@gmail.com> <20260305093941.305122-3-zstaseg@gmail.com> <356110cc-699b-4a6d-973c-403d2e29630e@packett.cool> <168615a6-615f-46cc-b126-4780fec34ecd@gmail.com> <4b91b06c-2a88-4e6d-81db-0a7bb4972e1e@packett.cool> Content-Language: en-US From: Stanislav Zaikin In-Reply-To: <4b91b06c-2a88-4e6d-81db-0a7bb4972e1e@packett.cool> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/16/26 9:47 PM, Val Packett wrote: > > On 3/16/26 8:57 AM, Stanislav Zaikin wrote: >> On 3/16/26 5:05 AM, Val Packett wrote: >>> On 3/5/26 6:39 AM, Stanislav Zaikin wrote: >>> >>>> Xiaomi 12 Lite 5G is a handset released in 2022 >>>> >>>> This commit has the following features working: >>>> - Display (with simple fb) >>>> - Touchscreen >>>> - UFS >>>> - Power and volume buttons >>>> - Pinctrl >>>> - RPM Regulators >>>> - Remoteprocs - wifi, bluetooth >>>> - USB (Device Mode) >>>> […] >>>> +        vreg_l7b_2p96: ldo7 { >>>> +            regulator-name = "vreg_l7b_2p96"; >>>> +            /* Constrained for UFS VCC, at least until UFS driver >>>> scales voltage */ >>>> +            regulator-min-microvolt = <2952000>; >>>> +            regulator-max-microvolt = <2952000>; >>>> +            regulator-initial-mode = ; >>>> +        }; >>>> […] >>>> +&ufs_mem_hc { >>>> +    reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; >>>> + >>>> +    vcc-supply = <&vreg_l7b_2p96>; >>>> +    vcc-max-microamp = <800000>; >>>> +    /* >>>> +     * Technically l9b enables an eLDO (supplied by s1b) which >>>> then powers >>>> +     * VCCQ2 of the UFS. >>>> +     */ >>>> +    vccq-supply = <&vreg_l9b_1p2>; >>>> +    vccq-max-microamp = <900000>; >>> >>> If this device has UFS 3.x flash, which it most likely does, the >>> copy-pasted eLDO comment does not apply.. and VCC range is >>> 2.4V-2.7V, 2.95 is overvoltage! >> >> Hello Val, >> >> Thank you for the review. >> >> Though you're right that this comment is a copy-paste, taoyao has >> ufs2. This is the explaining comment from the downstream sources: >> >>> /* >>> * Yupik target supports both UFS2.2 & UFS3.1, here >>> * vccq2 is supplied via eLDO, [..] >> >> So I thought it's better to keep a small comment regarding eLDO. > > That's a comment from the qcom reference sources! I've literally seen > it already in the downstream DTS for the device I'm currently working > on (motorola-dubai) which definitely has UFS 3, hehe. > > You can read > /sys/bus/platform/devices/1d84000.ufshc/device_descriptor/specification_version > to see which UFS spec version your flash is (0x310 == 3.1 etc.) /home/user # cat /sys/bus/platform/devices/1d84000.ufshc/device_descriptor/specification_version 0x0220 > (Lots of interesting stuff around there, there's also > health_descriptor that shows your flash's wear estimation..) > > Also if you have the schematics, you can check for whether an LDO is > actually present there and whether VCCQ or VCCQ2 is connected :) Unfortunately, I wasn't able to find schematics. It also a bummer that I don't know panel's name because I have a (semi-generated) driver for it. >>> If it's actually UFS 2 after all, it would be better to rename the >>> property to vccq2-supply. >> Could you elaborate please? Do you mean l9b? > > No, the "vccq-supply". If you look at > Documentation/devicetree/bindings/ufs/ufs-common.yaml you can see it > supports both `vccq-supply` and `vccq2-supply`, the former is used for > UFS3 and the latter for UFS2. Will fix it in v5. Thanks a lot for so many inputs! Best regards, Stanislav