From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37108C433DF for ; Thu, 4 Jun 2020 07:28:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 116742075B for ; Thu, 4 Jun 2020 07:28:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Ge7Hi3jz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727997AbgFDH2X (ORCPT ); Thu, 4 Jun 2020 03:28:23 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:44500 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbgFDH2W (ORCPT ); Thu, 4 Jun 2020 03:28:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591255700; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=PIILDPNgCuNv1mqjXE6f0mhEhOgXKvJv2pfDeyjwOso=; b=Ge7Hi3jzdg2C56IKxacye8TnWTfKjy/wnJvGzyFF34oStu3XRxT18UJ9Va/gVKOvTUXZJcL5 Yv9dMnu2u85BemldQ5Xb/pmCYLGt5BO11bFC68jTvERTaQh1tqelD1gXC6x7mUN/HvAttjvX /0OMvldmEHU5lLNxMVNBvaugX2k= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n10.prod.us-east-1.postgun.com with SMTP id 5ed8a27ec0031c71c29cfea2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 04 Jun 2020 07:27:58 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 79C4EC43395; Thu, 4 Jun 2020 07:27:57 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 754E9C433C6; Thu, 4 Jun 2020 07:27:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 04 Jun 2020 12:57:56 +0530 From: Sai Prakash Ranjan To: Mathieu Poirier , Robin Murphy , Will Deacon Cc: Mike Leach , Suzuki K Poulose , linux-arm-kernel , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Coresight ML , Stephen Boyd Subject: Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF In-Reply-To: <20200603174426.GA23165@xps15> References: <28123d1e19f235f97555ee36a5ed8b52d20cbdea.1590947174.git.saiprakash.ranjan@codeaurora.org> <20200601212858.GB24287@xps15> <6d759cc28628ea72767c1304883630eb@codeaurora.org> <4a09cd2e054836d85f2e024ca4435e91@codeaurora.org> <1a5a6a6d-b86d-df45-cf91-7081e70d88a3@arm.com> <20200603174426.GA23165@xps15> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Mathieu, +Will On 2020-06-03 23:14, Mathieu Poirier wrote: > On Wed, Jun 03, 2020 at 02:34:10PM +0100, Robin Murphy wrote: >> On 2020-06-03 14:22, Mike Leach wrote: >> > Hi Sai, >> > >> > On Wed, 3 Jun 2020 at 13:14, Sai Prakash Ranjan >> > wrote: >> > > >> > > Hi Mike, >> > > >> > > On 2020-06-03 16:57, Mike Leach wrote: >> > > > Hi, >> > > > >> > > > On Wed, 3 Jun 2020 at 11:24, Sai Prakash Ranjan >> > > > wrote: >> > > > > >> > > > > Hi Mike, >> > > > > >> > > > > Thanks again for looking at this. >> > > > > >> > > > > On 2020-06-03 03:42, Mike Leach wrote: >> > > > > [...] >> > > > > >> > > > > > > >> > > > > > > SMMU/IOMMU won't be able to do much here as it is the client's >> > > > > > > responsiblity to >> > > > > > > properly shutdown and SMMU device link just makes sure that >> > > > > > > SMMU(supplier) shutdown is >> > > > > > > called only after its consumers shutdown callbacks are called. >> > > > > > >> > > > > > I think this use case can be handled slightly differently than the >> > > > > > general requirements for modular CoreSight drivers. >> > > > > > >> > > > > > What is needed here is a way of stopping the underlying ETR hardware >> > > > > > from issuing data to the SMMU, until the entire device has been shut >> > > > > > down, in a way that does not remove the driver, breaking existing >> > > > > > references and causing a system crash. >> > > > > > >> > > > > > We could introduce a new mode to the ETR driver - e.g. >> > > > > > CS_MODE_SHUTDOWN. >> > > > > > >> > > > > > At the end of the block tmc_shutdown(struct amba_device *adev), set >> > > > > > drvdata->mode to CS_MODE_SHUTDOWN & remove the coresight_unregister(). >> > > > > > This new mode can be used to prevent the underlying hardware from >> > > > > > being able to restart until the device is re-powered. >> > > > > > >> > > > > > This mode can be detected in the code that enables / disables the ETR >> > > > > > and handled appropriately (updates to tmc_enable_etr_sink and >> > > > > > tmc_disable_etr_sink). >> > > > > > This mode will persist until the device is re-started - but because we >> > > > > > are on the device shutdown path this is not an issue. >> > > > > > >> > > > > > This should leave the CoreSight infrastructure stable until the >> > > > > > drivers are shut down normally as part of the device power down >> > > > > > process. >> > > > > > >> > > > > >> > > > > Sounds good to me, but if the coresight_unregister() is the trouble >> > > > > point >> > > > > causing these crashes, then can't we just remove that from >> > > > > tmc_shutdown() >> > > > > callback? This would be like maintaining the same behaviour as now >> > > > > where >> > > > > on reboot/shutdown we basically don't do anything except for disabling >> > > > > ETR. >> > > > >> > > > No - the new mode prevents race conditions where the thread shutting >> > > > down the SMMU does the ETR shutdown, but then another thread happens >> > > > to be trying to start trace and restarts the ETR. >> > > > It also prevents the condition Mathieu discussed where a thread might >> > > > be attempting to shutdown trace - this could try to disable the >> > > > hardware again re-releasing resources/ re-flushing and waiting for >> > > > stop. >> > > > >> > > >> > > I do not think there will a race between SMMU shutdown and ETR shutdown. >> > > Driver core takes care of calling SMMU shutdown after its consumer >> > > shutdown callbacks via device link, otherwise there would already be >> > > bugs in all other client drivers. >> > > >> > >> > I am not saying there could be a race between tmc_shutdowm and >> > Smmu_shutdown - there may be a case if the coresight_disable_path >> > sequence is running and gets to the point of disabling the ETR after >> > the SMMU callback has disabled it. >> >> I'm confused now - there is no "SMMU callback", we're talking about >> the >> system-wide cleanup from kernel_shutdown_prepare() or >> kernel_restart_prepare(). As far as I'm aware userspace should be long >> gone >> by that point, so although trace may have been left running, the >> chance of >> racing against other driver operations seems pretty unlikely. > > Robin has a point - user space is long gone at this time. As such the > first > question to ask is what kind of CS session was running at the time the > system > was shutting down. Was it a perf session of a sysfs session? > > I'm guessing it was a sysfs session because user space has been blown > away a > while back and part of that process should have killed all perf > sessions. I was enabling trace via sysfs. > > If I am correct then simply switching off the ETR HW in the shutdown() > amba bus > callback should be fine - otherwise Mike's approach is mandatory. > There is > also the exchange between Robin and Sai about removing the SMMU > shutdown > callback, but that thread is still incomplete. > If Robin is hinting at removing SMMU shutdown callback, then I think adding all these shutdown callbacks to all clients of SMMU can be avoided. Git blaming the thing shows it was added to avoid some kexec memory corruption. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation