From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D670B1A3058 for ; Thu, 12 Sep 2024 12:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726145056; cv=none; b=m7AktNLxginH5Tp0RMH40U6xrYCm03nAm0l7RUqZm+DRlE9Z7f43LhSo6Lj5KGLHvSiBunYPAuz7epE31MjZA3L8akzj7VMG9XZThLt2IQwfJJIwDQL3O1f7YvoR1jDiJPVucVku66ssjW/FUtbhZ7IzMmFfwgbwx7i6OYxnDPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726145056; c=relaxed/simple; bh=0urSazZdA3Q//+hFIfRp0TDi61MzX9DROm8rbQ4pKxk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gZ7k6nc/jdTFBxM6Q1nUDR5SR+plbbXlS2X+Vun44J2Fo5GFR3i1Fu3CtbyINo6tOWblUv2FqFrViGy9OcA4JqplVMPc5haj2zqL4eTZ8jW+u73htqzt3GbIQQFMSn9UM0LFL9NfFSYeCAlC8PZ7EE9Bx8fQOq87pNEUhqYLKYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aLjFVlzq; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aLjFVlzq" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2f77e07792dso285891fa.2 for ; Thu, 12 Sep 2024 05:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726145053; x=1726749853; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yMaEX9I1RQP11LCLQlJt88Oo9tTkzQ2nXArFlvuYAlk=; b=aLjFVlzq80G5RBCxwLW8/Ae8vLJOM6/Aja+kr5SbATUI8/llKfH+0eo4c0as3CQie0 whXSoXmIaSV7bhQWL6UxhymQZcHGXdhcGcq5P52SikXRT2tlAEtoxHAQY5ZmPIjCAqP1 At8HS5ovffbvraafIW6xhZKEDrsYurmUJyP8CrvjYO6kDM9/519ulp40niocedjI4dfl aovjnlsXszh165U5g4soLNSXs0G8GjXiuL7zU0jOobFEmi6/qzEWDvACKqrL2FqxStdw YoTmDOPzrystC1feTkwic5kcdWKk+16ogv9QwZDJsxlVzav8RUyFfCw5BwVIGsYlVTCU 42Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726145053; x=1726749853; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yMaEX9I1RQP11LCLQlJt88Oo9tTkzQ2nXArFlvuYAlk=; b=ZPRX7BSEm+koV+5YT9cyR96ui5ShAnnRREAAdQDTiK0gHF67vBS7d+M7YK3DmBA9w+ QZy1ElOTaR/cmcq6/AAGMj4UlNlS7Y1GoCG9M/wL3EPljjKYJDEYIlnrYvX8ieEvdRqM v5bNMM5hTZUUfQ1PSqrP5tkZieOTpWTwaN3QRZ04WCXg7IFyyJ4Jpm+KfF27JTjmJdjY GDddi5CcSbSl+v5k8pZqMUa6oahQgG5l1ssnRR/Wcj4MlPOwTPTgY23bqI7wFMr6l4NJ rcSXmyTvVvQ+PnVIDVd+p5XlPgWhUDmHJNMmKg++md39KZtFnDl7Jp/Y7/i03b4QJdHG Ix6A== X-Gm-Message-State: AOJu0YxqspZ2gIs8IqO9/FRxLo1wAPibazsE6A+s566EJZK1FjA5uYpM 3DEQF8rgNDoO+o5s9SxPbC3FGvGyQO3w5uZPcAv7QjugEQR2IKlbkCx/5Pcs0A4= X-Google-Smtp-Source: AGHT+IEsQyCCvQn8ayp0ihr0+sIEfLHDRxRsCTv6scTqDFj5NaZm60IwE+Ob1juIBiajON1Byw0mdw== X-Received: by 2002:a2e:a983:0:b0:2f7:66ce:a319 with SMTP id 38308e7fff4ca-2f787f4a5d2mr4217221fa.9.1726145052973; Thu, 12 Sep 2024 05:44:12 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5365f8cb73esm1904592e87.174.2024.09.12.05.44.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 05:44:12 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 15:44:11 +0300 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Content-Language: en-US To: Bryan O'Donoghue , Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-8-quic_depengs@quicinc.com> <82dd61ab-83c0-4f9c-a2ee-e00473f4ff23@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <82dd61ab-83c0-4f9c-a2ee-e00473f4ff23@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bryan. On 9/12/24 14:41, Bryan O'Donoghue wrote: > On 12/09/2024 09:22, Vladimir Zapolskiy wrote: >>> + >>> + vdda-phy-supply: >>> + description: >>> + Phandle to a regulator supply to PHY core block. >>> + >>> + vdda-pll-supply: >>> + description: >>> + Phandle to 1.2V regulator supply to PHY refclk pll block. >>> + >> >> Here the supplies should be split into ones, which are specific to CSI >> blocks, >> and I believe they shall be set as optional. > > In principle I agree with that, each CSIPHY should have its own vdda-phy > and vdda-pll regulator specified. > > In practice though I don't believe its necessary, below. > >> The proposed names are: >> >> vdda-phy-01-supply >> vdda-pll-01-supply >> vdda-phy-23-supply >> vdda-pll-23-supply >> vdda-phy-46-supply >> vdda-pll-46-supply >> vdda-phy-57-supply >> vdda-pll-57-supply > > In principle, you're right, we need to expand the name set here. > >> I understand that what I ask is much more clumsy, and it could be seen >> even as >> unneeded, however it'll be the right set of properties to describe the >> CAMSS IP >> in this respect > I think the following naming would be better as it matches the > power-grid naming in the docs. > > csiphyX-vdda-phy-supply > csiphyX-vdda-pll-supply I have no opinion about the names, any reason for name selection is good for me. > => > > // voltage domain = vdd_a_csi_01_09 = regulator l1e > csiphy0-vdda-phy-supply = <&vreg_l1e_0p9>; > > // voltage domain = vdd_a_csi_01_1p2 = regulator l3e > csiphy0-vdda-pll-supply = <&vreg_l3e_1p2>; > > // > csiphy1-vdda-phy-supply = <&vreg_l1e_0p9>; > csiphy1-vdda-pll-supply = <&vreg_l3e_1p2>; > > Where X indicates the CSIPHY number. > > So in fact, in practice we don't need to differentiate these entries. > > Checking x1e80100 ... Checking some particular board, right? > csiphy0 > > vdda-phy-supply = <&vreg_l2c_0p9>; > vdda-pll-supply = <&vreg_l1c_1p2>; > > This is also the case for csiphy 1/2/4 > > So, I _don't_ believe this is work we need to do, since its the same > regulator for each PHY. This is board specific, and even if the separation is not needed on the boards you have just checked, still it may be needed on some boards, which are not yet checked/not yet known. It's needed to make the best predictions about all possible usage of hardware, fortunately it's easy in this particular case, and it's trivial to correct it now than on some day later on. -- Best wishes, Vladimir