From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, arm-scmi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] regulator: bd718x7: Use scoped device node handling to simplify error paths
Date: Thu, 15 Aug 2024 08:15:31 +0300 [thread overview]
Message-ID: <daca2d03-d52d-41a3-bf68-0f524aaa603c@gmail.com> (raw)
In-Reply-To: <20240814-cleanup-h-of-node-put-regulator-v1-1-87151088b883@linaro.org>
On 8/14/24 18:04, Krzysztof Kozlowski wrote:
> Obtain the device node reference with scoped/cleanup.h and use scoped
> for_each_child_of_node_scoped() to reduce error handling and make the
> code a bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
Thanks Krzysztof! I've been a bit cautious to what comes to using the
cleanup attribute. Well, I suppose it's a time for me to admit it
simplifies things - even if it breaks the rules which were carved to a
stone for a long time :) So ... Thanks!
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2024-08-15 5:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 15:04 [PATCH 0/7] regulator: Use scoped device node handling to simplify error paths Krzysztof Kozlowski
2024-08-14 15:04 ` [PATCH 1/7] regulator: bd718x7: " Krzysztof Kozlowski
2024-08-15 5:15 ` Matti Vaittinen [this message]
2024-08-14 15:04 ` [PATCH 2/7] regulator: bd96801: " Krzysztof Kozlowski
2024-08-15 5:29 ` Matti Vaittinen
2024-08-14 15:04 ` [PATCH 3/7] regulator: max8997: " Krzysztof Kozlowski
2024-08-14 15:04 ` [PATCH 4/7] regulator: s5m8767: " Krzysztof Kozlowski
2024-08-14 15:04 ` [PATCH 5/7] regulator: qcom-rpmh: Simplify with scoped for each OF child loop Krzysztof Kozlowski
2024-08-14 15:04 ` [PATCH 6/7] regulator: qcom-smd: " Krzysztof Kozlowski
2024-08-14 15:04 ` [PATCH 7/7] regulator: scmi: " Krzysztof Kozlowski
2024-08-15 14:43 ` [PATCH 0/7] regulator: Use scoped device node handling to simplify error paths Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daca2d03-d52d-41a3-bf68-0f524aaa603c@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=arm-scmi@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox