From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31310191F75; Thu, 6 Mar 2025 09:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741252834; cv=none; b=vA5C9WRLyH1ux1QCR3Mo7DDNOMV2lckCFb6xFt9dyqXZhkKhePxfGZBepITN/brK4v/vxS6we/KkAQFtXbIXsXUOWtO6wCDEd56fdD4GJzIAfL1/wkIEtJI7jSUW/3vV+yF35lB0LtFyZp8m1SvVH0MiHrGWFjaFOIuY/Ga77RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741252834; c=relaxed/simple; bh=uBHlBDIrln1GrAHp3cN9FgNmGfoO883gfPJWP3sGgHY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=gpdlamDcnoYJTEHpo7j0td5XDdW5uczKrhQB73MOEGbFODGZ4BET++EU3/QLk6C4wxifC3WSRsRC3dslUmcWY7j3eWuOf+vwMA543g0+VAF4v1QifEHMmhgqpWrd554JhmvCa9UHlN9Wf/qt2X647h6oS3H4Cou4Bk7LWxCet9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=fFrbEVlx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="fFrbEVlx" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52694jHw023685; Thu, 6 Mar 2025 09:20:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CsysUVEkhk42vZcPM2hd34YgSe6fY17nfaO1phx5tq4=; b=fFrbEVlxrf30B4ou wOOa9UCM3IK+HxMyBkONDVnplTDd02u3d0EDvx5PN7bdoBFoQVcFl1NXz2xC7FQW yLuMCflti46J0nM7khikQWFsRW3tMwf+ogiq8Cp8ayTyklFj/N1pKXcuarvTSvBc DZSOfZjQjLSyrVGlyDbG/b94eXRyZuM5jDDgdDZZs84hAP05sQaA248kFiL21BL5 t2+09lRsVsw3/gzYNpcLScF9yCHkUflwhmyORLuLYuJg//kTnKHoBtjMPrX6bat2 uSt9w0tKioqHNjUArz1ihCKUDpHLoZoghFljVXohXJsx+4EItk+XCOCfRQefe5XR FXCLrw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 455p6t8gqe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Mar 2025 09:20:28 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 5269KRDD028567 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Mar 2025 09:20:27 GMT Received: from [10.217.216.53] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 6 Mar 2025 01:20:24 -0800 Message-ID: Date: Thu, 6 Mar 2025 14:50:21 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: gcc-sm8650: Do not turn off USB GDSCs during gdsc_disable() To: Neil Armstrong , Bjorn Andersson , Michael Turquette , Stephen Boyd CC: , , References: <20250305-topic-sm8650-upstream-fix-usb-suspend-v1-1-649036ab0557@linaro.org> Content-Language: en-US From: Taniya Das In-Reply-To: <20250305-topic-sm8650-upstream-fix-usb-suspend-v1-1-649036ab0557@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=I/ufRMgg c=1 sm=1 tr=0 ts=67c968dc cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=KKAkSRfTAAAA:8 a=COk6AnOGAAAA:8 a=M3tcf35oER1-PgU3zw8A:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 5KLN_69DrQ3QCidBBOOuWVUPYLmff5x1 X-Proofpoint-ORIG-GUID: 5KLN_69DrQ3QCidBBOOuWVUPYLmff5x1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-06_04,2025-03-06_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxlogscore=594 impostorscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503060070 On 3/6/2025 12:30 AM, Neil Armstrong wrote: > With PWRSTS_OFF_ON, USB GDSCs are turned off during gdsc_disable(). This > can happen during scenarios such as system suspend and breaks the resume > of USB controller from suspend. > > So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs > during gdsc_disable() and allow the hardware to transition the GDSCs to > retention when the parent domain enters low power state during system > suspend. > > Fixes: c58225b7e3d7 ("clk: qcom: add the SM8650 Global Clock Controller driver, part 1") > Signed-off-by: Neil Armstrong > --- > drivers/clk/qcom/gcc-sm8650.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8650.c b/drivers/clk/qcom/gcc-sm8650.c > index 9dd5c48f33bed5b944a0b25959ef69e7862d0449..fa1672c4e7d814e1e08c79f9cda9463bf1cd1598 100644 > --- a/drivers/clk/qcom/gcc-sm8650.c > +++ b/drivers/clk/qcom/gcc-sm8650.c > @@ -3497,7 +3497,7 @@ static struct gdsc usb30_prim_gdsc = { > .pd = { > .name = "usb30_prim_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE, > }; > > @@ -3506,7 +3506,7 @@ static struct gdsc usb3_phy_gdsc = { > .pd = { > .name = "usb3_phy_gdsc", > }, > - .pwrsts = PWRSTS_OFF_ON, > + .pwrsts = PWRSTS_RET_ON, > .flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE, > }; > > Reviewed-by: Taniya Das > --- > base-commit: 7ec162622e66a4ff886f8f28712ea1b13069e1aa > change-id: 20250305-topic-sm8650-upstream-fix-usb-suspend-20979d5a0170 > > Best regards,