From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Wasim Nazir <quic_wasimn@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add initial support for rb5gen2 board
Date: Tue, 23 Apr 2024 15:20:44 +0200 [thread overview]
Message-ID: <db13541d-839c-4af8-97ca-b471e37188b2@linaro.org> (raw)
In-Reply-To: <20240313071238.3290-4-quic_wasimn@quicinc.com>
On 3/13/24 08:12, Wasim Nazir wrote:
> RB5gen2 is based on QCS8550-Rb5gen2 SOM for IOT solutions.
> This initial version describes VPH_PWR, UART & USB3.1(HS).
>
> On-board PMICs:
> - PMR735D
> - PM8010
>
> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>
Where's the "---"? :thinking:
[...]
> +&apps_rsc {
> + regulators-0 {
This does not scale. Use &label references instead
> + vdd-bob1-supply = <&vph_pwr>;
> + vdd-bob2-supply = <&vph_pwr>;
> + };
> +
> + regulators-2 {
> + vdd-s4-supply = <&vph_pwr>;
> + vdd-s5-supply = <&vph_pwr>;
> + };
> +
> + regulators-3 {
> + vdd-s1-supply = <&vph_pwr>;
> + vdd-s3-supply = <&vph_pwr>;
> + vdd-s4-supply = <&vph_pwr>;
> + vdd-s5-supply = <&vph_pwr>;
> + vdd-s6-supply = <&vph_pwr>;
> + };
> +
> + regulators-4 {
> + vdd-s1-supply = <&vph_pwr>;
> + vdd-s3-supply = <&vph_pwr>;
> + vdd-s4-supply = <&vph_pwr>;
> + vdd-s5-supply = <&vph_pwr>;
> + vdd-s7-supply = <&vph_pwr>;
> + };
> +
> + regulators-5 {
> + vdd-s1-supply = <&vph_pwr>;
> + vdd-s2-supply = <&vph_pwr>;
> + vdd-s3-supply = <&vph_pwr>;
> + vdd-s4-supply = <&vph_pwr>;
> + vdd-s5-supply = <&vph_pwr>;
> + vdd-s6-supply = <&vph_pwr>;
> + };
> +};
> +
> +&pm8550b_eusb2_repeater {
> + vdd18-supply = <&vreg_l15b_1p8>;
> + vdd3-supply = <&vreg_l5b_3p1>;
> +};
Would that not be SoM-common too?
Konrad
prev parent reply other threads:[~2024-04-23 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 7:12 [PATCH v3 0/3] arm64: qcom: add support for QCS8550 RB5gen2 board Wasim Nazir
2024-03-13 7:12 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Document rb5gen2 board Wasim Nazir
2024-03-13 7:19 ` Krzysztof Kozlowski
2024-03-14 7:01 ` Krzysztof Kozlowski
2024-03-14 4:15 ` Caleb Connolly
2024-03-14 7:01 ` Krzysztof Kozlowski
2024-03-13 7:12 ` [PATCH v3 2/3] arm64: dts: qcom: Add initial support for rb5gen2 SOM Wasim Nazir
2024-03-13 18:32 ` Konrad Dybcio
2024-03-13 7:12 ` [PATCH v3 3/3] arm64: dts: qcom: Add initial support for rb5gen2 board Wasim Nazir
2024-04-23 13:20 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db13541d-839c-4af8-97ca-b471e37188b2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wasimn@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox