Re: [PATCH v7 1/5] media: dt-bindings: Add qcom,sc7280-camss

[Vikram Sharma <quic_vikramsa@quicinc.com>]

On 12/5/2024 5:26 PM, Bryan O'Donoghue wrote:
> On 05/12/2024 10:59, Vikram Sharma wrote:
>> Hi Krzysztof,
>>
>> Thanks for your "Reviewed-by"
>>
>> +        camss@acb3000 {
>>
>> If there is going to be resend, then node name: isp
>>
>> Sure, we will change node-name from camss to isp or camera (As its a 
>> part of generic names recommendation as per the shared link.)
>> If there is a resend. or we will address this as a followup.
>>
>> So
>>
>> - camss@acb3000 {
>> + camera@acb3000 {
>>
>> Best Regards,
>> Vikram
>
> Please no top-posting.
> https://subspace.kernel.org/etiquette.html
>
> Shouldn't that be isp@0xaddress ?

ACK.

- camss@acb3000 {
+ isp@acb3000 {

In both YAML and DTS. If we post V8.

>
> If you are making this change, please remember to do it in both the 
> example and the dts.
Understood. Will avoid this.
>
> ---
> bod


Best Regards,
Vikram