From: Konrad Dybcio <konradybcio@gmail.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com
Subject: Re: [PATCH v3 1/2] arm64: dts: qcom: Add support for usb nodes on QCS8300
Date: Tue, 12 Nov 2024 12:04:04 +0100 [thread overview]
Message-ID: <dbd8ae86-03a5-4b33-b774-846788bf8b89@gmail.com> (raw)
In-Reply-To: <20241105164946.2357821-2-quic_kriskura@quicinc.com>
On 11/5/24 17:49, Krishna Kurapati wrote:
> Add support for USB controllers on QCS8300. The second
> controller is only High Speed capable.
>
> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> ---
[...]
(the PHYs look good)
> + usb_1: usb@a6f8800 {
> + compatible = "qcom,qcs8300-dwc3", "qcom,dwc3";
> + reg = <0x0 0x0a6f8800 0x0 0x400>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
Please match the property style with x1e80100.dtsi's dwc3 node
[...]
> +
> + usb_2_dwc3: usb@a400000 {
> + compatible = "snps,dwc3";
> + reg = <0x0 0x0a400000 0x0 0xe000>;
> + interrupts = <GIC_SPI 442 IRQ_TYPE_LEVEL_HIGH>;
> + iommus = <&apps_smmu 0x20 0x0>;
> + phys = <&usb_2_hsphy>;
> + phy-names = "usb2-phy";
> + snps,dis-u1-entry-quirk;
> + snps,dis-u2-entry-quirk;
> + snps,dis_u2_susphy_quirk;
> + snps,dis_u3_susphy_quirk;
> + snps,dis_enblslpm_quirk;
maximum-speed = "high-speed"
Konrad
next prev parent reply other threads:[~2024-11-12 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 16:49 [PATCH v3 0/2] Add Devicetree support for USB controllers on QCS8300 Krishna Kurapati
2024-11-05 16:49 ` [PATCH v3 1/2] arm64: dts: qcom: Add support for usb nodes " Krishna Kurapati
2024-11-12 11:04 ` Konrad Dybcio [this message]
2024-11-12 15:47 ` Krishna Kurapati
2024-11-15 16:18 ` Dmitry Baryshkov
2024-11-05 16:49 ` [PATCH v3 2/2] arm64: dts: qcom: Enable USB controllers for QCS8300 Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd8ae86-03a5-4b33-b774-846788bf8b89@gmail.com \
--to=konradybcio@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox