From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88A401B3725 for ; Mon, 4 Nov 2024 11:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730719535; cv=none; b=rk+PCDR3GGAjpDl1OnuUj0Sq41s5bv+TmiWYTng63oFq4ADOxvCcsmVF45BRZur4oe3b0V7EJXgFqcLU7Y4/qU7Eii22rx8J6OcxDL9/Noutw3NWbD17L7GOSASxEkSThXVJGkvSwK7k3DncPwYnoefjrcYEfTfGs0WqKEv97kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730719535; c=relaxed/simple; bh=Tmgmz4GR+9cwFu9AC7t02k+vRU80gzDp6e6LvUYKI8M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pw5ogZTiyAZ88QhJTYRd7AyQBT8RPLHO07t5q4FGBO4EF69xvPBxr1iTXQxKZ+1jjmANxjnEUQ4rb94FKiEnj90lMTiRUj2bqquilyYTeuvFHhWogSX9+UtVfEvWRUMHvUU5iUCwsB5qYhO09e5zN5a/DoFIRADtSpBmZRFxH1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j1OZnMeQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j1OZnMeQ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A3M1F5o023069 for ; Mon, 4 Nov 2024 11:25:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jcdE780GkitDhih7tdyFso9EhnKjR+Hdo4ZyfDFdfjw=; b=j1OZnMeQuD4xnZIK NbRxY0NeqWiPKOnXwUEQKj9RDggmuIfn6DqZnAC3tEyl5JRhCB9NEDcUZIphQKJn nJOmFsSDcb6993y8AYE7Q6uX/Kv+sl8ogBP0hasfggmf0DKHMbynYRTJnG3e4Tib 3JolegVu9l7Q7itMCD6HwbDMuUDssuAgC/28JszQm7ctD1pqHzvJ09tQAyDwx4p4 SXXxVNL+281LYDAU/Yj0uppbXrLzyEQORiNqQw0GTcKXEtQAKmH7sO6zLUfcdrfz IyOGLJbamnX6G/3hD1DMC/v1v9IpcIKXDV8LjxBFkw6av0bJuey8e304+1OwYISW YoWArA== Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42ndc6uwrj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 04 Nov 2024 11:25:32 +0000 (GMT) Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3e5f4fe6ee9so397971b6e.1 for ; Mon, 04 Nov 2024 03:25:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730719531; x=1731324331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jcdE780GkitDhih7tdyFso9EhnKjR+Hdo4ZyfDFdfjw=; b=kNklbqDXyD9Q134x2XXTAMjU3bepaKP58QCpK7ZadCaaeN49i7xZTOZvgMi6Kko30j h3QetI2pDNHqTgeH0tx1pYfmXLJnkLzApxuheqch8NQkXlvH5DcEkdx7/LtHyn2mjlA6 bBKsoGJgWSsLFP9LokbuudJbt7Gp6vAO3fKwJTqpV9m4Evh/HbwhUxNNeeysB/MOTDi1 YD5plmVHiQvvJnWvOwkFxyZTuKhq/WhbdR+LxIHB1O5Wvdpp0uz4RCtKFqkvLMiCu0Pm pPHlcP6eb7CRmytNmAac2h99gZAY7RWHiqM5Hot+qY1RJ9nW9Srglm7v4pzUxHcY1Mkn MEhA== X-Forwarded-Encrypted: i=1; AJvYcCVDsoNT6rEC2w31OdS1eZ1d3qbhKqjEZjQcJjKfiBnWtsCsMApxjchYHIZPib4ZF7exp3q5YFXYtiECQmw6@vger.kernel.org X-Gm-Message-State: AOJu0YyJq/SAgiGGG6urCh435tFPmJmCWDhHRpeg6+VpZ2CTektJNnB+ v2CrntLOiKIyNmDcZlbBy5DzOKG5wOweqJb/YzJjFIxdTmpAfmsg5lNlAFsxjCLQPumGLqV7I6H Ivigc0pKbBsiKFX/j010ieHjIiJdGbd9nXH79ZJktOJWOhOP/gfG4AHC0UI2ub80e X-Received: by 2002:a54:4583:0:b0:3e5:fa82:9188 with SMTP id 5614622812f47-3e6384c4e83mr6722865b6e.9.1730719531613; Mon, 04 Nov 2024 03:25:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPMHgbkvO9CmVr31mXjUPHasBRdXrgCQTzj8H7KuUj0yd1zFTHMB4QY9AUiy468jryHZwSgg== X-Received: by 2002:a54:4583:0:b0:3e5:fa82:9188 with SMTP id 5614622812f47-3e6384c4e83mr6722859b6e.9.1730719531272; Mon, 04 Nov 2024 03:25:31 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9e56493edbsm539687766b.38.2024.11.04.03.25.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2024 03:25:30 -0800 (PST) Message-ID: Date: Mon, 4 Nov 2024 12:25:27 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 3/3] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows To: Sibi Sankar , andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org, dmitry.baryshkov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, abel.vesa@linaro.org, srinivas.kandagatla@linaro.org, quic_jjohnson@quicinc.com, maz@kernel.org, jens.glathe@oldschoolsolutions.biz References: <20241025123227.3527720-1-quic_sibis@quicinc.com> <20241025123227.3527720-4-quic_sibis@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241025123227.3527720-4-quic_sibis@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ZH2F2TFacdat2Nhjv4XOW-b4JKhyzQfn X-Proofpoint-GUID: ZH2F2TFacdat2Nhjv4XOW-b4JKhyzQfn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=991 adultscore=0 clxscore=1015 mlxscore=0 phishscore=0 impostorscore=0 suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411040100 On 25.10.2024 2:32 PM, Sibi Sankar wrote: > Add initial support for x1e001de devkit platform. This includes: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > Link: https://www.qualcomm.com/news/releases/2024/05/qualcomm-accelerates-development-for-copilot--pcs-with-snapdrago > Signed-off-by: Sibi Sankar > --- [...] > + vreg_nvme: regulator-nvme { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_NVME_3P3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 18 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&nvme_reg_en>; these are backwards otherwise lgtm Reviewed-by: Konrad Dybcio Konrad