From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7055BC61DA2 for ; Thu, 26 Jan 2023 09:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236312AbjAZJlc (ORCPT ); Thu, 26 Jan 2023 04:41:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236281AbjAZJlb (ORCPT ); Thu, 26 Jan 2023 04:41:31 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02D8D5D10C for ; Thu, 26 Jan 2023 01:41:28 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id l8so721019wms.3 for ; Thu, 26 Jan 2023 01:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gWbckZbLscUSiQK6kSvhvYmXnDbgSSyOehKbYKBrl+8=; b=bQUVcZ6Rt7OTd6EQSbi8KR7R+YlACETTdb8AerLmjoGgGdRJyrkFQKUSawGn698Wp/ 8COeb+kXxWr0ert8SlZoOetmJtVtS9s97CEFZiW46wqD1XD7Bgeb6HbEt488SuVczmK0 TRlm2/p4EmqWIc5WWXwG/STtBjpdf9JniVJbIaZ9ayXTTlkEaB3eOge9rI/EoBgqxR7f iOzVaqa6K0rpg5kXbPFcj7HiVGaPqgUaYAXbhP2aWqxAlfzYtKWXxna5VnQAnOyEcn9A XQMalvQBICYrskkqIpmALsrocd790cwDPAhueTwwgZsO/ykTtfRBKYvOb/Bz9gXW2R+d cQnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gWbckZbLscUSiQK6kSvhvYmXnDbgSSyOehKbYKBrl+8=; b=zInfuOHfd5z4iwtkySjjywfMU+KA95HzaO/zqdowNdI49mm1cYrIo8P6UVfG64agCA yGVW/O1ScO1SECCHuZ4G00x7T5O2lqqtRQG7KnwQfG0Wy6YG2fvLu5s9PflXbGzWXTlp zz7Z7NQ/Rt+FsfbWf8bCyfVlIvXFF+c47kWsXotwneOW386ORB1JX8P2fEsirjxAl3Rp XtVFU9VQp0ZA+Ud+cQquQgVViBAcwl+lxtXJa88b4jyQkJHW7MW44HTv3dH53ODT48Jx 89CuAWZF7mPn77VAmxhcYvruEef9um8o1hggyiSglCaqSXpiSIa4BY2HlGi7chl8eQqQ /hhw== X-Gm-Message-State: AFqh2krSBlKnbt65lBeWgqdq+krtC//+LVecTei7kTHa0+NpulgkM4+t shrClcZWlb698wwf+6Bqjz47Zw== X-Google-Smtp-Source: AMrXdXvSx2my3NGGu6iqTh8FJBDjJRGEoIXP9s1KJSvSez8DU8+sI6sZ3tPjsNy2pNFH1/hC0DXKtQ== X-Received: by 2002:a05:600c:4e08:b0:3db:1a41:663a with SMTP id b8-20020a05600c4e0800b003db1a41663amr29235114wmq.20.1674726086529; Thu, 26 Jan 2023 01:41:26 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id i20-20020a05600c071400b003db0ad636d1sm4018509wmn.28.2023.01.26.01.41.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 01:41:26 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 10:41:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 5/5] ARM: dts: qcom: msm8974-oneplus-bacon: Add notification LED Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230122-msm8974-bacon-features-v1-0-4049f565c24c@z3ntu.xyz> <20230122-msm8974-bacon-features-v1-5-4049f565c24c@z3ntu.xyz> <02e5bf79-3e2d-02c8-67e7-61bbff32ba29@linaro.org> <4455893.LvFx2qVVIh@g550jk> From: Krzysztof Kozlowski In-Reply-To: <4455893.LvFx2qVVIh@g550jk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25/01/2023 21:51, Luca Weiss wrote: > On Montag, 23. Jänner 2023 18:18:16 CET Krzysztof Kozlowski wrote: >> On 22/01/2023 17:48, Luca Weiss wrote: >>> Add the node describing the sn3193 that's used to provide notification >>> LED. >>> >>> Unfortunately the driver currently supports neither multicolor API nor >>> using the properties function & color, so we use label instead. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> >>> .../arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 28 >>> ++++++++++++++++++++++ 1 file changed, 28 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts >>> b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts index >>> ffb486ceb6a6..a672c45d7070 100644 >>> --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts >>> +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts >>> @@ -114,6 +114,34 @@ led@0 { >>> >>> default-brightness = <80>; >>> >>> }; >>> >>> }; >>> >>> + >>> + led-controller@68 { >>> + compatible = "si-en,sn3193"; >>> + reg = <0x68>; >>> + >>> + shutdown-gpios = <&tlmm 45 GPIO_ACTIVE_HIGH>; >>> + >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + led@1 { >>> + reg = <1>; >>> + label = "red:status"; >> >> These should be colors and functions. > > Hi Krzysztof, > > please check the commit message for this. I tried using it but it didn't work, > the driver in general might need an overhaul at some point... > >> Unfortunately the driver currently supports neither multicolor API nor >> using the properties function & color, so we use label instead. > > Or maybe I messed up but pretty sure this was the case when I wrote the dts. I don't understand how driver is related here - it's not the driver's property, but LED core. If the driver "supports" label, then it supports color and status. Best regards, Krzysztof