Re: [PATCH 31/53] drm/msm: Convert to platform remove callback returning void

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On 07/05/2023 19:25, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert the msm drm drivers from always returning zero in the
> remove callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>   drivers/gpu/drm/msm/adreno/adreno_device.c | 5 ++---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c    | 6 ++----
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c   | 6 ++----
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c   | 5 ++---
>   drivers/gpu/drm/msm/dp/dp_display.c        | 6 ++----
>   drivers/gpu/drm/msm/dsi/dsi.c              | 6 ++----
>   drivers/gpu/drm/msm/hdmi/hdmi.c            | 6 ++----
>   drivers/gpu/drm/msm/hdmi/hdmi_phy.c        | 6 ++----
>   drivers/gpu/drm/msm/msm_drv.c              | 6 ++----
>   drivers/gpu/drm/msm/msm_mdss.c             | 6 ++----
>   10 files changed, 20 insertions(+), 38 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry