From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH 2/7] drm/msm: dpu: Move atomic_check_plane_state() call to atomic_check Date: Tue, 11 Sep 2018 15:44:48 -0700 Message-ID: References: <20180911201550.210810-1-sean@poorly.run> <20180911201550.210810-2-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180911201550.210810-2-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Rob Clark , Sean Paul , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0wOS0xMSAxMzoxNSwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IFNlYW4gUGF1bCA8 c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IHNyYy9kc3QgcmVjdHMgYXJlIGNoZWNrZWQgaW4g Ym90aCBhdG9taWNfY2hlY2sgYW5kIGF0b21pY191cGRhdGUsIHdpdGgKPiB0aGUgbW9yZSBjb21w cmVoZW5zaXZlIGNoZWNrIG9jY3VycmluZyBpbiBhdG9taWNfdXBkYXRlLCB3aGljaCBpcwo+IGJh Y2t3YXJkcy4gU28gY29uc29sb2RhdGUgdGhlIGNoZWNrcyBpbiBhdG9taWNfY2hlY2suCj4gCj4g U2lnbmVkLW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jIHwgNTYgKysrKysrKy0t LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDQwIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1 MS9kcHVfcGxhbmUuYwo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5l LmMKPiBpbmRleCAwZjQyOGY2NmI5NTEuLjg1MzkwMmFjNGZiOSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gQEAgLTEwNzksMTMgKzEwNzksMjYgQEAg c3RhdGljIGJvb2wgZHB1X3BsYW5lX3ZhbGlkYXRlX3NyYyhzdHJ1Y3QgCj4gZHJtX3JlY3QKPiAq c3JjLAo+ICBzdGF0aWMgaW50IGRwdV9wbGFuZV9zc3BwX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiAgCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiAgewo+ IC0JaW50IHJldCA9IDA7Cj4gKwlpbnQgcmV0ID0gMCwgbWluX3NjYWxlOwo+ICAJc3RydWN0IGRw dV9wbGFuZSAqcGRwdSA9IHRvX2RwdV9wbGFuZShwbGFuZSk7Cj4gKwljb25zdCBzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPSBOVUxMOwo+ICAJY29uc3Qgc3RydWN0IGRwdV9mb3Jt YXQgKmZtdDsKPiAgCXN0cnVjdCBkcm1fcmVjdCBzcmMsIGRzdCwgZmJfcmVjdCA9IHsgMCB9Owo+ IC0JdWludDMyX3QgbWF4X3Vwc2NhbGUgPSAxLCBtYXhfZG93bnNjYWxlID0gMTsKPiAgCXVpbnQz Ml90IG1pbl9zcmNfc2l6ZSwgbWF4X2xpbmV3aWR0aDsKPiAtCWludCBoc2NhbGUgPSAxLCB2c2Nh bGUgPSAxOwo+ICsKPiArCWlmIChzdGF0ZS0+Y3J0YykKPiArCQljcnRjX3N0YXRlID0gc3RhdGUt PmNydGMtPnN0YXRlOwpJc24ndCB0aGUgY3J0Y19zdGF0ZSByZXRyaWV2ZWQgaGVyZSB0aGUgb2xk IGNydGMgc3RhdGU/IFNpbmNlIHRoZSBwbGFuZSAKY2hlY2sgaXMgY2FsbGVkIGJlZm9yZSBzd2Fw LCB0aGUgQ1JUQyBzdGF0ZQpmb3IgdGhpcyBjb21taXQgc2hvdWxkIGJlIHJldHJpZXZlZCBmcm9t IGdsb2JhbCBhdG9taWMgc3RhdGUgCnN0YXRlLT5zdGF0ZSB1c2luZyBkcm1fYXRvbWljX2dldF9l eGlzdGluZ19jcnRjX3N0YXRlLgoKSmV5a3VtYXIgUy4KPiArCj4gKwltaW5fc2NhbGUgPSBGUkFD XzE2XzE2KDEsIHBkcHUtPnBpcGVfc2Jsay0+bWF4ZHduc2NhbGUpOwo+ICsJcmV0ID0gZHJtX2F0 b21pY19oZWxwZXJfY2hlY2tfcGxhbmVfc3RhdGUoc3RhdGUsIGNydGNfc3RhdGUsCj4gbWluX3Nj YWxlLAo+ICsJCQkJCSAgcGRwdS0+cGlwZV9zYmxrLT5tYXh1cHNjYWxlIDw8Cj4gMTYsCj4gKwkJ CQkJICB0cnVlLCB0cnVlKTsKPiArCWlmIChyZXQpIHsKPiArCQlEUFVfRVJST1JfUExBTkUocGRw dSwgIkNoZWNrIHBsYW5lIHN0YXRlIGZhaWxlZCAoJWQpXG4iLAo+IHJldCk7Cj4gKwkJcmV0dXJu IHJldDsKPiArCX0KPiArCWlmICghc3RhdGUtPnZpc2libGUpCj4gKwkJcmV0dXJuIDA7Cj4gCj4g IAlzcmMueDEgPSBzdGF0ZS0+c3JjX3ggPj4gMTY7Cj4gIAlzcmMueTEgPSBzdGF0ZS0+c3JjX3kg Pj4gMTY7Cj4gQEAgLTEwOTksMjUgKzExMTIsNiBAQCBzdGF0aWMgaW50IGRwdV9wbGFuZV9zc3Bw X2F0b21pY19jaGVjayhzdHJ1Y3QKPiBkcm1fcGxhbmUgKnBsYW5lLAo+IAo+ICAJbWF4X2xpbmV3 aWR0aCA9IHBkcHUtPnBpcGVfc2Jsay0+Y29tbW9uLT5tYXhsaW5ld2lkdGg7Cj4gCj4gLQlpZiAo cGRwdS0+ZmVhdHVyZXMgJiBEUFVfU1NQUF9TQ0FMRVIpIHsKPiAtCQltYXhfZG93bnNjYWxlID0g cGRwdS0+cGlwZV9zYmxrLT5tYXhkd25zY2FsZTsKPiAtCQltYXhfdXBzY2FsZSA9IHBkcHUtPnBp cGVfc2Jsay0+bWF4dXBzY2FsZTsKPiAtCX0KPiAtCWlmIChkcm1fcmVjdF93aWR0aCgmc3JjKSA8 IGRybV9yZWN0X3dpZHRoKCZkc3QpKQo+IC0JCWhzY2FsZSA9IGRybV9yZWN0X2NhbGNfaHNjYWxl KCZzcmMsICZkc3QsIDEsIG1heF91cHNjYWxlKTsKPiAtCWVsc2UKPiAtCQloc2NhbGUgPSBkcm1f cmVjdF9jYWxjX2hzY2FsZSgmZHN0LCAmc3JjLCAxLAo+IG1heF9kb3duc2NhbGUpOwo+IC0JaWYg KGRybV9yZWN0X2hlaWdodCgmc3JjKSA8IGRybV9yZWN0X2hlaWdodCgmZHN0KSkKPiAtCQl2c2Nh bGUgPSBkcm1fcmVjdF9jYWxjX3ZzY2FsZSgmc3JjLCAmZHN0LCAxLCBtYXhfdXBzY2FsZSk7Cj4g LQllbHNlCj4gLQkJdnNjYWxlID0gZHJtX3JlY3RfY2FsY192c2NhbGUoJmRzdCwgJnNyYywgMSwK PiBtYXhfZG93bnNjYWxlKTsKPiAtCj4gLQlEUFVfREVCVUdfUExBTkUocGRwdSwgImNoZWNrICVk IC0+ICVkXG4iLAo+IC0JCWRwdV9wbGFuZV9lbmFibGVkKHBsYW5lLT5zdGF0ZSksCj4gZHB1X3Bs YW5lX2VuYWJsZWQoc3RhdGUpKTsKPiAtCj4gLQlpZiAoIWRwdV9wbGFuZV9lbmFibGVkKHN0YXRl KSkKPiAtCQlnb3RvIGV4aXQ7Cj4gLQo+ICAJZm10ID0gdG9fZHB1X2Zvcm1hdChtc21fZnJhbWVi dWZmZXJfZm9ybWF0KHN0YXRlLT5mYikpOwo+IAo+ICAJbWluX3NyY19zaXplID0gRFBVX0ZPUk1B VF9JU19ZVVYoZm10KSA/IDIgOiAxOwo+IEBAIC0xMTU2LDE2ICsxMTUwLDggQEAgc3RhdGljIGlu dCBkcHVfcGxhbmVfc3NwcF9hdG9taWNfY2hlY2soc3RydWN0Cj4gZHJtX3BsYW5lICpwbGFuZSwK PiAgCQlEUFVfRVJST1JfUExBTkUocGRwdSwgImludmFsaWQgc3JjICIgRFJNX1JFQ1RfRk1UICIK PiBsaW5lOiV1XG4iLAo+ICAJCQkJRFJNX1JFQ1RfQVJHKCZzcmMpLCBtYXhfbGluZXdpZHRoKTsK PiAgCQlyZXQgPSAtRTJCSUc7Cj4gLQo+IC0JLyogY2hlY2sgc2NhbGVyIGNhcGFiaWxpdHkgKi8K PiAtCX0gZWxzZSBpZiAoaHNjYWxlIDwgMCB8fCB2c2NhbGUgPCAwKSB7Cj4gLQkJRFBVX0VSUk9S X1BMQU5FKHBkcHUsICJpbnZhbGlkIHNjYWxpbmcgcmVxdWVzdGVkIHNyYz0iCj4gLQkJCQlEUk1f UkVDVF9GTVQgIiBkc3Q9IiBEUk1fUkVDVF9GTVQgIlxuIiwKPiAtCQkJCURSTV9SRUNUX0FSRygm c3JjKSwgRFJNX1JFQ1RfQVJHKCZkc3QpKTsKPiAtCQlyZXQgPSAtRTJCSUc7Cj4gIAl9Cj4gCj4g LWV4aXQ6Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gCj4gQEAgLTEyMzcsNyArMTIyMyw2IEBAIHN0 YXRpYyBpbnQgZHB1X3BsYW5lX3NzcHBfYXRvbWljX3VwZGF0ZShzdHJ1Y3QKPiBkcm1fcGxhbmUg KnBsYW5lLAo+ICAJY29uc3Qgc3RydWN0IGRwdV9mb3JtYXQgKmZtdDsKPiAgCXN0cnVjdCBkcm1f Y3J0YyAqY3J0YzsKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+IC0JaW50IHJldCwg bWluX3NjYWxlOwo+IAo+ICAJaWYgKCFwbGFuZSkgewo+ICAJCURQVV9FUlJPUigiaW52YWxpZCBw bGFuZVxuIik7Cj4gQEAgLTEyNzYsMTUgKzEyNjEsNiBAQCBzdGF0aWMgaW50IGRwdV9wbGFuZV9z c3BwX2F0b21pY191cGRhdGUoc3RydWN0Cj4gZHJtX3BsYW5lICpwbGFuZSwKPiAgCXBkcHUtPmlz X3J0X3BpcGUgPSAoZHB1X2NydGNfZ2V0X2NsaWVudF90eXBlKGNydGMpICE9IE5SVF9DTElFTlQp Owo+ICAJX2RwdV9wbGFuZV9zZXRfcW9zX2N0cmwocGxhbmUsIGZhbHNlLCBEUFVfUExBTkVfUU9T X1BBTklDX0NUUkwpOwo+IAo+IC0JbWluX3NjYWxlID0gRlJBQ18xNl8xNigxLCBwZHB1LT5waXBl X3NibGstPm1heGR3bnNjYWxlKTsKPiAtCXJldCA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3Bs YW5lX3N0YXRlKHN0YXRlLCBjcnRjLT5zdGF0ZSwKPiBtaW5fc2NhbGUsCj4gLQkJCQkJICBwZHB1 LT5waXBlX3NibGstPm1heHVwc2NhbGUgPDwKPiAxNiwKPiAtCQkJCQkgIHRydWUsIGZhbHNlKTsK PiAtCWlmIChyZXQpIHsKPiAtCQlEUFVfRVJST1JfUExBTkUocGRwdSwgIkNoZWNrIHBsYW5lIHN0 YXRlIGZhaWxlZCAoJWQpXG4iLAo+IHJldCk7Cj4gLQkJcmV0dXJuIHJldDsKPiAtCX0KPiAtCj4g IAlEUFVfREVCVUdfUExBTkUocGRwdSwgIkZCWyV1XSAiIERSTV9SRUNUX0ZQX0ZNVCAiLT5jcnRj JXUgIgo+IERSTV9SRUNUX0ZNVAo+ICAJCQkiLCAlNC40cyB1YndjICVkXG4iLCBmYi0+YmFzZS5p ZCwKPiBEUk1fUkVDVF9GUF9BUkcoJnN0YXRlLT5zcmMpLAo+ICAJCQljcnRjLT5iYXNlLmlkLCBE Uk1fUkVDVF9BUkcoJnN0YXRlLT5kc3QpLAoKLS0gCkpleWt1bWFyIFMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApG cmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5vCg==