From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Stephan Gerhold <stephan.gerhold@linaro.org>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Abel Vesa <abel.vesa@oss.qualcomm.com>
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: x1e80100: Add CAMCC block definition
Date: Thu, 5 Mar 2026 13:00:38 +0100 [thread overview]
Message-ID: <dd256b85-b88f-4163-a1e0-52c976089eae@kernel.org> (raw)
In-Reply-To: <3f69539c-7383-4321-8cc6-1f5a8cc23822@kernel.org>
On 05/03/2026 12:58, Krzysztof Kozlowski wrote:
> On 04/03/2026 18:40, Jagadeesh Kona wrote:
>> From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>
>> Add the CAMCC block for x1e80100. The x1e80100 CAMCC block is an iteration
>> of previous CAMCC blocks with the exception of having two required
>> power-domains not just one. And update the compatible for camcc and
>> videocc nodes on Purwa to match with their respective Purwa (X1P42100)
>> specific drivers.
>>
>> Fixes: a8a5ea012471 ("arm64: dts: qcom: x1e80100: Add videocc")
>
> How is this a fix? Describe the user-observable bug in such case.
>
>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
>
> Three people reviewed this...
>
Actually I checked now - all the people reviewed commit without fixes
tag and you just added.
OK, this starts looking bad because it is more of such patterns from
Qualcomm these two weeks.
Stop funneling features into LTS kernels.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-05 12:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 17:40 [PATCH v2 0/7] Add support for videocc and camcc on X1P42100 platform Jagadeesh Kona
2026-03-04 17:40 ` [PATCH v2 1/7] dt-bindings: clock: qcom: Add X1P42100 video clock controller Jagadeesh Kona
2026-03-05 7:47 ` Krzysztof Kozlowski
2026-03-06 14:54 ` Jagadeesh Kona
2026-03-04 17:40 ` [PATCH v2 2/7] dt-bindings: clock: qcom: Add X1P42100 camera " Jagadeesh Kona
2026-03-05 7:49 ` Krzysztof Kozlowski
2026-03-04 17:40 ` [PATCH v2 3/7] clk: qcom: videocc-x1p42100: Add support for video " Jagadeesh Kona
2026-03-05 0:20 ` Dmitry Baryshkov
2026-03-06 14:56 ` Jagadeesh Kona
2026-03-05 11:57 ` Konrad Dybcio
2026-03-04 17:40 ` [PATCH v2 4/7] clk: qcom: camcc-x1e80100: Add support for camera QDSS debug clocks Jagadeesh Kona
2026-03-05 7:53 ` Krzysztof Kozlowski
2026-03-06 14:59 ` Jagadeesh Kona
2026-03-05 11:58 ` Krzysztof Kozlowski
2026-03-06 14:59 ` Jagadeesh Kona
2026-03-04 17:40 ` [PATCH v2 5/7] clk: qcom: camcc-x1p42100: Add support for camera clock controller Jagadeesh Kona
2026-03-05 0:33 ` Dmitry Baryshkov
2026-03-05 2:18 ` Bryan O'Donoghue
2026-03-05 9:05 ` Konrad Dybcio
2026-03-06 14:57 ` Jagadeesh Kona
2026-03-04 17:40 ` [PATCH v2 6/7] arm64: dts: qcom: x1e80100: Add CAMCC block definition Jagadeesh Kona
2026-03-05 11:58 ` Krzysztof Kozlowski
2026-03-05 12:00 ` Krzysztof Kozlowski [this message]
2026-03-05 13:11 ` Bryan O'Donoghue
2026-03-06 14:58 ` Jagadeesh Kona
2026-03-06 14:58 ` Jagadeesh Kona
2026-03-06 15:23 ` Krzysztof Kozlowski
2026-03-04 17:40 ` [PATCH v2 7/7] arm64: defconfig: Enable VIDEOCC and CAMCC drivers on Qualcomm X1P42100 Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd256b85-b88f-4163-a1e0-52c976089eae@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan.gerhold@linaro.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox