From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21D792868B2; Thu, 5 Feb 2026 11:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770290239; cv=none; b=cKqYaI4/gh7+PYFIcDpKtHHHaWONDnD/xZWmv00gLdIoB2X8CMmMNVK5TyLQXNgfyr/5PzpK7OMw+/4D+irpxqs6Mhod40WKJJlIvHoJml0mcVgzq1WlEdb/Ve3snUu4KJCXKNLdg5wtAVLjNoEhCM4FM74BWdtcToIjCkXTQAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770290239; c=relaxed/simple; bh=I79pa1OT5eiWn8myWVqo3sKahUTRfM9JLtSq0m8sFUY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cUkw9T4MsHxAtCUK144C4AItH45gp4n82Kt4GfPGE+by/h0AOR+h4QV9IWKkE0B3yeJUM5znfSoFK9j4uu5A8Q6hCUdliIdcr+ocPyO0KtJyACDIzZFKfL3PwadgYVQXf5vKHvcCKyhm4pnJ7ZqCyB8e3ZbcAHoC8sZK/sXJHTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JB62V5um; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JB62V5um" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18355C16AAE; Thu, 5 Feb 2026 11:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770290238; bh=I79pa1OT5eiWn8myWVqo3sKahUTRfM9JLtSq0m8sFUY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JB62V5umlqDoRc59fDsLPismtZbahD2I1ssmVXEGo43N4yamtEAiWxOTxv3yD2j4u vc73Sk8eoYTiBa6t7Btu+T4/VAHSs72GTxME/u98jBVImF1KZBjHqBJtLhhbP5QMiV bC+yeQcwZUiOhQ+aSCczeckoa7A8nWuPpfBnwOoA8ASMNMoizc6RmwMZPkU13g6IWZ hqwQiAzKH+jStL4dFAkR/kuC1olBWDx+qfKXBc/cs0jKBpMAitckzq0H7t87TCCI16 edwx3QeeA+LXs2cPQaii5Zy/vf8cz9a1nA9+BZC0WxvpmCjwm4GVf82e5swaOOkvEm X4ar7OqAbm+Eg== Message-ID: Date: Thu, 5 Feb 2026 12:17:13 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk To: Harshal Dev , Konrad Dybcio , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , cros-qcom-dts-watchers@chromium.org Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> <20260123-qcom_ice_power_and_clk_vote-v1-1-e9059776f85c@qti.qualcomm.com> <14a71b33-4c10-41b0-a6cb-585a38e05f56@kernel.org> <06160c6c-a945-467a-be82-7b33c5285d0f@oss.qualcomm.com> <7216c86d-2b87-496c-9548-ccdcb3c98b6b@oss.qualcomm.com> <1f99db18-d76c-4b87-9e30-423eee7037e1@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1f99db18-d76c-4b87-9e30-423eee7037e1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/02/2026 10:26, Harshal Dev wrote: > Hi Krzysztof and Konrad, > > On 1/26/2026 3:59 PM, Konrad Dybcio wrote: >> On 1/23/26 12:04 PM, Harshal Dev wrote: >>> Hi Krzysztof, >>> >>> On 1/23/2026 2:27 PM, Krzysztof Kozlowski wrote: >>>> On 23/01/2026 08:11, Harshal Dev wrote: >>>>> Update the inline-crypto engine DT binding to reflect that power-domain and >>>>> clock-names are now mandatory. Also update the maximum number of clocks >>>>> that can be specified to two. These new fields are mandatory because ICE >>>>> needs to vote on the power domain before it attempts to vote on the core >>>>> and iface clocks to avoid clock 'stuck' issues. >>>>> >>>>> Signed-off-by: Harshal Dev >>>>> --- >>>>> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 14 +++++++++++++- >>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>> index c3408dcf5d20..1c2416117d4c 100644 >>>>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>>> @@ -28,12 +28,20 @@ properties: >>>>> maxItems: 1 >>>>> >>>>> clocks: >>>>> + maxItems: 2 >>>> >>>> This is ABI break and your commit msg suggests things were not perfect, >>>> but it is not explicit - was this working or not? How is it that ICE was >>>> never tested? >>>> >>> >>> I took some time to educate myself on the point of DT bindings stability being a >>> strict requirement now, so I understand how these changes are breaking ABI, I'll >>> send a better version of this again. >>> >>> As for your question of how it was working till now, it seems that >>> things were tested with the 'clk_ignore_unused' flag, or with CONFIG_SCSI_UFS_QCOM >>> flag being override set to 'y'. When this is done, QCOM-ICE (on which QCOM-UFS >>> depends) initiates probe _before_ the unused clocks and power-domains are >>> disabled by the kernel. And so, the un-clocked register access or clock 'stuck' >>> isn't observed (since the clocks and power domains are already enabled). >>> Perhaps I should write this scenario explicitly in the commit message? >>> >>> To maintain backward compatibility, let me introduce minItems and maxItems for clocks. >>> When the Linux distro uses CONFIG_SCSI_UFS_QCOM=y, we can do with just 1 clock as >>> before. >> >> You must not assume any particular kernel configuration >> >> clk_ignore_unused is a hack which leads to situations like this, since >> the bootloader doesn't clean up clocks it turned on, which leads to >> situations like this where someone who previously wrote this binding >> didn't care enough to **actually** test whether this device can operate >> with only the set of clocks it requires >> >> I believe in this case it absolutely makes sense to break things, but >> you must put the backstory in writing, in the commit message >> > > I took some more time to think this through, and I agree with you now Konrad. > > These DT bindings appear to be invalid from day-1. ICE being an independent > and common IP for both UFS and SDCC, it cannot operate correctly without its > power-domain and clocks being enabled first. Hence, it should be mandatory for > them to be specified in the DT-node and the same should be reflected in the DT > binding. > > The only reason I can think of for omitting the 'power-domain' and 'iface' clock > in the original DT-binding for ICE is because we failed to test the driver on > a production kernel where the 'clk_ignore_unused' flag is not passed on the cmdline. That's a reason to change ABI in the bindings, but not a reason to break in-kernel or out of tree DTS. > Or if we did test that way, we were just lucky to not run into a timing scenario > where the probe for the driver is attempted _after_ the clocks are turned off by the > kernel. > > Sending a new patch, which makes these two resources optional (to preserve the DT > binding) would either imply that we are make this bug fix optional as well or > asking the reporter to resort to some workaround such as overriding > CONFIG_SCSI_UFS_QCOM to 'y'. Either I do not understand the point or you still insist on breaking a working DTS on kernels with clk_ignore_unused, just because what exactly? You claim it did not work, but in fact it did work. So you claim it worked by luck, right? And what this patchset achieves? It breaks this "work by luck" into "100% not working and broken". I do not see how is this an improvement. My NAK for driver change stays. This is wrong approach - you cannot break working DTS. Best regards, Krzysztof