From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Alexander Koskovich <akoskovich@pm.me>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: eliza: Add IMEM node
Date: Thu, 23 Apr 2026 11:42:49 +0200 [thread overview]
Message-ID: <dd570628-f93d-42c1-b240-391ae31a300a@kernel.org> (raw)
In-Reply-To: <098ad1e8-1ad3-458e-93dd-859457cc58c9@oss.qualcomm.com>
On 16/04/2026 12:19, Konrad Dybcio wrote:
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> +
>>> + pilreloc-sram@94c {
>>> + compatible = "qcom,pil-reloc-info";
>>> + reg = <0x94c 0xc8>;
>>> + };
>>> +
>>> + ipa_modem_tables: modem-tables-sram@3000 {
>>> + reg = <0x3000 0x2000>;
>>
>> I don't think these two should be in the main SoC DTSI. The non-modem
>> version obviously does not have modem-tables.
>
> That's not quite right, IMEM is partitioned to have it either way, even
> if it stays unused. You'll notice this slice is there even on platforms
> that were designed with no modem in any SKU
>
OK, seems fine to me.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-23 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:39 [PATCH v2 0/3] Describe IMEM on Eliza Alexander Koskovich
2026-04-16 9:39 ` [PATCH v2 1/3] arm64: dts: qcom: eliza: Sort nodes by unit address Alexander Koskovich
2026-04-16 10:04 ` Krzysztof Kozlowski
2026-04-17 8:19 ` Konrad Dybcio
2026-04-16 9:40 ` [PATCH v2 2/3] dt-bindings: sram: Document qcom,eliza-imem Alexander Koskovich
2026-04-16 10:21 ` Krzysztof Kozlowski
2026-04-16 9:40 ` [PATCH v2 3/3] arm64: dts: qcom: eliza: Add IMEM node Alexander Koskovich
2026-04-16 10:09 ` Krzysztof Kozlowski
2026-04-16 10:15 ` Alexander Koskovich
2026-04-16 10:19 ` Konrad Dybcio
2026-04-23 9:42 ` Krzysztof Kozlowski [this message]
2026-04-16 10:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd570628-f93d-42c1-b240-391ae31a300a@kernel.org \
--to=krzk@kernel.org \
--cc=akoskovich@pm.me \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox