From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
Date: Mon, 20 Apr 2026 10:27:56 +0200 [thread overview]
Message-ID: <dd5ee12e-1aac-494f-a8f8-74e236ecb47c@kernel.org> (raw)
In-Reply-To: <20260420073301.1250197-1-shengchao.guo@oss.qualcomm.com>
On 20/04/2026 09:33, Shawn Guo wrote:
> Add compatible for Inline Crypto Engine (ICE) on Qualcomm Nord SoC
> witha fallback on qcom,inline-crypto-engine.
Don't explain what the diff is doing. Explain why. Why do you use fallback?
What is Nord? It's nowhere explained. First posting was 1.5 months ago
and it did not provide any explanation. I don't see any information
being posted in the series sent now.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-20 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 7:33 [PATCH] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
2026-04-20 8:27 ` Krzysztof Kozlowski [this message]
2026-04-20 8:39 ` Shawn Guo
2026-04-20 11:56 ` Krzysztof Kozlowski
2026-04-20 12:57 ` Shawn Guo
2026-04-20 13:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd5ee12e-1aac-494f-a8f8-74e236ecb47c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=deepti.jaggi@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox