Re: [PATCH v4 1/2] arm64: dts: qcom: rubikpi3: Add qcs6490-rubikpi3 board dts

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/9/25 12:30 PM, Hongyang Zhao wrote:
>> On 9/30/25 6:32 AM, Hongyang Zhao wrote:
>>> Add DTS for Thundercomm qcs6490-rubikpi3 board which uses
>>> QCS6490 SoC.
>>>
>>> Works:
>>> - Wi-Fi (AP6256)
>>> - Bluetooth (AP6256)
>>> - Ethernet (AX88179B connected to UPD720201)
>>> - USB Type-C
>>> - USB Type-A 2.0 port
>>> - Two USB Type-A 3.0 ports (UPD720201 connected to PCIe0)
>>> - M.2 M-Key 2280 PCIe 3.0
>>> - RTC
>>> - 40PIN: I2C x1, UART x1
>>>
>>> Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
>>> Reviewed-by: Roger Shimizu <rosh@debian.org>
>>> Cc: Casey Connolly <casey.connolly@linaro.org>
>>> Cc: Christopher Obbard <christopher.obbard@linaro.org>
>>> Cc: Loic Minier V1<loic.minier@oss.qualcomm.com>

[...]

>>> +&thermal_zones {
>>> +	cpu0-thermal {
>>> +		trips {
>>> +			cpu_tepid: cpu-tepid {
>>> +				temperature = <65000>;
>>> +				hysteresis = <5000>;
>>> +				type = "active";
>>> +			};
>>
>> these are not useful unless you wire up the fan here
> 
> I wrote a service program at the user levelthat listens for netlink messages
> from here to control the fan.

Creative!

> Controlling the fan at the kernel level should be a better approach,
> and I have verified this. I will make modifications similar to the following:
> 
> 	cpu0-thermal {
> 		trips {
> 			cpu_tepid: cpu-tepid {
> 				temperature = <65000>;
> 				hysteresis = <5000>;
> 				type = "active";
> 			};
> 
> 			cpu_warm: cpu-warm {
> 				temperature = <80000>;
> 				hysteresis = <5000>;
> 				type = "active";
> 			};
> 
> 			cpu_hot: cpu-hot {
> 				temperature = <90000>;
> 				hysteresis = <5000>;
> 				type = "active";
> 			};
> 		};
> 
> 		cooling-maps {
> 			map-cpu-tepid {
> 				/* active: set fan to cooling level 1 */
> 				cooling-device = <&fan0 1 1>;
> 				trip = <&cpu_tepid>;
> 			};
> 
> 			map-cpu-warm {
> 				/* active: set fan to cooling level 2 */
> 				cooling-device = <&fan0 2 2>;
> 				trip = <&cpu_warm>;
> 			};
> 
> 			map-cpu-hot {
> 				/* active: set fan to cooling level 3 */

You can drop these comments

Konrad