From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E89EC54FD0 for ; Thu, 23 Apr 2020 17:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFE3F20728 for ; Thu, 23 Apr 2020 17:15:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LS7t6pzE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729872AbgDWRPd (ORCPT ); Thu, 23 Apr 2020 13:15:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729870AbgDWRPd (ORCPT ); Thu, 23 Apr 2020 13:15:33 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F4E4C09B045 for ; Thu, 23 Apr 2020 10:15:32 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id z6so7388526wml.2 for ; Thu, 23 Apr 2020 10:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Fsz6yPmVodHIAGKUEkvYHzu/ExufdaJ3lV6EfBbjr/M=; b=LS7t6pzEmK1UKWLE+ifdRC16uMDswKS7v+2IPC/TfosO7rAl+qZLKWbjscW8fVMt3v 1ma+2i4218WDyTaV/Nz10zY4H9KwN0u+ZSJbgg+iuqYMRImmBIYJNaO+GRPQWuMQ7nEn EIONqnAxXg1Zp2PZZeAdugJxMad9J6bW2gsLRpfAY8WjqySQzErIR3g+hDarox9ZuWqR GnpnaUL95V7dBN0xZRAeWhHOTZeyLhRGhJzZ9oKaENvK3QAePz+ztUbyLI1n2HD+wHEF e6D2NNwm3CcIPwegKXhdh8ViXwMsS8Mgh0dzwsOBoq4UFCZZn+OwOqe34GGtYiZxNz0D Dn2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Fsz6yPmVodHIAGKUEkvYHzu/ExufdaJ3lV6EfBbjr/M=; b=ZJzU9RNMic5FykzAJQFcnMvC2YGrgkDjP1EAZ1K4C6ObI7swaDaWFL/pjQ3RMkkE44 Te5GaohkKOQqwHl638vIqojHvchovd3qAiFM2YbOCYuRJBX4GI7AZzucGWRjly9uZK9S c4Ge1p+FSeO7lJHD2bwE3FZC2zjYrFc+fjhSy9drcyYv7cMZB9thxy5mxOlmGZZufr0g 3gMghYpJnAC9kfyVU6ufboaLOvs6YhNO1/k4ZMMcOa0ZvoT0Zwg2RE8uhyenNtrQ3wkj qGP33EXiNmLeXJ4rVDuUmcjpSrjOjskzc2kze/rk7GLrfybrclvNuObLDMZvcPUvNhbZ 8IjQ== X-Gm-Message-State: AGi0Pua/Dk30anFq1piLn3dK0bl+sMiqew+ck16ghkGroC8fdYd4IMN1 cOmUOD/xHofvdVrREuNkM6xxdQ== X-Google-Smtp-Source: APiQypLpzfjeHcKORCtuutm1uyBf7sFOUFW7Mb8uOr8lGTYIICuH1CY1N6lSdxp/QVB17oX17RO+pA== X-Received: by 2002:a05:600c:2194:: with SMTP id e20mr5154639wme.22.1587662130818; Thu, 23 Apr 2020 10:15:30 -0700 (PDT) Received: from [192.168.43.23] ([37.167.216.250]) by smtp.googlemail.com with ESMTPSA id a20sm4965935wra.26.2020.04.23.10.15.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2020 10:15:30 -0700 (PDT) Subject: Re: [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Dietmar.Eggemann@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, qperret@google.com, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org, mka@chromium.org References: <20200410084210.24932-1-lukasz.luba@arm.com> <20200410084210.24932-5-lukasz.luba@arm.com> <20200423151250.GB65632@linaro.org> From: Daniel Lezcano Message-ID: Date: Thu, 23 Apr 2020 19:15:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/04/2020 18:57, Lukasz Luba wrote: > > > On 4/23/20 4:12 PM, Daniel Lezcano wrote: >> On Fri, Apr 10, 2020 at 09:42:04AM +0100, Lukasz Luba wrote: >>> Add support for other devices that CPUs. The registration function >>> does not require a valid cpumask pointer and is ready to handle new >>> devices. Some of the internal structures has been reorganized in >>> order to >>> keep consistent view (like removing per_cpu pd pointers). To track usage >>> of the Energy Model structures, they are protected with kref. >> >> Why not add the energy model structure in the struct device directly? > > Do you mean this structure? > https://elixir.bootlin.com/linux/latest/source/include/linux/device.h#L537 > > and to put something like: > struct device { > ... >     struct dev_pm_domain    *pm_domain; > #ifdef CONFIG_ENERGY_MODEL >     struct em_perf_domain    *em_pd; > #endif > ... > }; Yes, exactly. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog