From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status Date: Tue, 30 Aug 2016 13:51:02 -0400 Message-ID: References: <1471927691-28827-1-git-send-email-okaya@codeaurora.org> <1471927691-28827-4-git-send-email-okaya@codeaurora.org> <20160830170422.GN9355@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:45486 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932463AbcH3RvG (ORCPT ); Tue, 30 Aug 2016 13:51:06 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Vinod Koul Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Lars-Peter Clausen , Andy Shevchenko , Dave Jiang , linux-kernel@vger.kernel.org On 8/30/2016 1:37 PM, Sinan Kaya wrote: > On 8/30/2016 1:04 PM, Vinod Koul wrote: >> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: >> >>> spin_lock_init(&lldev->lock); >>> - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev); >> >> ?? >> >> This is not described in changlog? If you are not using in anywhere else, >> then rst_task variable should be removed too.. >> > > Sure, I can add more description. I thought I did mention that we are no longer > resetting the hardware in ISR. > > I can certainly mention that rst_task variable is removed and can get rid of it. > It is no longer in use. > It looks like I mentioned this in the cover letter only not in the commit message. I'll pull the description into the commit message too. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.