From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5A1E7AD74 for ; Tue, 3 Oct 2023 15:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231979AbjJCP5V (ORCPT ); Tue, 3 Oct 2023 11:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231422AbjJCP5U (ORCPT ); Tue, 3 Oct 2023 11:57:20 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C2F29E for ; Tue, 3 Oct 2023 08:57:16 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40651a72807so10845225e9.1 for ; Tue, 03 Oct 2023 08:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696348635; x=1696953435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U4ci3PGm2LPgLVtRlA44jOoVtYu71qTPmz8qC5gmhz4=; b=nnevNyOyD7fOj0X/cLRdrEf69etCVnC0xjF6vTrNuURucHw7KzmgunlYciE/+MSydk Pq7FHIwlKsNQYECfpgfqXhio7O+dngy6DCjkYSfn4RP2ZabZY089oSYGKDwjeScTKpoi cIvy41ZDLWWIbauJiMY7Ea9hCECOm/QUyKSnXZeSFtk+Z3q7F8frBi+QTp0AieN1iy9k 5a11MYSXOIjhskUvkAmXYxWDn2Zkn6WitU3mWWXqXqBvH/1KDmypI9+g0G2KbftrMNlV Oawubbl65ASNRJIdao5oW+LwjaC4r7kApxNoqSL+3ZYZuwCW/Hc8ZNlM1GnV4DrKpd0e 6t6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696348635; x=1696953435; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U4ci3PGm2LPgLVtRlA44jOoVtYu71qTPmz8qC5gmhz4=; b=cuazbHt3kyjoCLD3uACgS5WwkwVxUEFg37AtamuxKGWyidJvAWjgXFg7EqzjBksTfP vzjP8uQyH4y5TAjIONlngmA8zR1cmh283FJo+woyIyMoE3sKsOVFUH2LHtrZOGBNjnhY 2foX4j9L2osbMHoH9o1IMnK5rTtTsPhLd92qggY+RzN9iY7Lp5JJzoH22oPyPHvEsXz8 TTyv7CpVeNq065TI4dMkjVWWaw0AK9mV/eMMGA0LEgB2GBuHqTF/ssbypNjnWACzY+yI 3f7dd9g3Ygywm2KciwCS2h+nrpe0Y8YAl9aoclpiJh+heedun+C0zCQuDYaln/VGsQtT tOOA== X-Gm-Message-State: AOJu0YwoDaHvyfkGr+4b8f/kx+xKUwQI7uTnO5mBZiBv/hObnpUcGi9V n1PuRH4kdpzjUpqUFI0zmpGzxw== X-Google-Smtp-Source: AGHT+IEFJi5eQZLDZbHuP8V3eVbhyktNfPfTMEhybWz6RcKN42IxH4JbcBGARfmxvNdpB/suD8I8Qg== X-Received: by 2002:a05:600c:2199:b0:401:bf56:8ba6 with SMTP id e25-20020a05600c219900b00401bf568ba6mr11984354wme.28.1696348634720; Tue, 03 Oct 2023 08:57:14 -0700 (PDT) Received: from [192.168.1.8] (host-2-99-112-229.as13285.net. [2.99.112.229]) by smtp.gmail.com with ESMTPSA id i5-20020adffdc5000000b0031fb91f23e9sm1885885wrs.43.2023.10.03.08.57.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 08:57:14 -0700 (PDT) Message-ID: Date: Tue, 3 Oct 2023 16:57:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] mfd: qcom-spmi-pmic: fix revid implementation Content-Language: en-US To: Johan Hovold , Lee Jones Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231003152927.15000-1-johan+linaro@kernel.org> From: Caleb Connolly In-Reply-To: <20231003152927.15000-1-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 03/10/2023 16:29, Johan Hovold wrote: > The Qualcomm SPMI PMIC revid implementation is broken in multiple ways > that can lead to resource leaks and crashes. This series reworks the > implementation so that can be used safely. > > Included is also a rename of the SPMI device lookup helper which can > hopefully help prevent similar leaks from being reintroduced. > > Johan This is.. definitely a major improvement. Thanks for cleaning up my mess fwiw Acked-by: Caleb Connolly > > > Johan Hovold (5): > mfd: qcom-spmi-pmic: fix reference leaks in revid helper > mfd: qcom-spmi-pmic: fix revid implementation > mfd: qcom-spmi-pmic: switch to EXPORT_SYMBOL_GPL() > spmi: document spmi_device_from_of() refcounting > spmi: rename spmi device lookup helper > > drivers/mfd/qcom-spmi-pmic.c | 103 +++++++++++++++++++++++++---------- > drivers/spmi/spmi.c | 9 ++- > include/linux/spmi.h | 2 +- > 3 files changed, 80 insertions(+), 34 deletions(-) > -- // Caleb (they/them)