From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827CFC76196 for ; Sun, 19 Mar 2023 22:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbjCSWcM (ORCPT ); Sun, 19 Mar 2023 18:32:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjCSWcK (ORCPT ); Sun, 19 Mar 2023 18:32:10 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A23A716319 for ; Sun, 19 Mar 2023 15:32:07 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id v1so2624612wrv.1 for ; Sun, 19 Mar 2023 15:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679265126; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fohqGcHXJxV4OWB96+iPZX24oSGOImwXoZzdgKcxYbA=; b=oJDSyzTDL9K5tMgpjKbldsRlri8RTOqyjjZATADTdtWaw6oQBmcVjsAHS3D9CoEiOy LrLaZMTvF/3XPLCpRvMRGEsl+xEA+DyC3frPnzAr5iJzFjTZ7s+kfZVlZ50DOboTxARK Vww53pOimMRjKHSEY/0ITGe0sDXLrd6+IbyhB06i4qg23klCrEh3s0nV3HS08eFcDJbS Ghygmnx9X6TLA9rQ9NjAwCmNZGPD+Lw/AJwb/VgScMrX8CoHxAQHt/51FymxiQ+J0NjO HPCq0+WoYH615RJmI0QWy92APkZaazOHaMCUSIZelLTHzHHzcoiqw7POLXsRKeewP3mF /2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679265126; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fohqGcHXJxV4OWB96+iPZX24oSGOImwXoZzdgKcxYbA=; b=OMBXI9jB3w3HutboBlu70V2gyyYSL36lSVszqNnkiNCSWS2N5dRciAxw1kiRyHwmDv NDdHDEcu6uHKCnBqzxdIy9DrbPveseMiUuZBjkdiy3/gdj7mc41h0mBwyvH/Mtq7Dsne 62Nm2qwI82aTSGnqQRzkZ2ISmRm7pvui/FwWG4slBYhpk4SwkS6j2CxKTZhQspGLbzSp 2XGunh069EESy6u/1X4KDTzM+IpABoREyVW1tv1jOIqOnePYGIAw2hI8N+nGDigF4i93 zr59/V0hSV8pBhjjc8lWrUBlDWj3mDTVRPpEqQ2SVZ7jByyaHP3DdgEUKdwLC6Rx/rOz zQFQ== X-Gm-Message-State: AO0yUKVB3Pger+D3hNGzkJHQmPmQ0u/BPho+A2qzhuPRa+Lp+UBriI89 /07tQDncA+aKvmUmJB7aX+4y+A== X-Google-Smtp-Source: AK7set/t9OHwOuBXjXm73Rue333WtHHPoZX5P4YAE1iEt6CP26hTl1d/NnFGyPOSCCTSdSw93F8hZg== X-Received: by 2002:adf:dd85:0:b0:2c8:e09:9335 with SMTP id x5-20020adfdd85000000b002c80e099335mr11891458wrl.46.1679265126138; Sun, 19 Mar 2023 15:32:06 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id b5-20020adfee85000000b002c573778432sm7359863wro.102.2023.03.19.15.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 15:32:05 -0700 (PDT) Message-ID: Date: Sun, 19 Mar 2023 22:32:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 09/18] dt-bindings: usb: Add Qualcomm PMIC TCPM YAML schema Content-Language: en-US To: Krzysztof Kozlowski , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: wcheng@codeaurora.org, caleb.connolly@linaro.org, konrad.dybcio@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230318121828.739424-1-bryan.odonoghue@linaro.org> <20230318121828.739424-10-bryan.odonoghue@linaro.org> <7cd51a8d-7b23-7895-7c06-07dc98924931@linaro.org> <346ecd20-d64f-1d47-4860-861e142f9700@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 19/03/2023 17:50, Krzysztof Kozlowski wrote: >> So this comment from Rob is what I was aiming for >> >> "Your other option is instantiate your own device from the virtual >> driver's initcall based on presence of the 2 nodes above. " >> >> rather than two mush the pdphy and typec into one device, which they are >> not. > Sure, but you did not instantiate anything based on these two or one > nodes. You added virtual device node. Yes true, but I see the distinction you are making. > >> I guess what I'm trying to understand is how you guys would suggest that >> is actually done. > You have there already node for the PMIC USB Type-C, so this should be > part of it. I really do not understand why this is separate device lying > around in parallel like: > > pmic { > usb { > }; > }; > > virtual- pmic-tcpm { > }; > > What hardware piece does such description represent? > None, yes its a "HLOS" convenience, I take your point.