From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Georgi Djakov <djakov@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Brian Masney <masneyb@onstation.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] interconnect: qcom: drop unused is_on flag
Date: Wed, 25 Mar 2026 12:01:03 +0100 [thread overview]
Message-ID: <df041143-46a4-4cfe-a587-a613242d4bde@oss.qualcomm.com> (raw)
In-Reply-To: <ky6o64toksq4ozbbad4i7mrmrqjkq5ffphrwdruejq6godxco5@ds2een4mht2v>
On 3/24/26 12:12 AM, Dmitry Baryshkov wrote:
> On Mon, Mar 23, 2026 at 11:26:47AM +0100, Konrad Dybcio wrote:
>> On 3/23/26 2:17 AM, Dmitry Baryshkov wrote:
>>> The commit 2e2113c8a64f ("interconnect: qcom: rpm: Handle interface
>>> clocks") has added the is_on flag to the qcom_icc_provider, but failed
>>> to actually utilize it. Drop the flag.
>>>
>>> Fixes: 2e2113c8a64f ("interconnect: qcom: rpm: Handle interface clocks")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>> drivers/interconnect/qcom/icc-rpm.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/interconnect/qcom/icc-rpm.h b/drivers/interconnect/qcom/icc-rpm.h
>>> index f4883d43eae4..3366531f66fc 100644
>>> --- a/drivers/interconnect/qcom/icc-rpm.h
>>> +++ b/drivers/interconnect/qcom/icc-rpm.h
>>> @@ -51,7 +51,6 @@ struct rpm_clk_resource {
>>> * @bus_clk: a pointer to a HLOS-owned bus clock
>>> * @intf_clks: a clk_bulk_data array of interface clocks
>>> * @keep_alive: whether to always keep a minimum vote on the bus clocks
>>> - * @is_on: whether the bus is powered on
>>> */
>>> struct qcom_icc_provider {
>>> struct icc_provider provider;
>>> @@ -66,7 +65,6 @@ struct qcom_icc_provider {
>>> struct clk *bus_clk;
>>> struct clk_bulk_data *intf_clks;
>>> bool keep_alive;
>>> - bool is_on;
>>
>> Hm, looks like the clock vote is kept all the way from .probe()
>> to .remove(). I wonder if that's really what should happen..
>
> Well, it's probably up to you to decide. I've a bit lost my way in the
> vendor's adhoc / bus / etc. code.
>
>>
>> That's what drivers/interconnect/qcom/holi.c does on msm-5.10
>>
>> Maybe "iface clocks" are only needed to execute a ->set() on a node?
>
> Hmm, I don't know. AXI clocks seems to describe the clocking between the
> NoC and a particular device. So maybe it's required for as long as there
> is something using the NoC.
I'll keep this on my infinite todolist
Konrad
next prev parent reply other threads:[~2026-03-25 11:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 1:17 [PATCH 0/9] interconnect: qcom: let MSM8974 interconnect work again Dmitry Baryshkov
2026-03-23 1:17 ` [PATCH 1/9] dt-bindings: interconnect: qcom,msm8974: drop bus clocks Dmitry Baryshkov
2026-03-23 1:17 ` [PATCH 2/9] dt-bindings: interconnect: qcom,msm8974: use qcom,rpm-common Dmitry Baryshkov
2026-03-23 1:17 ` [PATCH 3/9] interconnect: qcom: drop unused is_on flag Dmitry Baryshkov
2026-03-23 10:26 ` Konrad Dybcio
2026-03-23 23:12 ` Dmitry Baryshkov
2026-03-25 11:01 ` Konrad Dybcio [this message]
2026-03-23 1:17 ` [PATCH 4/9] interconnect: qcom: icc-rpm: allow overwriting get_bw callback Dmitry Baryshkov
2026-03-23 10:32 ` Konrad Dybcio
2026-03-23 23:14 ` Dmitry Baryshkov
2026-03-24 11:34 ` Konrad Dybcio
2026-03-24 22:51 ` Dmitry Baryshkov
2026-03-23 1:17 ` [PATCH 5/9] interconnect: qcom: define OCMEM bus resource Dmitry Baryshkov
2026-03-23 10:27 ` Konrad Dybcio
2026-03-23 10:53 ` Brian Masney
2026-03-23 1:17 ` [PATCH 6/9] interconnect: qcom: let platforms declare their bugginess Dmitry Baryshkov
2026-03-23 10:36 ` Konrad Dybcio
2026-03-23 10:56 ` Brian Masney
2026-03-23 1:17 ` [PATCH 7/9] interconnect: qcom: msm8974: switch to the main icc-rpm driver Dmitry Baryshkov
2026-03-23 10:36 ` Konrad Dybcio
2026-03-23 1:17 ` [PATCH 8/9] interconnect: qcom: msm8974: expand DEFINE_QNODE macros Dmitry Baryshkov
2026-03-23 10:45 ` Konrad Dybcio
2026-03-23 1:17 ` [PATCH 9/9] ARM: dts: qcom: msm8974: Drop RPM bus clocks Dmitry Baryshkov
2026-03-23 10:41 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df041143-46a4-4cfe-a587-a613242d4bde@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=masneyb@onstation.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox