From: Jessica Zhang <jesszhan@codeaurora.org>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Rob Clark <robdclark@chromium.org>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Maxime Ripard <maxime@cerno.tech>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Krishna Manikandan <mkrishn@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Jessica Zhang <jesszhan@codeaurora.org>,
Mark Yacoub <markyacoub@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/msm/dpu: Remove impossible NULL check
Date: Fri, 22 Oct 2021 12:13:35 -0700 [thread overview]
Message-ID: <e070bb16-7c7a-3b1a-0e0c-1330b1d0b8d3@codeaurora.org> (raw)
In-Reply-To: <20211022172053.3219597-1-robdclark@gmail.com>
On 10/22/2021 10:20 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Jessica Zhang <jesszhan@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index e91568d4f09a..0ae397044310 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -187,11 +187,6 @@ static int dpu_crtc_get_crc(struct drm_crtc *crtc)
> int i = 0;
> int rc = 0;
>
> - if (!crtc) {
> - DPU_ERROR("Invalid crtc\n");
> - return -EINVAL;
> - }
> -
> crtc_state = to_dpu_crtc_state(crtc->state);
> crcs = kcalloc(crtc_state->num_mixers, sizeof(*crcs), GFP_KERNEL);
>
prev parent reply other threads:[~2021-10-22 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 17:20 [PATCH 1/2] drm/msm/dpu: Remove impossible NULL check Rob Clark
2021-10-22 17:20 ` [PATCH 2/2] drm/msm/dpu: Remove dynamic allocation from atomic context Rob Clark
2021-10-22 19:14 ` Jessica Zhang
2021-10-23 15:59 ` Rob Clark
2021-10-22 19:13 ` Jessica Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e070bb16-7c7a-3b1a-0e0c-1330b1d0b8d3@codeaurora.org \
--to=jesszhan@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markyacoub@google.com \
--cc=maxime@cerno.tech \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox