From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
Qiang Yu <quic_qianyu@quicinc.com>
Cc: <mhi@lists.linux.dev>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_cang@quicinc.com>,
<quic_mrana@quicinc.com>
Subject: Re: [PATCH v5 1/3] bus: mhi: host: Add sysfs entry to force device to enter EDL
Date: Thu, 25 Apr 2024 09:07:37 -0600 [thread overview]
Message-ID: <e0fb41f3-3080-c1b5-ab7c-bcff8bbbe754@quicinc.com> (raw)
In-Reply-To: <20240425145450.GH3449@thinkpad>
On 4/25/2024 8:54 AM, Manivannan Sadhasivam wrote:
> On Wed, Apr 24, 2024 at 11:21:53AM +0800, Qiang Yu wrote:
>> Add sysfs entry to allow users of MHI bus force device to enter EDL.
>> Considering that the way to enter EDL mode varies from device to device and
>> some devices even do not support EDL. Hence, add a callback edl_trigger in
>> mhi controller as part of the sysfs entry to be invoked and MHI core will
>> only create EDL sysfs entry for mhi controller that provides edl_trigger
>> callback. All of the process a specific device required to enter EDL mode
>> can be placed in this callback.
>>
>> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
>> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
>
> All 3 patches are applied to mhi-next with my reported changes! Since you are
> doing upstreaming for some time, you should know that the changelog _must_ be
> present in the patches itself or in the cover letter.
It is/was in the cover letter. Was the format not to your liking?
-Jeff
next prev parent reply other threads:[~2024-04-25 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 3:21 [PATCH v5 0/3] Add sysfs entry to EDL mode Qiang Yu
2024-04-24 3:21 ` [PATCH v5 1/3] bus: mhi: host: Add sysfs entry to force device to enter EDL Qiang Yu
2024-04-25 14:54 ` Manivannan Sadhasivam
2024-04-25 15:07 ` Jeffrey Hugo [this message]
2024-04-27 11:50 ` Manivannan Sadhasivam
2024-04-24 3:21 ` [PATCH v5 2/3] bus: mhi: host: Add a new API for getting channel doorbell address Qiang Yu
2024-04-24 3:21 ` [PATCH v5 3/3] bus: mhi: host: pci_generic: Add edl callback to enter EDL Qiang Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0fb41f3-3080-c1b5-ab7c-bcff8bbbe754@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_cang@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_qianyu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox