Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Trilok Soni <quic_tsoni@quicinc.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Sai Prakash Ranjan <quic_saipraka@quicinc.com>
Cc: <arnd@arndb.de>, <catalin.marinas@arm.com>, <rostedt@goodmis.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<maz@kernel.org>, <quic_psodagud@quicinc.com>, <will@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial
Date: Thu, 28 Apr 2022 09:31:43 -0700	[thread overview]
Message-ID: <e11455d8-78c2-68e8-215e-a4e3587f3e4a@quicinc.com> (raw)
In-Reply-To: <Ympxa0ZY0VxZGEjA@kroah.com>

On 4/28/2022 3:50 AM, Greg KH wrote:
> On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote:
>> Disable MMIO tracing for geni serial driver as it is a high
>> frequency operation for serial driver with many register reads/
>> writes and not very useful to log all MMIO traces and prevent
>> excessive logging.
>>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
>> ---
>>   drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
>> index 1543a6028856..5b48e6c2bf3c 100644
>> --- a/drivers/tty/serial/qcom_geni_serial.c
>> +++ b/drivers/tty/serial/qcom_geni_serial.c
>> @@ -1,5 +1,11 @@
>>   // SPDX-License-Identifier: GPL-2.0
>> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
>> +/*
>> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
> 
> I strongly disagree that adding a single line here warrants a copyright
> update.  If your lawyers will sign off on this change, I am willing to
> reconsider.

I am not a lawyer, we can skip adding QuIC copyright here since it is 
just one line change, but at the same time we can't add 2022 year in the 
existing copyright. If that is fine, we can skip the copyright year 
update entirely.

---Trilok Soni

  parent reply	other threads:[~2022-04-28 16:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  9:55 [PATCHv12 0/9] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 1/9] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 2/9] coresight: etm4x: Use asm-generic IO memory barriers Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 3/9] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 4/9] drm/meson: " Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 5/9] lib: Add register read/write tracing support Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 6/9] KVM: arm64: Add a flag to disable MMIO trace for nVHE KVM Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 7/9] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan
2022-04-28 10:51   ` Greg KH
2022-04-28 11:21     ` Sai Prakash Ranjan
2022-04-28 12:02       ` Greg KH
2022-04-28 12:29         ` Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial Sai Prakash Ranjan
2022-04-28 10:50   ` Greg KH
2022-04-28 11:30     ` Sai Prakash Ranjan
2022-04-28 16:31     ` Trilok Soni [this message]
2022-04-28 16:49       ` Greg KH
2022-04-28 17:00         ` Trilok Soni
2022-04-29 13:00           ` Sai Prakash Ranjan
2022-04-28  9:55 ` [PATCHv12 9/9] soc: qcom: geni: Disable MMIO tracing for GENI SE Sai Prakash Ranjan
2022-04-28 10:50   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e11455d8-78c2-68e8-215e-a4e3587f3e4a@quicinc.com \
    --to=quic_tsoni@quicinc.com \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox