From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED088C678D4 for ; Tue, 7 Mar 2023 08:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbjCGIUH (ORCPT ); Tue, 7 Mar 2023 03:20:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230294AbjCGITu (ORCPT ); Tue, 7 Mar 2023 03:19:50 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E53D950982 for ; Tue, 7 Mar 2023 00:19:32 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id x3so48905570edb.10 for ; Tue, 07 Mar 2023 00:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678177171; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L29zoxdXB+9rG1fLUEgpKITaNSXX7YTpGeQMCFWsUlU=; b=cLhewAPwWGbiEgQD8BrRaTB9CISRVJiI1qsPS1xLwFqSeiJMaZHwItjU/fUVY4oBHk rKbUuu+ISdMGceZ2vKIYrJFcoDv3bYNP8sWXnDILI8QDuFpUwmGuIXNkz8WmHY948/It WAN/vk9WmheZlkSP8LaQP9G63+xCLRkmqbbreoabPHS3LqriMyNat2q8sYw0ra1q+XkC TAfIx/XHHdW0v3f8XGWwMN49AwcRCNxTnvvwzyKqpb1h5QjBR32mhsIT8iYkctgLhH6Z JfDZGCzEysm6VKU8eIgqMtlbUA4nh077de9pqbOxruTEcJ7q2hhPuPPNXYv/dQ1iSI7j q8uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678177171; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L29zoxdXB+9rG1fLUEgpKITaNSXX7YTpGeQMCFWsUlU=; b=Ls5WrU/TTWpWEldOlouBjrUly5WkENK1ekefq1U7NEZiysaWDgwRk+zME7w2GNR1h6 Km8jIWHV+EbtZe5NzruVpisNz4Nsgi43+ZFD6b4tp7EbmbpBkk2aRfMwNZOkzgF3OxIJ JzV8wwVNnj3iuNPGd8M8uUmG0M60+XrB19fpkC4YtSELihAreNBF8x7J0nCt4n80ynIS fcjTdnHzvzILDaCOYq8UsSoZJe+DoUDbGFD64IICklDch4bjHE1X7KP8jjfFGqMwSrTL 0kLDabhTwl/JUODBx+rOGewi018yKQRXa4cLgAh1/N4+XzujIROwgMmrxd4sc+iWxkpa K8lg== X-Gm-Message-State: AO0yUKXndgmGLAYSrfYiFRsTuHxJjlE9a8AHOFOAzzIeuOPiC9Oti3aU le8j2YyiijRc2BBPVnMT45/06Q== X-Google-Smtp-Source: AK7set9GIu+MHeoxgW3h+cvWIolDDHxYDsBBJR/WlR5sDK0s9E5NdGkl+9tcjjs/CRcV9o11YcaxIQ== X-Received: by 2002:a17:907:d08:b0:878:4bc1:dd19 with SMTP id gn8-20020a1709070d0800b008784bc1dd19mr14627138ejc.52.1678177171461; Tue, 07 Mar 2023 00:19:31 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:5310:35c7:6f9e:2cd3? ([2a02:810d:15c0:828:5310:35c7:6f9e:2cd3]) by smtp.gmail.com with ESMTPSA id i24-20020a50d758000000b004ad15d5ef08sm6377165edj.58.2023.03.07.00.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Mar 2023 00:19:31 -0800 (PST) Message-ID: Date: Tue, 7 Mar 2023 09:19:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 14/19] PCI: qcom-ep: Rename "mmio" region to "mhi" Content-Language: en-US To: Manivannan Sadhasivam , andersson@kernel.org, lpieralisi@kernel.org, kw@linux.com, krzysztof.kozlowski+dt@linaro.org, robh@kernel.org Cc: konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, quic_srichara@quicinc.com References: <20230306153222.157667-1-manivannan.sadhasivam@linaro.org> <20230306153222.157667-15-manivannan.sadhasivam@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230306153222.157667-15-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 06/03/2023 16:32, Manivannan Sadhasivam wrote: > As per Qualcomm's internal documentation, the name of the region is "mhi" > and not "mmio". So let's rename it to follow the convention. > > Signed-off-by: Manivannan Sadhasivam > --- > > @@ -477,16 +477,16 @@ static int qcom_pcie_ep_get_io_resources(struct platform_device *pdev, > if (IS_ERR(pcie_ep->elbi)) > return PTR_ERR(pcie_ep->elbi); > > - pcie_ep->mmio_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "mmio"); > - if (!pcie_ep->mmio_res) { > - dev_err(dev, "Failed to get mmio resource\n"); > + pcie_ep->mhi_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > + "mhi"); That's an ABI break. Patchset is also non-bisectable. Best regards, Krzysztof