Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

nguyenb
2020-10-26T20:48:45Z

On 2020-08-31 18:19, Bao D. Nguyen wrote:
> UFS version 3.0 and later devices require Vcc and Vccq power supplies
> with Vccq2 being optional. While earlier UFS version 2.0 and 2.1
> devices, the Vcc and Vccq2 are required with Vccq being optional.
> Check the required power supplies used by the device
> and set the device's supported Icc level properly.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 06e2439..fdd1d3e 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6845,8 +6845,9 @@ static u32
> ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> {
> u32 icc_level = 0;
>
> - if (!hba->vreg_info.vcc || !hba->vreg_info.vccq ||
> - !hba->vreg_info.vccq2) {
> + if (!hba->vreg_info.vcc ||
> + (!hba->vreg_info.vccq && hba->dev_info.wspecversion >= 0x300) ||
> + (!hba->vreg_info.vccq2 && hba->dev_info.wspecversion < 0x300)) {
> dev_err(hba->dev,
> "%s: Regulator capability was not set, actvIccLevel=%d",
> __func__, icc_level);
Hello,
Could you please help review?
Thank you.