From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5EA3284684 for ; Tue, 21 Oct 2025 21:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761080891; cv=none; b=liCfug/+Sh0vZn3OSeREY4k2mw/8lW3fI4wieK9UwmdEg9Sun+VavisAkf07fxWerDx+HXpj7sjljLbpe3RgMRe56SxYt4Bwkqpq2B8p1SqehH9APJjxZqCvm6JzL8KKy2ZlhVXMIKuPNYBE2ob4qjrZC4dv6l/CsVZWBs+YE+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761080891; c=relaxed/simple; bh=hKP7hv2q/vLR9OB/KNuT7rmHgtOvMGEK2wehJ7tZQGs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WZEEvO/VdDFYXiyqT9D0U0xsW73YNGhV4smRc2koaUAL+09gAiMlyMvZ7FkV/DvDMiqjRQ6vq1O/W9TocCpuMNQPO75w0QJ2i5ML66D+4Wk17/m+udLjDtLrEj9uadTul0gN7mec1CMVQwFGUfxUFkxWsH9fltLC50C4qdMMSMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kfXkYWgL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kfXkYWgL" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59LFie36026555 for ; Tue, 21 Oct 2025 21:08:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kUHcX9qshXGQudm9WWiL14vKBawx4q0zuajE6NVvFCA=; b=kfXkYWgLZ9WSmfrm +c2+EYRsE8AppJZGlB+pzMgB5LzUyRuzknjgqbeMQsYuAWojcxD05Ffuo4qTreHc w5f3GkXtDXuDopf5/Ns2FcItb3TabLiPWANSR9ekBCdJbR7wGhYDS4Ew7Yx84BEm OMKvPE2LOzMlD6DnXqvu3+zmTLqDv9AFpRD7j6kY0++X5gQ0kbq1K+hz8A8UYO0D pjhnL7znYNbtb1BZAJGMeNPWx/myo+tuWXGUiXLbBxTX0RugG7I2JgB0JCmnD3Ye LIw/RCqbcdTy3vp6ZLaKPYs4bXv9/XNVISlWtUMOhOO93+A2aOpp1c4B0KJ0WfdA g2gOCA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v27j28d3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 21 Oct 2025 21:08:08 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7900f597d08so5333015b3a.1 for ; Tue, 21 Oct 2025 14:08:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761080887; x=1761685687; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kUHcX9qshXGQudm9WWiL14vKBawx4q0zuajE6NVvFCA=; b=dXi/ANESInTwRkBTIRUYWS/d7MP6T3gpxMQ8oxka4AwOLRhAj120zTwxX463GigavZ Y6vX/GMC3BRWUDDnIIjlBOg2+PcXeQjV5Vw/9ktuUJRUVNTLOWZXd0UOo+nJLfRFbn7c NzRyqIHDdV8P4p4iSKT/VZaeQz124JH6lQDS8RauJhwzbEBWd09TsGIVxJA0iLAmeFWx KK2ynYIwwc+sNwkBY5iMVhLy3JGf5h3pI8xgQRrM1nhjuOZhX3e/Ibb+N52+YyBlX2CD LfiXCDGCPwROPPYWajojNuKNK/KXnn7+9RU+5PHfMdQ7CMfY/1LqX9ZVPEMXMb5tQTnl LP2w== X-Gm-Message-State: AOJu0Yw+tFgk4Xv29BUGZ/v3h4RWtQBj1B8eKrNt3Ohxz9NQlZ46g0tx HJ70Q277PCGg9xeNjXWQ+VU01dFLu9oq4JJ/JDVNtUXBDjetT6Or5jpqabZljjYey20Hgx1O1YQ XFACc01UVewG/jO/4Pi9NHKJpPl0pd91M70Gmme191LPqEgIsCzQf4snpG9XmjJiBD+an X-Gm-Gg: ASbGncsxRFSi5lMTUA/FVyq2YTjxnBOQGdAfR+/IAxgsSXwxSVc6uAp69zvf7FOBqza yl4ga108sdpQ+h/TqppMASPLnktmUIjhUWpXE4ytgYQ1hASdHssCA9o1qkmIApdmxGFcawCaJGZ qE4yXc6qhlKQrJS1AO2Bp6tzGjAMrtahlDUq1K81nfW1j47PePX9m3Npbzy8JFyRgKQoY3esfO4 vExxKnkYDhcSVN0Jf2q3J1ZJfbNxwpxRXsiZNnHpICbzVY6m64kGxdB6lNssTUm7yneHs8WOW8b oHBst/4SXoPZRKcYcZj26oiqGRnlPAqbmtYWW4/rseL9mNCKV4e3tqle+zOtod4yf11Sw3KkjFy zq/gFtH41Ddzu8iw+ToWuobcFmErRmmfzNw== X-Received: by 2002:a05:6a20:7287:b0:262:82a6:d932 with SMTP id adf61e73a8af0-334a86256f9mr22761797637.48.1761080887351; Tue, 21 Oct 2025 14:08:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESdm7op53/MzUS5K7s1gaOrJSGLx+p35WP7TbnHImOwmOCXg89kxayJjZ68H5wLE/Jqdy/hA== X-Received: by 2002:a05:6a20:7287:b0:262:82a6:d932 with SMTP id adf61e73a8af0-334a86256f9mr22761758637.48.1761080886737; Tue, 21 Oct 2025 14:08:06 -0700 (PDT) Received: from [192.168.0.166] ([49.205.248.205]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6cdafadb8dsm607908a12.1.2025.10.21.14.08.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 14:08:06 -0700 (PDT) Message-ID: Date: Wed, 22 Oct 2025 02:37:59 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/8] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding Content-Language: en-US To: Krzysztof Kozlowski , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Dmitry Baryshkov , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20251017-knp_video-v2-0-f568ce1a4be3@oss.qualcomm.com> <20251017-knp_video-v2-1-f568ce1a4be3@oss.qualcomm.com> <034bf6f4-0a49-4973-8536-28526b3409d1@oss.qualcomm.com> From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAxOCBTYWx0ZWRfX/2ajVrkDQPSH hnruq6K8+7uhLY/8dqUCuXth+LNra7vW7r3JhAOxtXq0VYTNXIoKqmeiy/bnzm7JhbXiat6jBl+ q3I2yzEYAnXvXAXh2C9LF+dX41ZLMKSRAFd+E/Jq4oCT/LGF5hs6hci3SZgOTKiF+82TWPxNkHA tHgKjS456neYvwOq4GTI4Me5RCOhV9xDvNCoTmp72aEmah7KkS9kk0NRi2nlZt3ZkyW4o2DrQtq p4WMqz8k73b5WEA/nvyvo0wysofL1jQL+LB7pF//JhmC5ZUXrZROQg8uUo0E1++vOcLpFIgU9cs GGPIDGvDSfjJB86OQ1MZoDnSS7Wa3D5HAu1YtlI1lQsupywL6vWaF7XvyEn0fqO0w99On1UY9lh EIrppItrjlmUUYEdtcY1iBdVfbWqIg== X-Authority-Analysis: v=2.4 cv=G4UR0tk5 c=1 sm=1 tr=0 ts=68f7f638 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Ysf2FyB+yl5xZy2y99iGVQ==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=mYW7RsAQjGC2aXFlLLIA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: -IL89D26lluNRtdSU2XaVn2xcNOwVyFl X-Proofpoint-ORIG-GUID: -IL89D26lluNRtdSU2XaVn2xcNOwVyFl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-21_03,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180018 On 10/22/2025 12:45 AM, Krzysztof Kozlowski wrote: > On 21/10/2025 20:55, Vikash Garodia wrote: >> >> On 10/18/2025 9:28 PM, Krzysztof Kozlowski wrote: >>> On 17/10/2025 16:16, Vikash Garodia wrote: >>>> + clock-names: >>>> + items: >>>> + - const: iface >>>> + - const: core >>>> + - const: vcodec0_core >>>> + - const: iface1 >>>> + - const: core_freerun >>>> + - const: vcodec0_core_freerun >>>> + - const: vcodec_bse >>>> + - const: vcodec_vpp0 >>>> + - const: vcodec_vpp1 >>>> + - const: vcodec_apv >>>> + >>>> + dma-coherent: true >>>> + >>>> + firmware-name: >>>> + maxItems: 1 >>>> + >>>> + interconnects: >>>> + maxItems: 2 >>>> + >>>> + interconnect-names: >>>> + items: >>>> + - const: cpu-cfg >>>> + - const: video-mem >>>> + >>>> + interrupts: >>>> + maxItems: 1 >>>> + >>>> + iommus: >>>> + minItems: 3 >>>> + maxItems: 8 >>> >>> I don't understand why this is flexible. Make it fixed size and anyway - >>> list the items. >> >> kaanapali vpu generates 8 different stream-ids. Now, boards running kernel in >> EL2 mode can list all of them, while boards running in EL1 can have only non >> secure stream IDs. Min have the list of stream ids which can be enabled for all >> type of boards, while max is for boards which can list all in HLOS given kernel >> is in EL2 mode. >> >> Below crash would be seen if boards running kernel in EL1 mode lists the secure >> ones. > > > That has to be explained somewhere, e.g. comment, Sure, will add a description for iommus property explaining the same. and still we need then > EL2 DTS in the kernel. I did not see such so far, but maybe I missed it > - can you link it? > EL2 DTS for kaanapali is not yet posted to handle secure SIDs. While it is in development, describing the secure stream-ids would ensure to cover all the hardware generated IDs. >> >> [ 1.361157] pc : qcom_smmu_write_s2cr+0x64/0xa4 >> [ 1.361165] lr : arm_smmu_write_s2cr+0x2c/0xbc >> [ 1.361168] sp : ffff80008005b8f0 >> [ 1.361169] x29: ffff80008005b8f0 x28: 0000000000000000 x27: ffffc7f252f45320 >> .... >> [ 1.361195] x2 : ffff800081200c48 x1 : 0000000000000048 x0 : ffff800081200000 >> [ 1.361198] Call trace: >> [ 1.361199] qcom_smmu_write_s2cr+0x64/0xa4 (P) >> [ 1.361203] arm_smmu_master_install_s2crs+0x7c/0xac >> [ 1.361207] arm_smmu_attach_dev+0xb0/0x1d4 >> >> Could you please suggest on listing the iommu items ? I did not find the >> relevant references in other bindings where flexible iommus is being listed. > > > Just like every other list property - clocks, resets, power-domains. > something like iommu-names: items: - const: 0x1943 - const: 0x1940 ... given that one of vpu sub hardware generates multiple SIDs, if we go with sub hardware name in the list, the names would be repeated. >> >>> >>> I already asked this. >>> >>>> + >>>> + memory-region: >>>> + minItems: 1 >>>> + maxItems: 2 >>> >>> Same comment. I already asked this about iommus. >> >> Same here, there aren't any bindings which lists for flexible memory-region. >> Please suggest if there are any such references. > > Because they do not matter for all other bindings, but it turned out > recently it might matter for this device. memory-region: minItems: 1 maxItems: 2 memory-region-names: items: - const video_mem - const iris_resv Regards, Vikash > > > Best regards, > Krzysztof