From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5453934B68C for ; Fri, 13 Feb 2026 09:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975646; cv=none; b=ZvlK07WQVvfJwoz2S5UGNTOJKmMNBzCHHOhvOuC/tervGKivD2udzlOX+ZimhuGLAQANojqaVij9Y6zOBM95hma0+k5nqndq5p+umUi07fSVLxGKna1NZYuL9QR0soFokLPTdpa/3NpDKpwBXz709DlVJTR8Rr+VgjJh5Ujhn8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975646; c=relaxed/simple; bh=U7P3olTVkeLfckuqtGg3Ez5sD1mEL8bWEzzRb2X9380=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rERTxyOJNu+2Q+AurN9hwXJoZhHCWMKQ/BiZTg/a/G0ZkB51eGvKaFj+sqMiUkwqrXs3TgZGX3FIdM8gHs+Rf44x3Vp42MSRZBxh+sj4p1jc1DsoDHOYWrgK8+gdw9spP5CTaoShdOBSrKy8h2RkE6KbQFLsk6oRZXRjeI3gciE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dwz+Ec1s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DU7bKN5t; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dwz+Ec1s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DU7bKN5t" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61D83SHl652726 for ; Fri, 13 Feb 2026 09:40:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z/lfOtspcFXBYF/xLcKmtVed+E+KcHC6N491qAFBLng=; b=Dwz+Ec1shTYtQITA ToovLj98oZarfPQUb5fZIrOu6V3eV3q2NlN//7lGN/Rs76wZPJ5GZ/KXp5urIXEa 5jqbHFfi1HSYmUGM8XelNyiYAY2BFzGcOKKlLY/GgP0GPUJ4q2TMENcCQ3p+hu1L OLNQVgnpsU7fkw6pC4fCmycWJb1sh8G3DuebOQFbU4UjV6Ceupvnvrpd+lCzd07Q cwzJP/fpmyQAwImGf3eVJtcXQkRge7OhWiXLPLqgnEwu+NH6EGkhdoWxqwBKrs0Z FLQmtk6+Piu2FrbL/dAsxTleHSE6jwQL0EeJmLfAYmBWKAVINU6/M6bGk7CneC/K jc216A== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9gbbkv5r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 09:40:43 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c6e17c2a488so1944710a12.1 for ; Fri, 13 Feb 2026 01:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770975643; x=1771580443; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z/lfOtspcFXBYF/xLcKmtVed+E+KcHC6N491qAFBLng=; b=DU7bKN5tcErWUevkl3U1Mh3dK5QCR9nWFB858M4Tlvd1YWkgxV8HU/rjouUa2ykjsP vOOkzHkq0djzqeehwh0DkDEwiOoaIldzggnnJEjManTEzd/km8bJiv4YKeNXP8H5NFqg QFZVUJuZxAYDL0TJeTPgB4vobAOu2fKNYytbqICTt5exyZiPsSSpu7p9zDj9eNoGGXcj G/CIREOYAPpp++dG49URty3OMb2kme0Tf4hKBhCbt3avPjwFGt9f48nP3GamgiO7/StY lQT9zqFEHxX0rZEQvlwBdXdmtxAH6MWhs3kF+oe915lDK3GUxKerwe1Xf+496eLcG3l9 9VXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770975643; x=1771580443; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z/lfOtspcFXBYF/xLcKmtVed+E+KcHC6N491qAFBLng=; b=HUf9NCSInok5BinmD0N9GGmckksALq/Jm5oOekYlQywOXHaTrtt455kC7Zeq/LFzCu hG2pROaDwqItMZ3RAPKvf5s964wUW2DuNLNxjJkieNwtbN3fcXOBozHkr1pz+H48o3lw XjI3eFk/ngdMgSz41a8aB3IOJ/dRTZsn3PnR32t1xagVJvhn623BbTBna33OeySWHOZT VX6Sv30etURu5shiQgn1627cJmIc2gDzfuQAjCXs1w/VgSBxkD6bmgZhlhac9mE1Z5HS 6l6s9HjR7h+7h7dgzrCB95Vms5V0sipeHOpFLEV3fUpHtsDwAwBFrKQ9jrqjl7DtYk8A 9faw== X-Forwarded-Encrypted: i=1; AJvYcCW05N9GsELrvsrQUqJxQICq2HPwtADDIesINWetS0jv1gYITkX4+Cl6eEkvfm/kgcPs9LLTMLSV1ZQhEKRO@vger.kernel.org X-Gm-Message-State: AOJu0YyxLFejaL7XQMGQoFknJNNJy6Xs7hlvpeNygxDiOyEv9Kgvc4+h n0nKbw0We0niLfEJN/wcctwKYRi2gUE8MJYBjtI5Kd6L4opxD/h5t7Kny5Ti/rh1MPKpWNXths8 lDIMx7iIlf0FQvlYiBK+2QQZH3foHeCwnFSD0NCV4N8j4ESbn9KHianGRpvteA06yxR8R X-Gm-Gg: AZuq6aIIu41Pt9iNCLVsbpjJKVQ/n5dDwyvQlZzukpHV+HuqmcCBPfyLn5Wz1p8W6XB veJzipHsExKtsr68Yn/46tPsp+kGr2jC5noupmYY6JC3FHHTQn5mNzuzdgCGdyosU/sKlmDBEhR +VCWiC786s521IoCILU74BDcIdCQRAQxHgtoOBEOhGG155056iWk0ac6+tYkS52s0b4oQ2yGpi7 LSihLqQjmH92byqKKSFxAqVQ5D9fLitYUSPQ5e+iu1cX4qYSr2A2DrqAhqkfHHYazeh0J+7Fpvd wR9QrySrfqIVF8kiFbmci6kqR4R+r8C2D1E9CLQVNLWHFbDkOHXSAlz3LqxYIVaTJok+nCto2Gr M2e1QAxroEGn7Mw1euyBtv2rt/BtnuJMB6b2pAVzeQjxlLH36Q2S0AQ== X-Received: by 2002:a05:6a21:a345:b0:38d:edd4:2fc6 with SMTP id adf61e73a8af0-3946c9252a8mr1267459637.70.1770975642895; Fri, 13 Feb 2026 01:40:42 -0800 (PST) X-Received: by 2002:a05:6a21:a345:b0:38d:edd4:2fc6 with SMTP id adf61e73a8af0-3946c9252a8mr1267441637.70.1770975642488; Fri, 13 Feb 2026 01:40:42 -0800 (PST) Received: from [10.0.0.3] ([106.222.229.190]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a4316fsm2530543b3a.23.2026.02.13.01.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 01:40:42 -0800 (PST) Message-ID: Date: Fri, 13 Feb 2026 15:10:37 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] media: iris: Fix dma_free_attrs() size in iris_hfi_queues_init() Content-Language: en-US To: Thomas Fourier Cc: stable@vger.kernel.org, Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260213091330.23431-2-fourier.thomas@gmail.com> From: Dikshita Agarwal In-Reply-To: <20260213091330.23431-2-fourier.thomas@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDA3NCBTYWx0ZWRfX7wm8Y4fNzPek JVikWEQe4XAmNp+up8O4wtU+EuyauhHD3MfND9JOpYFUTPVHn79yjMX3q8p/Bce+Qs6BSQ1zbi7 tWeIdGofwH6MeKmP8vGNOxiiJ0vY9JRQ/zlMedna0m5oWuqpnm72y7TJhRmKF4tqmiihkw3Iq8T Mb4l78lBTZJuBse+LZqDoRtgBFNUO1d08YuMU5/xhZ32tRnUowpX6tHuOA9WT8LhfCDa0jPMJfW L4QMKBeGpQgC+uTWPrT68D4v07JEa4uIfk4GwhYZr/EInKIE0+4g1qcBJIe/hFOgwyVIDdOFz1g AyBnqGwfTwOzV/R4naPQGgjXVHkTit4W60gqVDEpYL67yiTTXQnRg27hEQQijYROI9OAcYnpAvQ ni8KDczJxNHf1iCmw2W+V0YbztStoX6fuwnlGRYvMxVRyEXl8Fvo8W/hk5e1T847pjMaF74HS4w m2kBHCrgUcTIH1/Cnxg== X-Authority-Analysis: v=2.4 cv=a849NESF c=1 sm=1 tr=0 ts=698ef19b cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=VDDfqcjMpRzOalc4LhIaOQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=jz17cmUFc4N99GX7AB4A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: EUDNVCPOBrIkJrae0ghloiOxOBJuw6sV X-Proofpoint-ORIG-GUID: EUDNVCPOBrIkJrae0ghloiOxOBJuw6sV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130074 On 2/13/2026 2:43 PM, Thomas Fourier wrote: > The core->iface_q_table_vaddr buffer is alloc'd with size queue_size > but freed with sizeof(*q_tbl_hdr) which is different. > > Change the dma_free_attrs() size. > > Fixes: d7378f84e94e ("media: iris: introduce iris core state management with shared queues") > Cc: > Signed-off-by: Thomas Fourier > --- > drivers/media/platform/qcom/iris/iris_hfi_queue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_queue.c b/drivers/media/platform/qcom/iris/iris_hfi_queue.c > index b3ed06297953..bf6db23b53e2 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_queue.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_queue.c > @@ -263,7 +263,7 @@ int iris_hfi_queues_init(struct iris_core *core) > GFP_KERNEL, DMA_ATTR_WRITE_COMBINE); > if (!core->sfr_vaddr) { > dev_err(core->dev, "sfr alloc and map failed\n"); > - dma_free_attrs(core->dev, sizeof(*q_tbl_hdr), core->iface_q_table_vaddr, > + dma_free_attrs(core->dev, queue_size, core->iface_q_table_vaddr, > core->iface_q_table_daddr, DMA_ATTR_WRITE_COMBINE); > return -ENOMEM; > } Reviewed-by: Dikshita Agarwal Thanks, Dikshita