From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40F9B1C4609; Wed, 30 Oct 2024 18:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730313219; cv=none; b=kAr2PD6AyRg7fmaB68CD//SEhyieZW+lMlZ/F36gkeI2yOTa1MKypfsHTesF4KNywJvEJq49IES9grdQEbyidUdVFlHtUB1bbLNt0d6f3RAKqLHUhr+aJFmLqHn8sTAFYIu+lQhdW3S9cMqCACuMPhCYovRsTUd2cb9oB5qc9IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730313219; c=relaxed/simple; bh=i1Vs+7snV2Whc8f6U4PmBh6VsCX0+I5O+FA19QQQ8Zc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gRqytQCv8rhM1/IxTexbUF4dqYvFxhvhHi2FigLJ4XD5/BlOybGJwGTZ46b3xAqBW6HcZsthn4ODx+S6T0vmewUPU/Prf7/EkwRYPxt86OIRFOSYS6U3vMf0rNgZG8a1rb8pbdGygJ456OTZ9LKFtL3gGAEtaAhNRA8QblqeXh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ssZpHRT+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ssZpHRT+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E615C4CECE; Wed, 30 Oct 2024 18:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730313218; bh=i1Vs+7snV2Whc8f6U4PmBh6VsCX0+I5O+FA19QQQ8Zc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ssZpHRT+81QCH4z3lYknBPqPUmXyY2aCZXWUFdWHT64I0J58DNulHJbkD86LdukAQ 3HpxZsV9DNKw952+G+SlBuMPZAwL/+0XvFvLsckdyPQCgP6WTLklxm0n0RMggf5BUI lybXjFuPuF/sxTA5mDTiI5BUTevioWDFUQZV9gjO/fmzlbyHcdT2begfreTLvuk7QU 9cPrZn+FRQLMtvN/bFBGoiH2F9Ee1AIDFHStGcsgP4W9mCLXv6USo4R8z5bIg7uopw CODbkBitPcS8QAEEl94T9+j4dGhxd/g8oAhEtOaGicg7v48Zh5N5Yb5vLNCyKxh/bd WhwSeVN9C24aw== Message-ID: Date: Wed, 30 Oct 2024 19:33:30 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/5] dt-bindings: media: camss: Add qcom,sdm670-camss To: Vladimir Zapolskiy Cc: Richard Acayan , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org References: <20241011023724.614584-7-mailingradian@gmail.com> <20241011023724.614584-9-mailingradian@gmail.com> <785c82d5-549d-454b-86bf-a00a39e6f521@linaro.org> <955ea816-5394-4dbf-ba46-441634a97685@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <955ea816-5394-4dbf-ba46-441634a97685@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/10/2024 15:06, Vladimir Zapolskiy wrote: > Hi Krzysztof, > > On 10/11/24 17:29, Krzysztof Kozlowski wrote: >> On Fri, Oct 11, 2024 at 10:14:49AM +0300, Vladimir Zapolskiy wrote: >>>> + soc { >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>>> + >>>> + camss@ac65000 { >>>> + compatible = "qcom,sdm670-camss"; >>>> + >>>> + reg = <0 0x0acb3000 0 0x1000>, >>> >>> This is immediately wrong, unit address shall be the same as the address of the >>> first value of reg property. >>> >>> I still object to the sorting order of reg values dictated by reg-names property. >>> >>> There are a few recently added CAMSS device tree binding descriptions, where >>> reg values are sorted by address values without a connection to another property >>> values, and I believe this is the correct way to go. >>> >>> Two most recently added CAMSS IP descriptions (qcom,sm8250-camss.yaml and >>> qcom,sc8280xp-camss.yaml) do implement sorting by reg values, I believe from now on >>> it should be assumed that all subsequently added CAMSS IP descriptions to follow >>> the same established policy. >> >> Heh, sc8280xp introduced entirely different sorting also in interrupt-names. >> >> Just look at interrupts of sm8250 and sc8280xp. Luckily clocks are still >> keeping style. >> >> Can you start keeping consistency? All bindings from the same family of >> devices, especially if they share something, should have similar order >> in lists. >> >> How do you imagine writing drivers and request items by order (not by >> name) if the order is different in each flavor? > > I don't see a problem here, and I don't remember any reports about this > kind of problem while adding CAMSS support in the driver to new platforms. And I see problem, would create enormous probe code to handle different variants for clock[0] and then clock[1], etc. > > While the problem of improper CAMSS unit address appears again and again, > the focus shall be on removing a chance to make a commin mistake here. This is not a problem. Tools already point it out. Order of reg-names also does not affect that, you can put fake unit address regardless of the order of reg-names items. > > As I've already said above, device tree bindings of CAMSS in two most > recently added platforms sm8250 and sc8280xp follow the numerical order > of addresses from reg value. This becomes the policy. > > Sorting lists of interrupts or clocks by numerical values makes no sense, > thus the argument of *-names sorting becomes valid here. For clarity, reg There is no such argument, no such coding style. > property is very special, also a snippet of its value goes as a unit > address. And order of items does not matter for above "specialness of reg". Best regards, Krzysztof