From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D779C7EE24 for ; Mon, 8 May 2023 08:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232904AbjEHI1g (ORCPT ); Mon, 8 May 2023 04:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232968AbjEHI1f (ORCPT ); Mon, 8 May 2023 04:27:35 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8EE040DA for ; Mon, 8 May 2023 01:27:20 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2ac78bb48eeso46867111fa.1 for ; Mon, 08 May 2023 01:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683534439; x=1686126439; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=vzzV7o/cRkyKA4fMWXATwiDXCBGn/V28RB2TejGS6dQ=; b=BOxdMBvp1HrfPZ+qau8r94f0FRFatA17u+z22i0l2fkuKKHAaHiRTrYNuuq4bwxrM1 6uQOneD4Kf93zRl1fUQOYNGuC4rRkQuqKbS8sP+CuvPQz/+OlqRZ6VLRjvhQwV4h1Bma 3kToglCIn2qNbketePpc6CFP0/HUm/mWRQ+1xtjHZqclDwek5qsiW09dO7cF07eKtUt6 hJgSljUmxH/Ew5NiZSIny+/M4A6UANFqIpv2JV0ZsdKH2vZZXeF4iqojRfiA59zNGx9j pN6qeSShY3FB//xOfBfHtTL/JSCHwUDjo9tnpHmrV98a4S/Ghe1ycQIIqkFBFRyNiqCB peWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683534439; x=1686126439; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vzzV7o/cRkyKA4fMWXATwiDXCBGn/V28RB2TejGS6dQ=; b=aRMCZASUyQ94WjyckjKUGfy6vcBsKkBJGkSvoVDBPmRo9XXvYmHRBSnHr/gz/H72F7 NltcCmXYyvgsvwfzkksl4NUuA1FqdofBm8FpkUef0eItsrbu02DpQeHCOWZUqmi5erQn rxzm3LNnYndKA3qugSBDdT02hNHABMJeO/oC0QJRNE0/bPbWkAFPYsDqbWQgbh5cbgv5 n0MeU+9HB8hcdEJc0374DIBimPRzXCF+cmYx0dJu/42fdsdflT1MyLOHmx4R2/8jcGH2 I82h6KRUU44xuEZJgcEEuqm/IDI7a013vf7ycH9QXRoQf3BHd1E1DOWz4xLgw0JK780U ex9A== X-Gm-Message-State: AC+VfDwLbCefFUmE0BYFYnkZlPa4R++qsk7Eq9kr+j6cj62t6eELIhyS grsLqxLELGyVjECyhYMXeIRP3Q== X-Google-Smtp-Source: ACHHUZ5qclbC/4fXs8Csx4zA7yUD6Fxk+2k5Mo6A6zP7h3IIYUYWAQruEGHiOsM/rUZaTmTea8Zq6Q== X-Received: by 2002:a2e:2405:0:b0:2a7:73a2:d915 with SMTP id k5-20020a2e2405000000b002a773a2d915mr2448295ljk.5.1683534439064; Mon, 08 May 2023 01:27:19 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id i22-20020a2e9416000000b0029c36ebf89asm1088596ljh.112.2023.05.08.01.27.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 01:27:18 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 10:27:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Stephen Boyd , Michael Turquette , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org References: <20230507175335.2321503-1-dmitry.baryshkov@linaro.org> <20230507175335.2321503-2-dmitry.baryshkov@linaro.org> From: Konrad Dybcio Subject: Re: [PATCH 2/2] clk: qcom: mmcc-msm8974: fix MDSS_GDSC power flags In-Reply-To: <20230507175335.2321503-2-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 7.05.2023 19:53, Dmitry Baryshkov wrote: > Using PWRSTS_RET on msm8974's MDSS_GDSC causes display to stop working. > The gdsc doesn't fully come out of retention mode. Change it's pwrsts > flags to PWRSTS_OFF_ON. > > Fixes: d399723950c4 ("clk: qcom: gdsc: Fix the handling of PWRSTS_RET support") > Signed-off-by: Dmitry Baryshkov > --- This is a stopgap solution, not exactly a fix, all signs on Heaven and Earth say that 8974 should support retention on this GDSC! *although* pre-v2.2 chips don't Konrad > drivers/clk/qcom/mmcc-msm8974.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c > index aa29c79fcd55..277ef0065aae 100644 > --- a/drivers/clk/qcom/mmcc-msm8974.c > +++ b/drivers/clk/qcom/mmcc-msm8974.c > @@ -2401,7 +2401,7 @@ static struct gdsc mdss_gdsc = { > .pd = { > .name = "mdss", > }, > - .pwrsts = PWRSTS_RET_ON, > + .pwrsts = PWRSTS_OFF_ON, > }; > > static struct gdsc camss_jpeg_gdsc = {