From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12475C05027 for ; Wed, 8 Feb 2023 18:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231208AbjBHSTe (ORCPT ); Wed, 8 Feb 2023 13:19:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbjBHSTd (ORCPT ); Wed, 8 Feb 2023 13:19:33 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2038630286 for ; Wed, 8 Feb 2023 10:19:32 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id p26so53162512ejx.13 for ; Wed, 08 Feb 2023 10:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8j1Bi9kv3dnc4UgTQ2QLvAX5UEkvT1snCnRaL/lrdVc=; b=ESo1UeW5CGGyokTezx8utgulMXPoyULquRvBzoZE6ZUKyhj7/BLN6FPAo7DWrGE8Cu 30xODadrJtq0/H3bx/s6LwBIf3pTNzQSVfWyHsBsAhDSXj4idgkXtceX3qRFDkuYWv/G PXQbH7561MWKhaPdcDSxv/R08uhBgRk5gaW500kjUNLqmNu9Ao5yUvbu/GNeKo/X0IDi oOfcgn5+k1meX/h65uBRhQHiybcrawHadD6dLoYvwYhQdg+OAKPhCgf53DKgh8E371mk ZlWhVezQmkflGYVZ074xFbN4MdTeMVQZ68//EX2lOr3BpXE4ZMpoGp2KnrqbdaqZevRh eQSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8j1Bi9kv3dnc4UgTQ2QLvAX5UEkvT1snCnRaL/lrdVc=; b=atZUxjm+Bi88Thfp29LD6ra0P7EVbvvQC4I9iXICRzBRIInvNTAFVgsRkgL9TcKNMr 3fUN5diilbwZd/UVlsJsFK4c3REfR+gfUVJ+sGdiRuT4xeKtjMZxKlN1lp6PcH7jo+tA f7UY+KNAK+XbCSv53xfYvq49PPNCxP5RIeBefv2jRBKpN5UDNUa5CBdXs9FNnBWo1+Jg CK81XvllypRR6T1VdtPNyRcprFlEz56aX1REHw4Ttr/0XVt7DjIveMktu157Ti+pELrU 449u7goQWHaw6qXNYBFpcnnQ9xtfZ/TWLd5b3Zl2tdZMEk58r+dmvAQZa75KRnVlMEyz q5sg== X-Gm-Message-State: AO0yUKVu/JvtVt4waluz8eC5reGs5HGOapNycmpRonv4ezfFlulxBRb6 eJ1iiofUDlwryjhaI6v9zvzVMg== X-Google-Smtp-Source: AK7set+DmXpRl0cOZjV99cvxKq1YbzS7UsUzQtQaOETK5opB59GdKb3+ogZDXDBqqph9fDCnEuRClw== X-Received: by 2002:a17:906:5fcb:b0:88d:ba89:183e with SMTP id k11-20020a1709065fcb00b0088dba89183emr4035691ejv.15.1675880370645; Wed, 08 Feb 2023 10:19:30 -0800 (PST) Received: from [192.168.1.101] (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id gh25-20020a170906e09900b008841aa86484sm8645882ejb.211.2023.02.08.10.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 10:19:30 -0800 (PST) Message-ID: Date: Wed, 8 Feb 2023 19:19:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc8280xp-crd: Introduce pmic_glink Content-Language: en-US To: Bjorn Andersson Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230208034620.2048744-1-quic_bjorande@quicinc.com> <20230208034620.2048744-3-quic_bjorande@quicinc.com> <229edfec-736f-d94d-23ba-2a0649639556@linaro.org> <20230208155720.GA2397622@hu-bjorande-lv.qualcomm.com> <20230208180007.GB2397622@hu-bjorande-lv.qualcomm.com> From: Konrad Dybcio In-Reply-To: <20230208180007.GB2397622@hu-bjorande-lv.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 8.02.2023 19:00, Bjorn Andersson wrote: > On Wed, Feb 08, 2023 at 05:40:44PM +0100, Konrad Dybcio wrote: >> On 8.02.2023 16:57, Bjorn Andersson wrote: >>> On Wed, Feb 08, 2023 at 09:14:46AM +0100, Konrad Dybcio wrote: >>>> On 8.02.2023 04:46, Bjorn Andersson wrote: > [..] >>>>> &usb_0_dwc3 { >>>>> - /* TODO: Define USB-C connector properly */ >>>>> dr_mode = "host"; >>>>> + >>>>> + port { >>>>> + usb_0_role_switch: endpoint { >>>>> + remote-endpoint = <&pmic_glink_con0_hs>; >>>>> + }; >>>> This should be defined in the SoC DTSI, it's a standard dwc3 binding >>>> with usb HS / SS / SBU ports. Especially since we can feed the endpoint >>>> from any device now, as pmic-glink should work everywhere. >>>> >>> >>> The sa8295p/sa8540p boards, derived from sc8280xp does not implement >>> pmic_glink, so it seems moving this to the soc.dtsi would be messy. >>> >>>> Or /omit-if-no-ref/, I suppose. >>>> >>> >>> Or you're saying I should put the skeleton of the port definition in the >>> soc.dtsi and then fill it out the remote-endpoint here; and mark it >>> omit-if-no-ref to avoid binding warnings? >> I thought omit-if-no-ref actually omits the node before resolving phandles >> that it references, but it seems to not be the case.. Still, we can define >> the ports in the SoC DTSI and assign endpoints per-device (like we do with >> DSI for example). >> > > You mean move the lines: > > port { > usb_0_role_switch: endpoint { > }; > }; > > to sc8280xp.dtsi and then do: > > &usb_0_role_switch { > remote-endpoint = <&pmic_glink_con0_hs>; > }; > > here? Correct Konrad > > Regards, > Bjorn