From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ankit Gupta" Subject: Re: [PATCH] spmi: add command tracepoints for SPMI Date: Thu, 21 May 2015 14:26:38 -0600 Message-ID: References: <1431985887-23379-1-git-send-email-ankgupta@codeaurora.org> <555BD719.80508@codeaurora.org> <20150520090808.36cf77c2@ankgupta-lnx.qualcomm.com> <20150520182955.GR31753@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: <20150520182955.GR31753@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: Ankit Gupta , gavidov@codeaurora.org, sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, ivan.ivanov@linaro.org, linux-kernel@vger.kernel.org, svarbanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org, Steven Rostedt List-Id: linux-arm-msm@vger.kernel.org > On 05/20, Ankit Gupta wrote: >> On Tue, 19 May 2015 17:36:41 -0700 >> Stephen Boyd wrote: >> > On 05/18/15 14:51, Ankit Gupta wrote: >> > > + >> > > +TRACE_EVENT(spmi_read_end, >> > > + TP_PROTO(u8 opcode, u8 sid, u16 addr, int ret, u8 len, >> > >> > Should "len" be size_t instead of u8? It would at least match the >> > implementation of spmi_controller::read_cmd(). Same comment for the >> > write side. >> > >> > -Stephen >> >> I see no reason to spend to 4-8 bytes when spmi spec allows for maximum >> buffer size of 16. Do you suggest changing the API of read_cmd()? >> > > > Is that a maximum buffer size of 16 bytes? I'd prefer consistency > with the API that's being traced, that's all. Changing it to u8 > to save a few bytes probably doesn't make any difference if the > architecture passes function arguments in CPU registers which are > 32 or 64 bits wide or if the function can be inlined enough by > the compiler to where the len parameter is kept in a register. > Thanks Stephen for your comments. Will change it to size_t. > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project >