From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2776319859 for ; Tue, 3 Feb 2026 23:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160940; cv=none; b=JQd6UOvoY4lHFk3CTPnzdfXSUSqqZa416v/WDSHIrT8gOfRV1EiIGEnm5xkDWUDJ/wQpfxq4K42K0EpX3XRWvzGvFHW3/wbQ4sx8f3y+Ai6dQ/uzCxdmSZFwkdfx3X35wXsOHCqyrmuVy7LVPEvDVWRs/enKL4r8IZaMtEZiba0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160940; c=relaxed/simple; bh=vmGDTvEh0kB/nA8sp+H/PED+RYlPTGDJvMgu8OOxZgU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AhnT0X1YgC1EEjO/nlkrzrLPI95hm/0PEQ3H5iDzRUD0O9NL1ftZ7teFogINUUYfRjGSzYZY2fSr9uAAy5bCE7sOYiTuL0DcABGPfn/+S78BXBbJ6M2QNBJt8FweathUT9WDylarkenYukTCDMyN89q+QqzCFLe7g8t10d+o8EQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lA7Z6LXz; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lA7Z6LXz" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-432da746749so70582f8f.0 for ; Tue, 03 Feb 2026 15:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770160935; x=1770765735; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zHQSzgLVAjnFP4dBv05KnkyuxPSQFJ3wmRvAOwsqKgI=; b=lA7Z6LXzT+vaJ1rbVAfhg+7GjJkYrIgBM/ims6zHGMCYrIxKjmE+WPTRfIzvcSdrA6 jXpZ5dLPLw5gwb75RVqmPp3+pgUFoRZ18CYP6U/dgkpcDx5LKNMhAzamnfaku1LiRPh8 iWyVmJ6+6IgFiVkuGUW9opeO49Fd8zt+lH/PrmgYDzflPy3JCaXnRt+0aUWfmwnQV0yO hqHG96AxXgFcKXIVNuUyYO5q3x5j7gF13SCMf+QIewodnXqcPRV8yxRjS72a4wNk0LTn aeTtg0nxCbrFvDYRBkoawUU+gbtm1DkOTxo5zGzc8INEo5nDZ2hWxOZ/LTBVglaKaAeZ iuEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770160935; x=1770765735; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zHQSzgLVAjnFP4dBv05KnkyuxPSQFJ3wmRvAOwsqKgI=; b=L8KHvRs4jpx0D1bIfm6e/0e4cWCs/hTb55kkCL2qxJOKC8rDqGjELdS/E9/kD83fHU LC7ZH/IL8XpUQuFKTsLN2jKU8PwgomsK3elVr3Rhkc8WPWx4K7tbcAZGvKR0ZDN26VdO +OKfGQ5M/ETqvJVnttIbKSvDrJM1C6+2hm/CFbqxaUELv3oVJYjxQZndeXmvxsL8alCW efZ1Knn3NalbOmueRYmdQvSyTtjCW0XAyEo6Xbs5Oi9PSn2ZpHJXKrv7aGejs0mIsLrI PTAEVNyF7zMb2GPipk9cTQs83B1gY0KiKR7Mvp7hlvjSAU2ZKe+rZZIFyE0dqvLqkYkW xPoA== X-Gm-Message-State: AOJu0YyiJR+0u1AsXQs9cjRcgNb4uUK88yoffvfjBfSos8EuLl8ocAJ4 EQipcV8nNQYwVPLL6UPiqoHEQ4kSIPmSthvIgvbhuJrJaI9G6/LA2QdTxjqsH4LmSfk= X-Gm-Gg: AZuq6aJBcU/s7vIznv9AxXOSImEQHp2FJwPP4lqURSZ06cZ6DG+x2tBMxxqoFkaC+Jl qn4C4r4FRw0jGC6tB4CdhBG3oE0YDMNZo+2kpq20z+XqF7J295ngW9NIBam6GtZVJeajCSKfWPY PqeXyuw2yJMtNeBkNJ49zrkBDhC1bWtGSU0IPKPk5dF9MJvbsFVNmFEtc7QpzanJsIrfXQKmCOp q8m0vrruhO++H7olAjsGb++pA4ywpJRjw8vlCEr+TkL1ULFR5Iq3QTIXMyFp5Vy1b+MwfuK39HE EZbQ36mKcmrTu7ODVp5KWKLPE6CO1gez3WkgwiFU2Bbj6JuqXnf2JmQHfWpMd/lcO71rX4IlciP 8RHwKwqHv3NxlI7mb71PdmzbX1U/DcEKlAJ4c1ip3ZtirthlcFiBtLnL3/smkTYM82mKy6Dguxj udr9fywaIhmO0dhEPS/nK0L+ZJB5R9RTa478p/kyVjL3rXXRr8gA6qZNroTmfTc3I= X-Received: by 2002:a05:6000:603:b0:436:143c:c000 with SMTP id ffacd0b85a97d-436180593b3mr1240527f8f.45.1770160935331; Tue, 03 Feb 2026 15:22:15 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43618057f7csm2010133f8f.23.2026.02.03.15.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 15:22:14 -0800 (PST) Message-ID: Date: Tue, 3 Feb 2026 23:22:12 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/8] media: dt-bindings: qcom,sm8250-venus: sort out power domains To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260201-iris-venus-fix-sm8250-v2-0-6f40d2605c89@oss.qualcomm.com> <26272oeYIcfP__dNdKT_lizJQ9hvr9jKE2zsy_3aiWVlymjbtHB5vToDV_2DL3N8gIxnqB_YminHDztbUanmwg==@protonmail.internalid> <20260201-iris-venus-fix-sm8250-v2-3-6f40d2605c89@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260201-iris-venus-fix-sm8250-v2-3-6f40d2605c89@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/02/2026 10:49, Dmitry Baryshkov wrote: > First of all, on SM8250 Iris (ex-Venus) core needs to scale clocks which > are powered by the MMCX domain. Add MMCX domain to the list of the power > domain to be used on this platform. > > While we are at it, drop minItems from both power-domains and > power-domains-names, it doesn't make sense from the hardware point of > view. There are always 2 GDSCs and two power rails wired to the video > clock controller and Venus. Disallow passing just two. > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > index da54493220c9..04cbacc251d7 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > @@ -21,15 +21,14 @@ properties: > const: qcom,sm8250-venus > > power-domains: > - minItems: 2 > - maxItems: 3 > + maxItems: 4 > > power-domain-names: > - minItems: 2 > items: > - const: venus > - const: vcodec0 > - const: mx > + - const: mmcx > > clocks: > maxItems: 3 > @@ -114,8 +113,9 @@ examples: > interrupts = ; > power-domains = <&videocc MVS0C_GDSC>, > <&videocc MVS0_GDSC>, > - <&rpmhpd RPMHPD_MX>; > - power-domain-names = "venus", "vcodec0", "mx"; > + <&rpmhpd RPMHPD_MX>, > + <&rpmhpd RPMHPD_MMCX>; > + power-domain-names = "venus", "vcodec0", "mx", "mmcx"; > > clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > <&videocc VIDEO_CC_MVS0C_CLK>, > > -- > 2.47.3 > > Reviewed-by: Bryan O'Donoghue