From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB6EC6379F for ; Fri, 3 Feb 2023 10:56:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233096AbjBCK4T (ORCPT ); Fri, 3 Feb 2023 05:56:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233076AbjBCK4M (ORCPT ); Fri, 3 Feb 2023 05:56:12 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FA0F991FA for ; Fri, 3 Feb 2023 02:56:03 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id mc11so14182702ejb.10 for ; Fri, 03 Feb 2023 02:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BdYRjOM1n9bt8CN7mBjbmqA+shKAXX8Ovt8jaNWTShU=; b=TTe8dPHkBNkUesxIWp8id6+kZt6bBhVLN1AbM9Q2yUCXy0U0dQnhiMNlSNMCzYlgVh ZJW5B+IG4lEzWL1mLjJWKnN8UQFbKZMQPETLWbYmHSN0LcAy/We92w1jDFhdutqAY0XS 5AuBsWSWyyfvrOr6kJ315r7Lcv3OK9WY0u+NshplJxk9jO3CUwvRdr9gDuhaUcAJEel2 Rxk6vJlam0U+WN0pRVaHVSDFYHhIJTyfbexAko7p3nLyc6AiCCJc/MLchscD7GbZqEre lCD6Dl3muFeI/L+0vtEjM8LVGU+9/lNYdSaHB03zKVEfGZTlRD99lLBWIaMdfvO+Xuu/ W3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BdYRjOM1n9bt8CN7mBjbmqA+shKAXX8Ovt8jaNWTShU=; b=GUorAIR1jLrO33x2Z2AfKePWRsicZ4ecxvHupy1VTKCydEJDYrV6IhIMZ/twRlRS// JL0W527jG7qMWT7Nw8je5wGRpkuRjoSoURwqdF77gylx16v9uDHYK398J7ljDZjju3wH Y645Tcq1u3ZJRjqEiR1UdokBhwNM78uPSUN8NFDzSpJ69Q6cVUnasFq7nbwSn6KUF3wc 37GwwVpJtda8VdHQRIHnedsIQPivC5iSyBYGDTO/fFwNULSuyuYeIgFnzEcCZ15erJY5 om+P0kOcG+y+bujYORZfspDcviUj+1pmXFjXQ7CnGoKRr4QUW+p6XhzQRPuJJgrVZZTN 0pqg== X-Gm-Message-State: AO0yUKXfT7qhci6oPiEVhCxQk15HFXRTgb4GmuR91gtFBkwHhr7BUevG UD0Kx1ADJUmaKQRlryU4WW1OlQ== X-Google-Smtp-Source: AK7set+MxWM0+nZqvviW/bwAcAGYQkQyWGDadUbnUIpVzeXcg1uw20STr4HiMhMPlosIWq5Jv3GQrA== X-Received: by 2002:a17:906:9610:b0:878:5e84:e1d6 with SMTP id s16-20020a170906961000b008785e84e1d6mr11002336ejx.75.1675421761914; Fri, 03 Feb 2023 02:56:01 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id p2-20020a170906498200b00878803d4049sm1219445eju.93.2023.02.03.02.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 02:56:01 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 11:55:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH V6 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 To: Kathiravan T , Devi Priya , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com References: <20230202150619.22425-1-quic_devipriy@quicinc.com> <20230202150619.22425-3-quic_devipriy@quicinc.com> <1d144aa4-6f0f-b10f-1d32-4acf4e06ae85@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <1d144aa4-6f0f-b10f-1d32-4acf4e06ae85@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3.02.2023 06:47, Kathiravan T wrote: > > On 2/2/2023 8:36 PM, Devi Priya wrote: >> Add Global Clock Controller (GCC) driver for ipq9574 based devices >> >> Co-developed-by: Anusha Rao >> Signed-off-by: Anusha Rao >> Signed-off-by: Devi Priya >> --- [...] >> +static int gcc_ipq9574_probe(struct platform_device *pdev) >> +{ >> +    struct regmap *regmap; >> +    struct qcom_cc_desc ipq9574_desc = gcc_ipq9574_desc; >> + >> +    regmap = qcom_cc_map(pdev, &ipq9574_desc); >> +    if (IS_ERR(regmap)) >> +        return PTR_ERR(regmap); >> + >> +    return qcom_cc_really_probe(pdev, &ipq9574_desc, regmap); > > > can we use qcom_cc_probe as suggested here https://lore.kernel.org/linux-arm-msm/84f68577f5629e6ef6d6b14357a79f84.sboyd@kernel.org/ ? Yes we can. When you're answering a long long long long email, please cut off parts that you aren't replying to, I had to scroll and scroll and scroll and scroll to get to this sentence and I'm not even sure if you said something inbetween that I missed.. Konrad > > >> +} >> + >> +static struct platform_driver gcc_ipq9574_driver = { >> +    .probe = gcc_ipq9574_probe, >> +    .driver = { >> +        .name   = "qcom,gcc-ipq9574", >> +        .of_match_table = gcc_ipq9574_match_table, >> +    }, >> +}; >> + >> +static int __init gcc_ipq9574_init(void) >> +{ >> +    return platform_driver_register(&gcc_ipq9574_driver); >> +} >> +core_initcall(gcc_ipq9574_init); >> + >> +static void __exit gcc_ipq9574_exit(void) >> +{ >> +    platform_driver_unregister(&gcc_ipq9574_driver); >> +} >> +module_exit(gcc_ipq9574_exit); >> + >> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ9574 Driver"); >> +MODULE_LICENSE("GPL");